Page MenuHomePhabricator

Uploaded file "isn't redirecting properly"
Closed, SpitePublic

Description

Environment:

Reproduction steps:

  • Upload a file (say, an image)
  • Request completes without error message
  • Clicking "View File" produces an error:
The page isn't redirecting properly
Firefox has detected that the server is redirecting the request for this address in a way that will never complete.
This problem can sometimes be caused by disabling or refusing to accept cookies.

Expected outcome:

  • File shows up

Let me know what additional information is necessary/helpful to figure this out. Thanks for your help.

Event Timeline

I can't reproduce this. Here's what I did:

  • Uploaded F1730772.
  • Clicked "View File".
  • Saw image normally.

What can I do differently to reproduce the issue?

I must have missed what @avivey pointed out. Thanks! Sorry to bother you guys.

I don't seem to be allowed to close this task.

avivey claimed this task.

I added you to Community, so you should have sweeping janitorial powers now.

I think we owe @avivey another lunch at this pace. Such eyesight!

@jonah214 said he's using CloudFront (AWS) while that note is about CloudFlare (an unrelated product/company with a nearly identical name) so I'm suspicious there may be more to this than meets the eye (or maybe CloudFront was a typo).

I'm using CloudFront. That explains why I ignored the note, though; it
doesn't apply to me!

However, there is an analogous setting for CloudFront. Maybe add a note
about that.

@epriestley pulls into the eagle-eyed lead!

Clearly we should have a Services starting with "CloudF..." header.

That explains it then; I'm not used to being complimented about my eyesight :P

Okay, I'm still (or again) getting these "The page isn’t redirecting properly" errors when trying to view an uploaded file, or an uploaded image (e.g. my profile picture).

To make sure I didn't screw up the config, I tried a new CloudFront instance from scratch. Didn't help.

Let me know what information would help you address this. For instance, a screenshot of my CloudFront config?

We need detailed reproduction steps which work against a clean environment, as described in Providing Reproduction Steps. We run our entire production cluster through CloudFlare so I'm unable to reproduce the issue as described purely by using CloudFlare.

If you'd like more help than this, see Consulting for support rates.

To reproduce this, I need to change the security.alternate-file-domain config key to point to a new CloudFront instance I create, but I can't change that key from the web interface on a test instance (as far as I can tell, anyway).

Oh, sorry -- you won't be able to reproduce this particular issue in the Phacility cluster.

Okay, so how should I attempt to reproduce this? Any options more reasonable than creating a new EC2 instance, installing all the supporting paraphernalia, then installing Phabricator manually from scratch?

I don't know if this means anything, but the URLs look a bit different between an uploaded file on my new test instance (successful) and an uploaded file on my actual install (doesn't work):
https://d3cn662t4iw3q4.cloudfront.net/file/data/@test-qle2wkabpd66/efgsamshxiln6beajbai/PHID-FILE-qf42qw6khupwrdgh6ccd/puppy
https://d25vbe1uoq79ja.cloudfront.net/file/data/uwpq3ahodqlvn2ghecth/PHID-FILE-echniihw2teyebhjgyy4/another_logo_test_upload.png

I don't have any ideas on how to build a simpler reproduction case offhand.

(You can set cluster.instance to anything to get the /@instancename/ segment of the URI. It should not impact CDN behavior.)

Okay. Is it correct that if I trust everyone who has access to my instance won't upload malicious files (and are resistant to untrusted people manipulating them to do so), I don't really need a security.alternate-file-domain at all? (That is my reading of https://secure.phabricator.com/book/phabricator/article/configuring_file_domain/ but I'd feel better if you told me whether it's correct. I understand that you are not making any guarantees.)

If so, is there a way to suppress the warning message I'll get if I remove mine?

Yes, that's correct.

You can click "Ignore Setup Issue" in the lower left corner of the warning screen to ignore it.

Thanks.

This isn't really resolved, I just decided I didn't care about it. Feel free to change the status to something else if you feel that's more appopriate.