Page MenuHomePhabricator

Inline comments can become separated if replies cross update boundaries
Closed, ResolvedPublic

Description

Inline replies like these:

Screen Shot 2016-03-10 at 3.53.16 PM.png (299×967 px, 33 KB)

May become visually separated on later diffs:

Screen Shot 2016-03-10 at 3.52.23 PM.png (979×933 px, 91 KB)

Rough steps are:

  • Generate diff A.
  • Change a bunch of lines.
  • Generate diff B.
  • Change a bunch of lines.
  • Generate diff C.
  • Add an inline comment on A in the changed section.
  • View B.
  • Reply to the inline.
  • View C.

The reply is against diff B, while the original is against diff A. This can cause the ghost-porting algorithm to choose different destinations.

Instead, replies should just be against the same diff so they always port to the same place.