Page MenuHomePhabricator

Inline comments can become separated if replies cross update boundaries
Closed, ResolvedPublic

Description

Inline replies like these:

Screen Shot 2016-03-10 at 3.53.16 PM.png (299×967 px, 33 KB)

May become visually separated on later diffs:

Screen Shot 2016-03-10 at 3.52.23 PM.png (979×933 px, 91 KB)

Rough steps are:

  • Generate diff A.
  • Change a bunch of lines.
  • Generate diff B.
  • Change a bunch of lines.
  • Generate diff C.
  • Add an inline comment on A in the changed section.
  • View B.
  • Reply to the inline.
  • View C.

The reply is against diff B, while the original is against diff A. This can cause the ghost-porting algorithm to choose different destinations.

Instead, replies should just be against the same diff so they always port to the same place.

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley updated the task description. (Show Details)
epriestley added projects: Restricted Project, Differential.
epriestley added a revision: Restricted Differential Revision.Mar 11 2016, 12:08 AM

D15458 is not a retroactive fix, but new comments made after that change should no longer be separable.

eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 11 2016, 12:29 AM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Mar 11 2016, 12:41 AM
epriestley added a commit: Restricted Diffusion Commit.