Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part)
ClosedPublic
Actions

Authored by dereckson on Oct 10 2012, 2:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 4:50 PM

	Unknown Object (File)
	Sat, Dec 21, 4:49 PM

	Unknown Object (File)
	Fri, Dec 20, 9:50 PM

	Unknown Object (File)
	Fri, Dec 13, 1:59 AM

	Unknown Object (File)
	Wed, Dec 11, 5:57 AM

	Unknown Object (File)
	Sat, Dec 7, 1:13 AM

	Unknown Object (File)
	Fri, Dec 6, 6:38 AM

	Unknown Object (File)
	Tue, Dec 3, 12:18 PM

View All Files

Subscribers

aran

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

Restricted Maniphest Task

Commits

rARC5725585f2dc7: Allow to push revisions to review by himself to Differential (bug T1879, change…

Summary

The 'review its own revision' check is now handled by Differential (bug T1879)

Previous behavior:

arc threw an "You can not be a reviewer for your own revision." exception
if an users adds itself as reviewer, even when this configuration is
allowed on the Differential remote install's configuration.

New behavior:

Arc doesn't check that anymore. It still will be checked by the server.

Test Plan

Tested locally pushing revisions with "arc diff" to a Phabricator server with differential.allow-self-accept at true or false with myself or not as reviewer.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Awesome, thanks!

Closed by commit rARC5725585f2dc7 (authored by @dereckson, committed by @epriestley).

dereckson edited edge metadata.Mar 12 2016, 6:26 AM

dereckson changed the visibility from "All Users" to "Public (No Login Required)".

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

3 lines

Diff 7333

View Options

src/workflow/ArcanistDiffWorkflow.php

Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part)ClosedPublicActions