Page MenuHomePhabricator

Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part)
ClosedPublic

Authored by dereckson on Oct 10 2012, 2:41 PM.
Tags
None
Referenced Files
F13984526: D3674.diff
Sun, Oct 20, 2:00 PM
F13984516: D3674.id.diff
Sun, Oct 20, 1:57 PM
F13984514: D3674.id7307.diff
Sun, Oct 20, 1:57 PM
F13984509: D3674.id7333.diff
Sun, Oct 20, 1:55 PM
F13973953: D3674.id7333.diff
Fri, Oct 18, 3:24 AM
Unknown Object (File)
Oct 8 2024, 2:42 AM
Unknown Object (File)
Sep 18 2024, 2:59 PM
Unknown Object (File)
Sep 18 2024, 2:45 PM
Subscribers

Details

Summary

The 'review its own revision' check is now handled by Differential (bug T1879)

Previous behavior:

arc threw an "You can not be a reviewer for your own revision." exception
if an users adds itself as reviewer, even when this configuration is
allowed on the Differential remote install's configuration.

New behavior:

Arc doesn't check that anymore. It still will be checked by the server.
Test Plan

Tested locally pushing revisions with "arc diff" to a Phabricator server with differential.allow-self-accept at true or false with myself or not as reviewer.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dereckson changed the visibility from "All Users" to "Public (No Login Required)".