Some discussion in T1279.

We're likely to add a reviewername! syntax for the CLI. It would be nice to expose this on the web too, but we don't have a reasonable control for it right now.

OK, thanks for the update.

Does the blocking reviewer actually work from the herald rules? As in, if a diff has two reviewers (X and Y) and X is a blocking reviewer, then the diff won't be marked as accepted until reviewer X accepts?

Correct.

I'd love to see this implemented. reviewername! in CLI would be a good start, even without UI features.

We would really appreciate this!

Our team would greatly benefit from this feature.

Our workflow is to create diffs as a code review for features and we assign as reviewers 2 people who are familiar with the area of code related to the feature. As convention - we require that both of those reviewers accept the diff before it is "approved". The Phab UI hinders us here because it will show the diff as accepted even if only one of those reviewers accepts it. That is, Phab says any reviewer can accept - and we want to say ALL reviewers must accept.

It sounds like what we are needing is this "blocking reviewer" feature that we can't access in the UI. Unfortunately we can't use the Herald rule since we vary the reviewers per diff.

Anyway - hoping our use case makes sense and that this is something that gets added in the near future.

It sounds like you actually want T731.

In T4887#127996, @epriestley wrote:

It sounds like you actually want T731.

Yes! Thank you.

Maybe a good idea too:

• What about if you can configure at owners, if the owners should added as (blocking) reviewers automatically? Makes this simple too.