I've noticed that there is a herald rule (H65) which adds "blocking" reviewers to a diff. However, AFAICT, it isn't possible to create blocking reviewers from other aspects of the UI, nor from Arcanist. If it is possible to, for example, add blocking reviewers from the differential application, then it is not very clear on how to do so.
Revisions and Commits
|Open||None||T10574 A pathway toward "All Reviewers Must Accept"|
|Resolved||epriestley||T4887 Extend the blocking reviewers functionality universally|
- Mentioned In
- T10574: A pathway toward "All Reviewers Must Accept"
T10156: Add an ACL permission to authorize only few people to accept revisions
Q271: How do you add blocking reviewers in differential? (Answer 303)
Q271: How do you add blocking reviewers in differential?
- Mentioned Here
- T731: Allow revisions to have alternate acceptance conditions
OK, thanks for the update.
Does the blocking reviewer actually work from the herald rules? As in, if a diff has two reviewers (X and Y) and X is a blocking reviewer, then the diff won't be marked as accepted until reviewer X accepts?
Our team would greatly benefit from this feature.
Our workflow is to create diffs as a code review for features and we assign as reviewers 2 people who are familiar with the area of code related to the feature. As convention - we require that both of those reviewers accept the diff before it is "approved". The Phab UI hinders us here because it will show the diff as accepted even if only one of those reviewers accepts it. That is, Phab says any reviewer can accept - and we want to say ALL reviewers must accept.
It sounds like what we are needing is this "blocking reviewer" feature that we can't access in the UI. Unfortunately we can't use the Herald rule since we vary the reviewers per diff.
Anyway - hoping our use case makes sense and that this is something that gets added in the near future.