Page MenuHomePhabricator

Allow to push revisions to review by himself to Differential (bug T1879, change 1/2, Differential part)
ClosedPublic

Authored by dereckson on Oct 10 2012, 2:36 PM.
Tags
None
Referenced Files
F18934624: D3673.id.diff
Mon, Nov 10, 4:27 PM
F18918276: D3673.diff
Sun, Nov 9, 10:39 AM
F18859228: D3673.id7306.diff
Sun, Nov 2, 12:32 AM
F18761952: D3673.id.diff
Oct 6 2025, 5:00 PM
F18756302: D3673.diff
Oct 5 2025, 10:44 AM
F18734632: D3673.diff
Sep 30 2025, 10:58 PM
F18723775: D3673.id7306.diff
Sep 30 2025, 2:07 AM
F18348312: D3673.id.diff
Aug 26 2025, 4:33 PM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPb7b783d77125: Allow to push revisions to review by himself to Differential (bug T1879, change…
Summary

Checks if the revision author is in reviewers only if differential.allow-self-accept is false.

Test Plan

Tested locally pushing revisions with "arc diff" to a Phabricator
server with differential.allow-self-accept at true or false with
myself or not as reviewer.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Thanks! Either send me a pull request on GitHub or give me a public email address that I can use for author credit and I'll pull from here.

To be coherent with commit rARC088091ca4094, the best would maybe to use:
Author: Sébastien Santoro <dereckson@espace-win.org>

If coherence in commits history isn't a requirement, you can also keep the current commit information (which should be Author: Dereckson <dereckson@espace-win.org>).

dereckson changed the visibility from "All Users" to "Public (No Login Required)".