If a revision has been accepted by one user, but another user has previously raised concerns regarding a revision (and it has subsequently been updated), then it will be displayed under "Other Revisions" in the bucketed list of revisions.
Instead these revisions should display under Waiting on Review (for the revision author and other reviewers) and Must Review (for the person who raised the concern).
c3bdcb4ca85487921909f0202aa760e8ed61404a (Sun, Feb 5) (branched from 9c62a10989e03e518f855de3fc0a610543287c71 on origin)
67a47acebd6b5e5809745db12955ad251c66004e (Tue, Feb 14) (branched from 224986af634e1dfc40916e5baee76897db4c907f on origin)
58fb3b94464e1c00d0f348d1501bec6b8690253c (Tue, Feb 14) (branched from 82f71f62129bc19f28aeed8c660c931e512a66e7 on origin)
- Create a review
- As someone else, request changes to the revision
- As the original person, update the review diff
- As a third person, review the updated diff and accept it.
This should result in a review with two reviewers, where one has "Accepted" it and another has "Rejected Prior Diff".
This review should then be shown under "Other Revisions".
The only Differential settings we have changed from upstream defaults are:
a) differential.require-test-plan-field: False
b) differential.always-allow-close: True
c) differential.allow-reopen: True
Everything else is at defaults.