Page MenuHomePhabricator

Investigate an Owners-related performance issue on revision detail pages
Closed, ResolvedPublic


An install is reporting that /Dxxx fatals after 30 seconds ("Maximum execution time of 30 seconds exceeded") in PhabricatorOwnersPackage.php:366.

Relevant details:

  • Change affects ~1500 paths.
  • About 25,000 paths are owned by a package.

This is a little muddy but the issue may be straightforward to identify and resolve.

Intermediate issues:

  • XHProf does not build on PHP7 (T9805) but I'm on PHP7 locally now (T12101).
  • Owners doesn't have lipsum support.

Event Timeline

After implementing PHP7 support for XHProf and updating Lipsum, I used bin/lipsum to generate 4,000 packages owning 150,000 paths. I think I have an approximately-reasonable reproduction case locally now, which generates this profile (6.5s for a change affecting about 100 files):

I'll look at fixing that.

@jmeador, I believe this is now resolved at HEAD. Let us know if you're still seeing issues after upgrading?

epriestley claimed this task.

Calling this resolved since the page is now tolerably bad (~5s) which more or less pulls this out of the realm of critical scaling issues.