Page MenuHomePhabricator
Feed Advanced Search

Jun 9 2016

epriestley merged task T8712: Unpublished pholio inlines count towards the total number of inlines into T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge.
Jun 9 2016, 3:10 PM · Pholio
epriestley moved T8712: Unpublished pholio inlines count towards the total number of inlines from Backlog to v2 on the Pholio board.
Jun 9 2016, 3:10 PM · Pholio
epriestley moved T6523: Allow creating/adding images to mocks with a vanilla upload control from Backlog to v2 on the Pholio board.
Jun 9 2016, 3:09 PM · Prioritized, Pholio, Wikimedia
epriestley moved T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge from Backlog to v2 on the Pholio board.
Jun 9 2016, 3:09 PM · Pholio, Bug Report
epriestley added a project to T7924: Unprototype Calendar (v1): Prioritized.
Jun 9 2016, 2:58 PM · Restricted Project, Prioritized, Calendar
epriestley added a project to T10747: Import and export ICS from Calendar: Prioritized.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley claimed T2334: Implement Google Calendar v3 API into Calendar.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley moved T10747: Import and export ICS from Calendar from Backlog to Unprototype (v1) on the Calendar board.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley moved T2334: Implement Google Calendar v3 API into Calendar from Future Work (v2+) to Unprototype (v1) on the Calendar board.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10969: Incorrect Phriction link in email.

Anchor tags got cleaned up in D16083.

Jun 9 2016, 2:56 PM · Phriction, Bug Report
epriestley renamed T11073: Allow the user to specify a date in a different timezone using date controls from Allow the user to specify a timezone when creating a countdown to Allow the user to specify a date in a different timezone using date controls.
Jun 9 2016, 2:53 PM · KDE, Calendar, Feature Request
epriestley closed T11090: Marking comments as done in Differential isn't always saved correctly as Invalid.

This report doesn't include reproduction instructions and doesn't clearly demonstrate a problem: all of the screenshots are explicable through user error.

Jun 9 2016, 2:52 PM · Restricted Project, Differential, Bug Report
epriestley closed T1982: Link to symbols defined or altered in the Revision as Wontfix.

We haven't seen other requests for this in many years.

Jun 9 2016, 2:47 PM · Differential
epriestley closed T7774: Marking Inline Comment as done creates comment transaction as Resolved.

I can't reproduce this at HEAD, presuming it was resolved some time in the last year.

Jun 9 2016, 2:35 PM · Differential
epriestley added a comment to T11044: Support partitioning application databases across multiple database hosts.

After a little thought, I'm leaning strongly to putting every schema on every database. I think this makes a lot of the administration, maintenance and implementation easier.

Jun 9 2016, 1:35 PM · Clusters, Prioritized
epriestley added a comment to T11120: HTML mails malformed.

Here is a string of 2048 unbroken "M" characters:

Jun 9 2016, 1:12 PM · Mail, Bug Report
epriestley added a comment to T11120: HTML mails malformed.

Oddly, in the prior case where mail was mangled for a user on their install but similar mail was not mangled here, the unmangled mail I received was encoded in "8bit", which tends to suggest that this might be an MTA problem rather than an "8bit" problem, per se. But changing the encoding away from "8bit" might be the only real lever we have to fix the MTA.

Jun 9 2016, 1:11 PM · Mail, Bug Report
epriestley added a comment to T11120: HTML mails malformed.

The trigger for the behavior is likely just "long lines of text", we had an earlier report of something similar occurring inside an inline comment snippet (but it could not be reproduced on this install).

Jun 9 2016, 1:04 PM · Mail, Bug Report
epriestley added a comment to T11120: HTML mails malformed.

It's possible that adjusting phpmailer.smtp-encoding (say, to binary or base64) might fix this.

Jun 9 2016, 1:02 PM · Mail, Bug Report
epriestley moved T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks from Backlog to Preflight on the Prioritized board.
Jun 9 2016, 12:56 PM · Prioritized, Wikimedia, Remarkup
epriestley added a comment to T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.

I implemented this, sort of. However, it doesn't work cleanly because transactions are "adjusted" (have old values populated) after they are "expanded" (which generates the @user mention transactions). So when the code runs, it doesn't have access to the old text and can't easily figure out which mentions are new.

Jun 9 2016, 12:56 PM · Prioritized, Wikimedia, Remarkup
epriestley added a comment to T11120: HTML mails malformed.

Particularly helpful would be to write some comment on this task which reproduces the issue for you, then tell me which client you're using.

Jun 9 2016, 12:51 PM · Mail, Bug Report
epriestley closed T11119: arc diff should be able to work with uncommitted changes as Wontfix.

There are no plans to implement this for Git. Git has had robust history rewriting for a long time.

Jun 9 2016, 12:47 PM · Feature Request
epriestley added a comment to T11120: HTML mails malformed.

Can you try this?

Jun 9 2016, 12:46 PM · Mail, Bug Report
kebe awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jun 9 2016, 10:18 AM · Workboards (v3), Restricted Project
epriestley added a comment to T11116: Ponder email for newly created question includes content that suggests the question was also edited.

This will vanish for free when we move to EditEngine, or it could be special cased before that by either:

Jun 9 2016, 1:12 AM · Ponder, Bug Report

Jun 8 2016

jonathanrseawright awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jun 8 2016, 9:51 PM · Workboards (v3), Restricted Project
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

This one feels a bit un-human-like, although it might be tricky to fix:

Jun 8 2016, 8:55 PM · Prioritized, Transactions
epriestley added a comment to T4280: Embed anchor in remark up text and later link to it. .

I think that's fixed in HEAD now. I pushed it here, let me know if you catch any cases which still misbehave.

Jun 8 2016, 8:22 PM · Remarkup
epriestley added a revision to T4280: Embed anchor in remark up text and later link to it. : Unknown Object (Differential Revision).
Jun 8 2016, 8:13 PM · Remarkup
epriestley added a comment to T4280: Embed anchor in remark up text and later link to it. .

Specifically, the issue you're hitting is that [[ x#y ]] and variants thereof generate garbage output?

Jun 8 2016, 8:04 PM · Remarkup
epriestley added a comment to T11115: Ponder Inbound E-Mail Enhancement.

Yes, this is probably pretty straightforward to implement by mostly copying Maniphest's implementation.

Jun 8 2016, 7:23 PM · Ponder, Feature Request
epriestley created T11114: Move Differential to EditEngine.
Jun 8 2016, 6:25 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T10262: Scramble file secrets when attached objects change their view policies as Resolved.

This has been live for a while and appears to be working properly. If anyone is still seeing specific, reproducible problems with cache strategies, feel free to file a new issue detailing them.

Jun 8 2016, 6:03 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley added a comment to T9069: arc patch can't handle binary file correctly.

I think it's probably correct to fail with --skip-binaries, but it would be nice to preserve that metadata through the process so arc patch can warn you about it, something like:

Jun 8 2016, 5:59 PM · Differential, Restricted Project, Arcanist
epriestley closed T9411: Tailor Phacility admin NUX funneling a bit, a subtask of T9303: Improve Phacility Onboarding/NUX, as Resolved.
Jun 8 2016, 5:21 PM · Phacility
epriestley closed T9411: Tailor Phacility admin NUX funneling a bit as Resolved.

I think we're good on the actual Phacility flow, seems like users aren't running into the same problems they used to (e.g., confusion about ""test" instances").

Jun 8 2016, 5:21 PM · Phacility
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

It would also be nice to develop an inline version of this for title changes like this:

Jun 8 2016, 5:19 PM · Prioritized, Transactions
epriestley added a member for Community: neonbadger.
Jun 8 2016, 5:17 PM
epriestley added a comment to T11047: Entering wrong or empty paths renders configtool unusable.

maybe it would be an option to at least identify lethal arguments for commands and warn the user if he enters some. like rm does when typing rm -rf / without --no-preserve-root.

Jun 8 2016, 3:41 PM · Config, Bug Report
epriestley added a comment to T11098: Feedback and Errata for Global Settings.

For completeness, T11107 was also related to this.

Jun 8 2016, 3:15 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T11110: Type-ahead should sort results already present to the bottom of the list, like disabled users.

Can you file a new bug with reproduction instructions? That isn't expected.

Jun 8 2016, 3:14 PM · Typeahead, Maniphest, Projects, Feature Request
epriestley closed T11111: moving storage location hint has disappeared as Wontfix.

This isn't a use case we're interested in supporting. Phabricator creates the repository in a well-defined location, not a random location.

Jun 8 2016, 3:04 PM · Feature Request
epriestley added a comment to T11111: moving storage location hint has disappeared.

That isn't a usable root problem description, you've just restated the original feature request.

Jun 8 2016, 2:53 PM · Feature Request
epriestley renamed T11110: Type-ahead should sort results already present to the bottom of the list, like disabled users from Type-ahead should filter out results already present in the box to Type-ahead should sort results already present to the bottom of the list, like disabled users.
Jun 8 2016, 2:48 PM · Typeahead, Maniphest, Projects, Feature Request
epriestley added a comment to T11110: Type-ahead should sort results already present to the bottom of the list, like disabled users.

This creates a problem for absent-minded or new users:

Jun 8 2016, 2:47 PM · Typeahead, Maniphest, Projects, Feature Request
epriestley added a comment to T11111: moving storage location hint has disappeared.

When filing a feature request, we need you to describe your root problem, not just ask for a feature. See Describing Root Problems for help.

Jun 8 2016, 2:45 PM · Feature Request
epriestley closed T11113: Query error in Conpherence when searching for specific user as Resolved by committing Restricted Diffusion Commit.
Jun 8 2016, 2:39 PM · Conpherence, Bug Report
epriestley added a revision to T11113: Query error in Conpherence when searching for specific user: Unknown Object (Differential Revision).
Jun 8 2016, 2:37 PM · Conpherence, Bug Report
epriestley added a comment to T11113: Query error in Conpherence when searching for specific user.

I think I figured this one out: it's actually because more than 100 rooms are being filtered. The (`id` < 367) part is being added by pagination code, but won't activate if a user is in less than 100 rooms.

Jun 8 2016, 2:31 PM · Conpherence, Bug Report
epriestley triaged T11112: Herald allows setting multiple values in fields that should only accept one value as Wishlist priority.

We should fix these, but I think these are fairly self-evident and I think fixing them isn't trivial since I recall declining to fix them the last time I was in this code.

Jun 8 2016, 2:26 PM · Herald, Bug Report
epriestley added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

I'm not sure I understand the use case for that. Do you set your client OS to local time, but prefer to use Phabricator in UTC? Offhand, this seems unusual. Do you have any particular reason for doing this (e.g., you live right next to a timezone boundary and change zones multiple times per day)?

Jun 8 2016, 1:56 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T4653: Hello Task.

I added you to Community, so you should be able to make edits yourself now

Jun 8 2016, 1:46 PM
epriestley added a member for Community: jayvdb.
Jun 8 2016, 1:45 PM
epriestley added a comment to T4653: Hello Task.

Yes, but why?

Jun 8 2016, 1:41 PM
epriestley added a comment to T8282: What is the purpose of creating an admin account?.

Specifically, you saw this page, and decided that you were not in the right place?

Jun 8 2016, 1:40 PM · Setup
epriestley merged task T11108: "Create a countdown" button has incorrect href into T11046: Create Countdown button on new installs links to wrong place.
Jun 8 2016, 12:01 AM · Countdown, Bug Report
epriestley merged T11108: "Create a countdown" button has incorrect href into T11046: Create Countdown button on new installs links to wrong place.
Jun 8 2016, 12:01 AM · Countdown, Bug Report

Jun 7 2016

epriestley added a comment to T11107: If you forget your password you can never reset it.

This should be resolved at HEAD of master. To get it to work you may need to update and then go through the password reset process again.

Jun 7 2016, 10:02 PM · Bug Report
epriestley added a revision to T6916: Allow video embed in remarkup: Unknown Object (Differential Revision).
Jun 7 2016, 9:55 PM · Prioritized, Remarkup
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

I'm sure there are still some cases where we don't do a particularly good job, but let me know when you run into them.

Jun 7 2016, 9:51 PM · Prioritized, Transactions
epriestley moved T6916: Allow video embed in remarkup from The Queue to Paused on the Prioritized board.

I think this one works:

Jun 7 2016, 9:24 PM · Prioritized, Remarkup
epriestley added a comment to T6916: Allow video embed in remarkup.

I have no idea if this is MP4 or not:

Jun 7 2016, 9:16 PM · Prioritized, Remarkup
epriestley closed T11107: If you forget your password you can never reset it as Resolved by committing Restricted Diffusion Commit.
Jun 7 2016, 9:07 PM · Bug Report
epriestley added a revision to T11107: If you forget your password you can never reset it: Unknown Object (Differential Revision).
Jun 7 2016, 9:06 PM · Bug Report
epriestley claimed T11107: If you forget your password you can never reset it.
Jun 7 2016, 9:06 PM · Bug Report
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Jun 7 2016, 8:45 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Jun 7 2016, 8:43 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Jun 7 2016, 7:15 PM · Prioritized, Transactions
epriestley merged T6674: Support video MIME types and distinguish between audio and video OGG files into T6916: Allow video embed in remarkup.
Jun 7 2016, 6:06 PM · Prioritized, Remarkup
epriestley merged task T6674: Support video MIME types and distinguish between audio and video OGG files into T6916: Allow video embed in remarkup.
Jun 7 2016, 6:06 PM · Files
epriestley added a comment to T6674: Support video MIME types and distinguish between audio and video OGG files.

I'm going to merge this into T6916. That implements a reasonable behavior for application/ogg (assume video by default, allow users to embed as audio instead with media="audio") and browser seem to do fine when audio is embedded with <video /> anyway, so I suspect we'll be in reasonable shape after that and not need to try to determine the contents of OGG containers in a more sophisticated way.

Jun 7 2016, 6:06 PM · Files
epriestley moved T6916: Allow video embed in remarkup from Backlog to The Queue on the Prioritized board.
Jun 7 2016, 6:04 PM · Prioritized, Remarkup
epriestley claimed T6916: Allow video embed in remarkup.
Jun 7 2016, 6:04 PM · Prioritized, Remarkup
epriestley closed T11106: Prueba as Invalid.
Jun 7 2016, 5:40 PM · Abuse
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Diffs should be less choppy now, here's the improved version of the above change:

Jun 7 2016, 4:03 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Jun 7 2016, 3:27 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Jun 7 2016, 3:21 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Jun 7 2016, 3:06 PM · Prioritized, Transactions
epriestley added a revision to T11098: Feedback and Errata for Global Settings: Unknown Object (Differential Revision).
Jun 7 2016, 2:00 PM · Prioritized, Restricted Project, User Preferences
epriestley closed T11101: Subproject tasks get orphaned when switching to parent workboard as Resolved.

Great, glad things are working now. Thanks for confirming the fix!

Jun 7 2016, 1:38 PM · Projects, Bug Report
ponsfrilus awarded T2849: Implement alternate markup engines (Markdown, reStructuredText, ...) a Like token.
Jun 7 2016, 7:12 AM · Remarkup
epriestley updated the task description for T1894: Support commenting on Phriction documents.
Jun 7 2016, 1:24 AM · Restricted Project, Restricted Project, Phriction
epriestley merged T10829: Provide a way to discuss content and changes of Phriction wiki pages into T1894: Support commenting on Phriction documents.
Jun 7 2016, 1:05 AM · Restricted Project, Restricted Project, Phriction
epriestley merged task T10829: Provide a way to discuss content and changes of Phriction wiki pages into T1894: Support commenting on Phriction documents.
Jun 7 2016, 1:05 AM · Phriction, Feature Request
epriestley renamed T1894: Support commenting on Phriction documents from Phriction inline comments to Support commenting (top-level and/or inline) on Phriction documents.
Jun 7 2016, 1:04 AM · Restricted Project, Restricted Project, Phriction
epriestley closed T3353: Make Phriction Document changes reviewable as Resolved.

I think this pretty much boiled down to three technical pieces, all now better covered elsewhere by more specific tasks:

Jun 7 2016, 1:00 AM · Restricted Project, Prioritized, Phriction
epriestley closed T3353: Make Phriction Document changes reviewable, a subtask of T7643: Improve prose diffs (was: description changes don't generate usable diffs), as Resolved.
Jun 7 2016, 1:00 AM · Prioritized, Transactions
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

This is pretty rough (particularly, the actual diff part), but wired up everywhere. HTML email includes a link:

Jun 7 2016, 12:46 AM · Prioritized, Transactions
epriestley claimed T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Jun 7 2016, 12:36 AM · Prioritized, Transactions

Jun 6 2016

epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Jun 6 2016, 10:36 PM · Prioritized, Transactions
epriestley moved T7643: Improve prose diffs (was: description changes don't generate usable diffs) from Backlog to The Queue on the Prioritized board.
Jun 6 2016, 10:31 PM · Prioritized, Transactions
jonathanrseawright awarded T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges a Like token.
Jun 6 2016, 10:24 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T3353: Make Phriction Document changes reviewable: Unknown Object (Differential Revision).
Jun 6 2016, 9:01 PM · Restricted Project, Prioritized, Phriction
epriestley added a revision to T3353: Make Phriction Document changes reviewable: Unknown Object (Differential Revision).
Jun 6 2016, 8:52 PM · Restricted Project, Prioritized, Phriction
epriestley moved T10785: Allow custom third-party auth providers to implement autologin from Backlog to Paused on the Prioritized board.
Jun 6 2016, 8:32 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley reopened T10431: Allow arc alias to read aliases from system configuration file as "Open".

Well, I'll leave this open for confirmation/feedback/etc.

Jun 6 2016, 8:17 PM · Prioritized, Restricted Project, Arcanist, Feature Request
epriestley closed T10431: Allow arc alias to read aliases from system configuration file as Resolved by committing Restricted Diffusion Commit.
Jun 6 2016, 8:16 PM · Prioritized, Restricted Project, Arcanist, Feature Request
epriestley claimed T10785: Allow custom third-party auth providers to implement autologin.
Jun 6 2016, 8:15 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley added a comment to T10785: Allow custom third-party auth providers to implement autologin.

Here's the new AuthProvider code for OAuth2 autologin after D16060:

Jun 6 2016, 8:14 PM · Prioritized, Auth, Restricted Project, Feature Request