Page MenuHomePhabricator

Ponder email for newly created question includes content that suggests the question was also edited
Open, Needs TriagePublic

Description

I received an email from Ponder from this install (secure.phabricator.com) earlier today which indicated the task was created and edited altogether.

The mail is: https://secure.phabricator.com/mail/detail/334560/

I'm guessing the green is it trying to show the "diff" of the edit, which is kinda cool. It put me in a piña colada mood.

Event Timeline

This will vanish for free when we move to EditEngine, or it could be special cased before that by either:

  • explicitly adding a TYPE_CREATE transaction when a question is created to simulate an EditEngine workflow (PhabricatorAuthSSHKeyEditController has an example of this); or
  • adding some oldschool if ($old === null) { logic to the relevant transactions to special-case them as hidden "create" transactions.

I got a super long email from Phriction today, is that also an EditEngine freebie?

... long scroll ...

No, that's this stuff from T7643#179240:

  • Possibly fold/hide large chunks of unchanged text, particularly leading and trailing text, and particularly in email?

I'm not sure why yours didn't line-break, though -- mine did:

The actual diff is further down and rendered correctly for me, at least -- that's just how we currently render "added one line to the middle of a 500 line document" right now:

I use a crappy email client

haha

maybe by 2050 email will work most of the time for most people

Which client do you use? I imagine the html relies on <br> or something, but would \n vs. \r\n be involved at all?

I think we're relying on white-space: pre-wrap; right now. We could explicitly do \n -> <br /> conversion which might fix newlines, at least.

Airmail on Mac, it has a few quirks with our HTML emails, but I haven't tried to debug it yet. I'm sure we're doing something weird since all other HTML seems fine in it.

I should switch to Nylas since they use Phabricator.

All the cool companies use Phabricator.