Symbol links in Differential are awesome. Where a symbol is either defined for the first time or altered in that revision, the link should be to the part of the revision that created or altered the symbol.
Currently, the former case results in a symbol-not-found page (because it hasn't been committed yet) and the latter links to code that is out-of-date in the context of the revision being reviewed.
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Restricted Maniphest Task | ||||
| Wontfix | epriestley | T1982 Link to symbols defined or altered in the Revision |
This isn't a massive problem, but fixing it would make reviewing and browsing code in the browser even more awesome, especially when I'm moving around historical diffs trying to understand something.
We haven't seen other requests for this in many years.
If we did pursue this some day it would be by providing some sort of extension hook for a plugin to analyze changes and emit a list of symbols, since this list is heavily language-dependent (I think we can not reasonably identify which symbols were affected by a change with any accuracy without having substantial knowledge of the language those symbols are written in). We could guess in some cases, but I think the list would be frequently inaccurate and confusing.
If we did provide such a mechanism, it would be after T5055 / T10329, and I'd like to see specific interest from installs in building analyzers before we develop the hooks. We could build an analyzer for libphutil libraries but it would currently take hundreds and hundreds of years for these more accurate links to pay for their own development costs.