Page MenuHomePhabricator
Create Task
Maniphest T11112

Herald allows setting multiple values in fields that should only accept one value
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • Create Herald Rule for Maniphest
  • if Title contains xyz
  • Change status to "Resolved" and "Invalid"

-> Creates a rule according to the information provided with the exception that status is only set to "Resolved" when rule is applied.

It seems like only the first item is used.

I believe in this case it should not be possible to select more than one value. Or Herald should throw an exception if you select more than one condition in the cases where it should not be allowed.

This happens (for Maniphest) when the action includes

  • change status
  • change priority to
  • assign task to

Revisions and Commits

rP Phabricator
D18943rP4b5a78e3435b Add "you can only enter one value" UI limits to Herald "set status" and "set…

Event Timeline

maxie created this task.Jun 8 2016, 12:47 PM
Herald added a subscriber: eadler. · View Herald TranscriptJun 8 2016, 12:47 PM
epriestley triaged this task as Wishlist priority.Jun 8 2016, 2:26 PM
epriestley added a subscriber: epriestley.

We should fix these, but I think these are fairly self-evident and I think fixing them isn't trivial since I recall declining to fix them the last time I was in this code.

eadler added a comment.Jun 8 2016, 2:33 PM

Not only this, but multiple Herald rules can conflict.

maxie added a comment.Jun 8 2016, 2:57 PM
In T11112#179356, @epriestley wrote:

(...) I think these are fairly self-evident (...)

I agree usually this should not cause any trouble. However, if global rules are used, normal user often don't know about these rules and the rule creator might make a mistake that could lead to errors much later because the rule is not applied as the rule creator intended.

maxie added a comment.Jun 8 2016, 2:58 PM
In T11112#179360, @eadler wrote:

Not only this, but multiple Herald rules can conflict.

What happens with multiple conflicting Herald rules? What is the order in which different Herald rules are applied? Can this order be changed?

epriestley added a revision: D18943: Add "you can only enter one value" UI limits to Herald "set status" and "set priority" actions.Jan 26 2018, 5:42 PM
epriestley moved this task from Backlog to Next on the Herald board.Jan 26 2018, 5:53 PM
epriestley closed this task as Resolved by committing rP4b5a78e3435b: Add "you can only enter one value" UI limits to Herald "set status" and "set….Jan 26 2018, 9:23 PM
epriestley added a commit: rP4b5a78e3435b: Add "you can only enter one value" UI limits to Herald "set status" and "set….
joshuaspence added a subscriber: joshuaspence.Jan 27 2018, 9:06 AM
Phabricator · Built by Phacility