Page MenuHomePhabricator
Feed Advanced Search

Feb 26 2017

epriestley created T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit.
Feb 26 2017, 8:23 PM · Audit, KDE
chad added a revision to T10319: Generate unique? profile images for each new user: Unknown Object (Differential Revision).
Feb 26 2017, 7:38 PM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

It looks like we currently allow usernames to begin with _, ., and - (PhabricatorUser->validateUsername()), but maybe just do a ? for anything-except-numbers-and-letters?

Feb 26 2017, 6:51 PM · Feature Request, People
chad updated subscribers of T10319: Generate unique? profile images for each new user.

A-Z and 0-9 is all we need here? Gotta remember user @0

Feb 26 2017, 6:49 PM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

It'd look something like this:

Feb 26 2017, 6:42 PM · Feature Request, People
pearlcode added a comment to T12321: Create Task form not Editable..

From what I understood, if I edit the built-in form, It would apply globally, so I only wanted that field hidden, if it was a new form. which is what I was trying to create.

Feb 26 2017, 6:34 PM · Bug Report
epriestley added a comment to T12321: Create Task form not Editable..

Have you tried using Lock/Hide Fields to hide the "Status" field?

Feb 26 2017, 6:33 PM · Bug Report
pearlcode added a comment to T12321: Create Task form not Editable..

I am not able to edit the form such that users belonging to a certain group are not able to change the state ie: "close" a task.
Having read into other similar situations ( T11207 ) and reading that your solution is to use custom forms I began investigating custom forms.

Feb 26 2017, 6:32 PM · Bug Report
epriestley added a comment to T12321: Create Task form not Editable..

What's an example of a specific change you're trying to make which you aren't able to figure out how to make?

Feb 26 2017, 6:21 PM · Bug Report
Mnkras updated Q573: Exclude refs/pull/* from being tracked in observed repo from to Exclude refs/pull/* from being tracked in observed repo.
Feb 26 2017, 6:07 PM
chad added a comment to T10319: Generate unique? profile images for each new user.

Honestly I'm fine with 6600 uniques out of the box. I think beyond that people can update their image. Mostly I'd like it for individual conversations (tasks with newbies), so I don't expect collision in those cases.

Feb 26 2017, 6:06 PM · Feature Request, People
chad added a comment to T10319: Generate unique? profile images for each new user.

Googling around I can find programmatically generated lists of 256 colors x 26 letters = 6600. We can also make background shapes. 4,5,6,7,8 sided. This would give us 33k uniques.

Feb 26 2017, 6:04 PM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.

We can draw letters in GD, but I suspect they won't look very good compared to letters from Photoshop (bad antialiasing, limited font choices, weird alignment/kerning issues), so I'd guess it's not worth bothering and we might as well just jump straight to using generated images like Projects.

Feb 26 2017, 5:58 PM · Feature Request, People
pearlcode updated the task description for T12321: Create Task form not Editable..
Feb 26 2017, 5:43 PM · Bug Report
pearlcode created T12321: Create Task form not Editable..
Feb 26 2017, 5:43 PM · Bug Report
chad added a comment to T10319: Generate unique? profile images for each new user.

Shapes x Colors x Letters seems most clear, but will have some collisions. I can mock something up. The letters would be generated images like in Projects? Or can this be all GD? I think that assumes fonts.

Feb 26 2017, 5:41 PM · Feature Request, People
pearlcode added a comment to T12320: Create Task form not Editable..

commit eec6cd865c854fd00c8de41b8ca8ed0da78760e8
Author: Chad Little <chad@phacility.com>
Date: Fri Feb 24 15:21:23 2017 -0800

Feb 26 2017, 5:23 PM · Bug Report
epriestley closed T12320: Create Task form not Editable. as Invalid.

You are running an out-of-date version of Phabricator, from February 17th.

Feb 26 2017, 5:16 PM · Bug Report
pearlcode updated the task description for T12320: Create Task form not Editable..
Feb 26 2017, 5:16 PM · Bug Report
pearlcode updated the task description for T12320: Create Task form not Editable..
Feb 26 2017, 5:15 PM · Bug Report
epriestley added a comment to T12320: Create Task form not Editable..

Please provide version information for your install. See Providing Version Information.

Feb 26 2017, 5:05 PM · Bug Report
pearlcode updated the task description for T12320: Create Task form not Editable..
Feb 26 2017, 5:05 PM · Bug Report
pearlcode updated the task description for T12320: Create Task form not Editable..
Feb 26 2017, 5:04 PM · Bug Report
pearlcode created T12320: Create Task form not Editable..
Feb 26 2017, 5:04 PM · Bug Report
epriestley updated subscribers of T12319: Investigate an Owners-related performance issue on revision detail pages.
Feb 26 2017, 3:29 PM · Owners, Differential, Performance
epriestley created T12319: Investigate an Owners-related performance issue on revision detail pages.
Feb 26 2017, 3:29 PM · Owners, Differential, Performance
epriestley added a comment to T12318: Loading Symbols in Phacility (Conduit).

I think this (and lint/coverage) should move to Conduit, yeah.

Feb 26 2017, 3:26 PM · Customer Impact, Symbols, Feature Request
avivey created T12318: Loading Symbols in Phacility (Conduit).
Feb 26 2017, 3:13 PM · Customer Impact, Symbols, Feature Request
gabe awarded T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads a Like token.
Feb 26 2017, 4:55 AM · Mercurial, Arcanist
Mnkras added a comment to T12296: Improve Phacility repository import performance.

Cool, now I don't feel so bad since I know you only recently added the option 😄

Feb 26 2017, 4:44 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

(That said, my expectation is that behaviors around unreachable commits have not changed -- D17279 added the "Unreachable" option to solve this problem.)

Feb 26 2017, 4:43 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

Likely somewhere in T9430 / T10978, which rewrote a big chunk of the audit code.

Feb 26 2017, 4:42 AM · Customer Impact, Diffusion, Ops
Mnkras added a comment to T12296: Improve Phacility repository import performance.

That works, Im curious when this changed, as I didn't need to filter since the last few weeks.

Feb 26 2017, 4:37 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

If you don't want to see unreachable commits, use a query which hides them:

Feb 26 2017, 4:32 AM · Customer Impact, Diffusion, Ops
Mnkras added a comment to T12296: Improve Phacility repository import performance.

The reason I think something isn't working correctly is in my dashboard, I list recent commits, and since I updated my install a few weeks ago my commit list looks like this a lot:

pasted_file (1×1 px, 470 KB)

Feb 26 2017, 4:29 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

It is expected that some deleted commits will import and others will not.

Feb 26 2017, 4:05 AM · Customer Impact, Diffusion, Ops
epriestley closed T12317: PhabricatorTriggerDaemon shows as "Waiting" but there are no errors as Resolved.

See T12298#213181.

Feb 26 2017, 4:01 AM · Bug Report
Mnkras created T12317: PhabricatorTriggerDaemon shows as "Waiting" but there are no errors.
Feb 26 2017, 3:35 AM · Bug Report
CodeMouse92 awarded T10350: Scripts to migrate old "points" fields and move projects beneath other projects a Mountain of Wealth token.
Feb 26 2017, 1:49 AM · Projects (v3)
CodeMouse92 added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

Thanks @epriestley and @rfreebern - your scripts worked perfectly! Between them both (and tweaking that one "hasSubprojects" field in the database myself), I was able to move an entire project tree. Yay!

Feb 26 2017, 1:49 AM · Projects (v3)
Mnkras added a comment to T12296: Improve Phacility repository import performance.

@epriestley all other commits that have the message "This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref." have imported, so I don't think the reachable code is working correctly, as until within the last few weeks I wasn't seeing these "This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref." commits showing up, but now I see them all the time.

Feb 26 2017, 1:30 AM · Customer Impact, Diffusion, Ops
swisspol added a comment to T10817: Allow more characters for built-in `filename` linter.

For the record, you can work around the problem as such:

{
  "linters": {
    "filename": {
      "type": "filename",
      "exclude": ["(\\+)", "(\\@)"]
    }
}
Feb 26 2017, 1:29 AM · Lint, Feature Request

Feb 25 2017

greenhatman awarded T5051: Burn down charts for Milestones a Like token.
Feb 25 2017, 11:46 PM · Restricted Project, Wikimedia, Projects
epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

Total cost is about 1.6s. Of this:

Feb 25 2017, 4:09 PM · XHProf, Ops, Phacility
epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

This is still a little bit of a pain but far more reasonable now, here's an actual profile:

Feb 25 2017, 4:03 PM · XHProf, Ops, Phacility
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I cycled the rest of the tier and things look better now.

Feb 25 2017, 4:00 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

After manually deploying that to repo001, I'm now seeing a consistent Taskmaster/PullLocal count. I'm redeploying the rest of the repo hosts.

Feb 25 2017, 3:05 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I think the issue is that the --reserve flag for reserving system memory now applies to even the first daemon in a pool, because all daemons are now part of pools. Previously, it only applied only to the 2nd..Nth daemon.

Feb 25 2017, 3:02 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

Some taskmasters failed to start on repo001 and perhaps elsewhere.

Feb 25 2017, 2:46 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I suspended and destroyed the largest instance on the shard, a free instance with one user and no logins for >30 days (the user appears to have imported a huge repository and then never logged back in). We still have backups, but this instance was way over reasonable resource use anyway. The volume is now 78% full.

Feb 25 2017, 2:45 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I pruned some very old backups (backup pruning is currently very conservative in several cases). The volume is now 72% full. This could easily be reduced much further by allowing bin/host prune to remove backups older than 90 days for suspended/terminated instances that have been out of service for 90 days, but backup utilization is generally relatively stable so I'm not concerned about this.

Feb 25 2017, 2:26 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I synchronized services for this shard and destroyed old instances. The volume is now 68% full.

Feb 25 2017, 2:13 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I synchronized services for this shard and destroyed old instances. The volume is now 44% full.

Feb 25 2017, 1:44 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

This was a bunch of repository file data in /tmp. Each file was unique, so this doesn't look like any sort of buggy loop or anything. There's some actual bug here but since there's a long list of other issues here I just "fixed" this by clearing /tmp.

Feb 25 2017, 1:08 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

Some reserved instances ended on Feb 19th; I should make sure reserved instances match production instances.

Feb 25 2017, 1:02 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

Shards 017 through 020 are now in production.

Feb 25 2017, 12:57 PM · Phacility, Ops
storrgie added a comment to T5505: Plan Legalpad v2.

We would be prepared to step in for prioritization on this.

Feb 25 2017, 12:49 PM · Restricted Project, Restricted Project
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

The re-launched hosts seem OK, I'm waiting for DNS to update and then redeploying them.

Feb 25 2017, 12:10 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

The hosts launched into an "Auto-Assign Public IPv4" subnet but didn't get IPv4 addresses. Restarting them didn't help, and there's no apparent way to assign public addresses after the fact. I'm going to throw them away and try again.

Feb 25 2017, 12:06 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I'm going to put more hosts into production immediately before pursuing other issues.

Feb 25 2017, 11:59 AM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.
  • Some reserved instances ended on Feb 19th; I should make sure reserved instances match production instances.
Feb 25 2017, 11:29 AM · Phacility, Ops
epriestley edited the content of Phacility Cluster Devices.
Feb 25 2017, 11:21 AM
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.
  • The tier as a whole is 88% full.
Feb 25 2017, 11:12 AM · Phacility, Ops
epriestley added a parent task for T12316: Phacility Deploy Log 2017 Week 8: T12217: Reduce the hardware cost of Phacility free instances.
Feb 25 2017, 11:11 AM · Phacility, Ops
epriestley added a subtask for T12217: Reduce the hardware cost of Phacility free instances: T12316: Phacility Deploy Log 2017 Week 8.
Feb 25 2017, 11:11 AM · Ops, Phacility
epriestley created T12316: Phacility Deploy Log 2017 Week 8.
Feb 25 2017, 11:10 AM · Phacility, Ops
• jignesh created D17414: Test.
Feb 25 2017, 5:45 AM
epriestley edited the content of Changelog.
Feb 25 2017, 2:18 AM
epriestley created 2017 Week 8 (Very Late February).
Feb 25 2017, 2:17 AM
• tomekj2ee awarded T4863: Allow Workboard Cards to be customized for display a Like token.
Feb 25 2017, 1:42 AM · Projects, Wikimedia, Workboards
epriestley updated subscribers of T12314: Support formal task subtypes (like "bug" vs "feature").

So here's a tentative plan for subtyping:

Feb 25 2017, 1:09 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Custom Forms are the general tool we want to use here, but they currently have some limitations for this use case. As a starting point, here's what they can do today, some of the strengths, and some of the weaknesses.

Feb 25 2017, 12:49 AM · EditEngine, Maniphest, Custom Fields, Feature Request
chad closed T12315: Arcanist setup documentation is circular as Resolved by committing Restricted Diffusion Commit.
Feb 25 2017, 12:37 AM · Bug Report
chad added a revision to T12315: Arcanist setup documentation is circular: Unknown Object (Differential Revision).
Feb 25 2017, 12:35 AM · Bug Report
kfsone added a comment to T12315: Arcanist setup documentation is circular.

@epriestley Yep - like what you're doing there :)

Feb 25 2017, 12:35 AM · Bug Report
kfsone added a comment to T12315: Arcanist setup documentation is circular.

So I don't forget:

Feb 25 2017, 12:34 AM · Bug Report
epriestley added a comment to T12315: Arcanist setup documentation is circular.

Maybe the "Install Arcanist" header on Quick Start could be like:

Feb 25 2017, 12:29 AM · Bug Report
kfsone added a comment to T12315: Arcanist setup documentation is circular.

Oh, no, it's just to do with the ordering of the links vs the annotations: if you're totally new to phabricator, you're going to get tripped on the "quick start" link which says "install stuff" and in the middle links you back two pages...

Feb 25 2017, 12:28 AM · Bug Report
chad added a comment to T12315: Arcanist setup documentation is circular.

I'm assuming he wants us to duplicate the installation information onto Win/Mac pages or only link to those pages after installing arcanist.

Feb 25 2017, 12:16 AM · Bug Report
epriestley added a comment to T12315: Arcanist setup documentation is circular.

That is, this passage:

Feb 25 2017, 12:15 AM · Bug Report
epriestley added a comment to T12315: Arcanist setup documentation is circular.

There's a short version and a long version. Each version links to the other version, saying "here's a different version of these instructions, if you'd prefer that one". How could we make this more clear?

Feb 25 2017, 12:13 AM · Bug Report
chad added a comment to T12315: Arcanist setup documentation is circular.

Thanks! I guess nobody ever noticed that before!

Feb 25 2017, 12:13 AM · Bug Report

Feb 24 2017

kfsone created T12315: Arcanist setup documentation is circular.
Feb 24 2017, 11:52 PM · Bug Report
Firehed added a comment to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).

Just a note for the above - the initial DB seed script will need to be updated accordingly as well. Right now, trying to perform a clean install on a 2nd-gen Google Cloud SQL instance (which has the above limitation) simply errors out when it reaches one of the tables coded as MyISAM.

Feb 24 2017, 11:06 PM
chad updated the task description for T12270: Unbeta Badges.
Feb 24 2017, 11:01 PM · Badges (v0)
chad added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Feb 24 2017, 11:00 PM · Badges (v0)
jmeador added a comment to T12002: Set header for CURL query for the Notification server status to HTTP:Upgrade = websocket.

@pouyana Here's a workaround for you. In your notification.servers Phabricator configuration, add path: "/ws/" to the client server. Then, modify your apache configuration like so:

Feb 24 2017, 10:53 PM · Bug Report
avivey added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

I don't see how to configure/use that

Neither can I - I may have imagined it being possible to "lock" the edit form of a task to the one that was used to create them...

Feb 24 2017, 10:31 PM · EditEngine, Maniphest, Custom Fields, Feature Request
chad renamed T12314: Support formal task subtypes (like "bug" vs "feature") from Multilevel custom fields. to Multilevel custom fields.
Feb 24 2017, 10:31 PM · EditEngine, Maniphest, Custom Fields, Feature Request
cos added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

I think it's fine to disallow changing from one type to another - can that be enforced? And sure, I think the custom form approach would work but I don't see how to configure/use that - can you point me in the right direction? I presume this implies that the underlying fields are the union of those exposed by all of the forms which would be fine.

Feb 24 2017, 10:23 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

This is a followup to a private discussion elsewhere, I'll flesh it out a bit when I have a chance.

Feb 24 2017, 10:20 PM · EditEngine, Maniphest, Custom Fields, Feature Request
avivey added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Can a task mutate between "feature" and "risk"? If not, can you use a different Custom Form for each type, which will hide the unused fields?

Feb 24 2017, 10:16 PM · EditEngine, Maniphest, Custom Fields, Feature Request
cos created T12314: Support formal task subtypes (like "bug" vs "feature").
Feb 24 2017, 9:59 PM · EditEngine, Maniphest, Custom Fields, Feature Request
chad updated the task description for T12270: Unbeta Badges.
Feb 24 2017, 9:53 PM · Badges (v0)
chad added revisions to T12270: Unbeta Badges: Unknown Object (Differential Revision), Restricted Differential Revision.
Feb 24 2017, 9:51 PM · Badges (v0)
chad changed the visibility for T2378: Document how to build `javelinsymbols` and allow its location to be specified rather than read from $PATH.
Feb 24 2017, 9:47 PM · Javelin
chad added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Feb 24 2017, 8:57 PM · Badges (v0)
20after4 added a comment to T12296: Improve Phacility repository import performance.

The commit cache should be a fairly large performance win.

Feb 24 2017, 7:22 PM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12298: Allow daemon pools to autoscale down to 0 processes.

Hibernating daemons currently show as "Waiting" in the Daemon console, but I'm not going to worry about that for now.

Feb 24 2017, 6:49 PM · Daemons, Ops, Phacility
epriestley added a comment to T12296: Improve Phacility repository import performance.

Ah, okay. This is the relevant part:

Feb 24 2017, 6:46 PM · Customer Impact, Diffusion, Ops