Page MenuHomePhabricator

Document how to build `javelinsymbols` and allow its location to be specified rather than read from $PATH
Open, NormalPublic

Description

See discussion in D4581.

Revisions and Commits

rP Phabricator
Restricted Differential Revision

Event Timeline

epriestley triaged this task as Normal priority.
epriestley added a project: Javelin.
epriestley added subscribers: epriestley, vrana.

The same stuff should apply to jsxmin.

Javelin errors are also currently cached too granularly. They depend on the celerity map, not just file content.

A coarse fix would be to reduce the cache granularity of these errors.

I had to compile this on a Macbook running OS 10.10.3 just now. Recalled some documentation existing already, and stumbled upon this task and https://secure.phabricator.com/book/javelin/article/facebook/. The steps that worked for me were

cd $JAVELIN_ROOT/externals/libfbjs
make -stdlib=libstdc++
cd $JAVELIN_ROOT/support/javelinsymbols
make -stdlib=libstdc++

Basically, make -stdlib=libstdc++ was the pertinent magic for me. Not sure if I even needed to compile libfbjs first, but hey. :D

chad changed the visibility from "All Users" to "Public (No Login Required)".Feb 24 2017, 9:47 PM