- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 30 2016
Aug 30 2016
jcox retitled D16470: Removed all instances of getIconURI from to Removed all instances of getIconURI.
I'm unable to get URL shortening to work locally. Is there some apache configuration required to get it working?
jcox committed rP9422596ebf2f: Converted Paste language selection to a typeahead (authored by jcox).
Converted Paste language selection to a typeahead
jcox closed T11532: Replace paste language selection dropdown with a typeahead as Resolved by committing rP9422596ebf2f: Converted Paste language selection to a typeahead.
Aug 29 2016
Aug 29 2016
- Don't set new paste language to ''
Oh weird. Now when I go to create a new Paste I get this:
- Added data migration and removed un-needed conditional
- Added migration to allow language to be nullable
This currently works in every case for pre-existing pastes (highlights correctly, and doesn't show a language on the edit page if no language was selected).
- Removed explicit auto-detect option
Aug 26 2016
Aug 26 2016
jcox retitled D16463: Converted Paste language selection to a typeahead from to Converted Paste language selection to a typeahead.
avivey awarded D16459: Converted the pinned applications selector to a typeahead. a Yellow Medal token.
jcox committed rP067d12d7168a: Converted the pinned applications selector to a typeahead. (authored by jcox).
Converted the pinned applications selector to a typeahead.
michaeljs1990 awarded D16459: Converted the pinned applications selector to a typeahead. a Love token.
Yeah as is it just shows the same icon twice on these entries:
epriestley awarded D16459: Converted the pinned applications selector to a typeahead. a 100 token.
- Added some nice icons and descriptions to the browse view of the typeahead form
jcox retitled D16459: Converted the pinned applications selector to a typeahead. from to Converted the pinned applications selector to a typeahead..
jcox added a comment to T11513: Convert the application selector in "pin applications" to a typeahead.
@epriestley PHP noob question: what do you do for debugging? I'm having a hard time just looking at the values of the variables involved here:
$pins = $request->getStrList('pin');
$pin = head($pins);
$app = id(new PhabricatorApplicationQuery())
->setViewer($viewer)
->withPHIDs(array($phid))
->executeOne();
if ($app) {
$pin = get_class($app);
}jcox added a comment to T11513: Convert the application selector in "pin applications" to a typeahead.
Alright I'm making a bit of progress here. Posting this update on the chance that there's something obvious I'm missing. The AphrontFormTokenizerControl behaves a little bit differently than the AphrontFormSelectControl. Specifically, this is what the form post data looks like the old way (SelectControl):
Aug 25 2016
Aug 25 2016
jcox added a comment to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.
I've tried a whole bunch of different post requests (after setting those config values and restarting apache) but I haven't been able to get that garbage yet.
Added autopatch to remove ponder vote data
jcox closed T9117: Remove unused edges after Ponder comes out of beta as Resolved by committing rP9a52492f1b2c: Added autopatch to remove ponder vote data.
jcox closed T9117: Remove unused edges after Ponder comes out of beta, a subtask of T6920: Move Voting in Ponder to "Helpfuls", as Resolved.
Task ref? You should probably find the mechanism by which these are written and read, and test that rather than looking at SQL?
jcox retitled D16452: Added autopatch to remove ponder vote data from to Added autopatch to remove ponder vote data.
Update People for handleRequest
jcox closed D16451: Update People for handleRequest by committing rPa7dcbe598030: Update People for handleRequest.
Added a setup check for empty REMOTE_ADDR
- Updated paragraph to be more translatable
jcox retitled D16450: Added a setup check for empty REMOTE_ADDR from to Added a setup check for empty REMOTE_ADDR.
jcox committed rARC9e82ef979e81: Added a warning prompt if the user tries to use an API cert instead of a CLI… (authored by jcox).
Added a warning prompt if the user tries to use an API cert instead of a CLI…
epriestley awarded D16448: Added a warning prompt if the user tries to use an API cert instead of a CLI cert a Haypence token.
jcox updated the diff for D16448: Added a warning prompt if the user tries to use an API cert instead of a CLI cert.
- Added pht calls to message text
jcox committed rPd135b3f2d56f: Added application name to the typeahead results for doc type search (authored by jcox).
Added application name to the typeahead results for doc type search
jcox updated the diff for D16446: Added application name to the typeahead results for doc type search.
Made line shorter
jcox committed rP7f7c3acfac92: Remove unused apps from the DocumentType typeahead (authored by jcox).
Remove unused apps from the DocumentType typeahead
jcox retitled D16448: Added a warning prompt if the user tries to use an API cert instead of a CLI cert from to Added a warning prompt if the user tries to use an API cert instead of a CLI cert.
jcox added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].
Alright I was finally able to reproduce it. Calling unset($_SERVER['REMOTE_ADDR']); in the preamble didn't actually end up causing it, which is a bit strange. The only way I could get this to occur was to explicitly set $_SERVER['REMOTE_ADDR'] = null; in the preamble.
- Made a line shorter
jcox committed rPa1f25fdb3e63: Added high security requirement to add/delete email addresses (authored by jcox).
Added high security requirement to add/delete email addresses
jcox closed T10999: Expand MFA checks to all email operations as Resolved by committing rPa1f25fdb3e63: Added high security requirement to add/delete email addresses.
jcox committed rP8cdf1a890a01: Updated the docs so chatbots can use the Conduit API (authored by jcox).
Updated the docs so chatbots can use the Conduit API
- Removed references to conduit.user from the docs.
Aug 24 2016
Aug 24 2016
jcox retitled D16446: Added application name to the typeahead results for doc type search from to Added application name to the typeahead results for doc type search.
jcox retitled D16445: Remove unused apps from the DocumentType typeahead from to Remove unused apps from the DocumentType typeahead.
jcox retitled D16444: Added high security requirement to add/delete email addresses from to Added high security requirement to add/delete email addresses.
jcox retitled D16443: Updated the docs so chatbots can use the Conduit API from to Updated the docs so chatbots can use the Conduit API.
Make the chatbot obey the object name blacklist
jcox closed T11508: Create a blacklist of terms that chatbots should ignore as Resolved by committing rP605210bc95af: Make the chatbot obey the object name blacklist.
jcox retitled D16442: Make the chatbot obey the object name blacklist from to Make the chatbot obey the object name blacklist.
jcox added inline comments to D16439: Removed unused buildApplicationPage method from PhabricatorController.
jcox committed rP2201c65eb73f: Removed unused buildApplicationPage method from PhabricatorController (authored by jcox).
Removed unused buildApplicationPage method from PhabricatorController
jcox committed rP3c62be695653: Add patch to remove conduit_connectionlog table (Fixes T9982) (authored by jcox).
Add patch to remove conduit_connectionlog table (Fixes T9982)
jcox closed T9982: Eventually, drop the conduit_connectionlog table as Resolved by committing rP3c62be695653: Add patch to remove conduit_connectionlog table (Fixes T9982).
jcox closed T9982: Eventually, drop the conduit_connectionlog table, a subtask of T9980: Give administrators better tools for managing Conduit API changes, as Resolved.
jcox retitled D16439: Removed unused buildApplicationPage method from PhabricatorController from to Removed unused buildApplicationPage method from PhabricatorController.
jcox retitled D16438: Add patch to remove conduit_connectionlog table (Fixes T9982) from to Add patch to remove conduit_connectionlog table (Fixes T9982).
Removing deprecated method calls