Page MenuHomePhabricator
Feed Advanced Search

Aug 30 2016

jcox added inline comments to D16470: Removed all instances of getIconURI.
Aug 30 2016, 2:03 PM
jcox retitled D16470: Removed all instances of getIconURI from to Removed all instances of getIconURI.
Aug 30 2016, 2:00 PM
jcox added a revision to T11541: Remove getIconURI() from PhabricatorApplication: D16470: Removed all instances of getIconURI.
Aug 30 2016, 2:00 PM · Contributor Onboarding, Infrastructure, Design
jcox closed T10951: Search shows document types corresponding to disabled apps as Resolved.

Macro dancingpeople:

Aug 30 2016, 1:48 PM · Contributor Onboarding, Search, Bug Report
jcox added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

I'm unable to get URL shortening to work locally. Is there some apache configuration required to get it working?

Aug 30 2016, 1:45 PM · Contributor Onboarding, Restricted Project, Phurl
jcox committed rP9422596ebf2f: Converted Paste language selection to a typeahead (authored by jcox).
Converted Paste language selection to a typeahead
Aug 30 2016, 12:42 AM
jcox closed T11532: Replace paste language selection dropdown with a typeahead as Resolved by committing rP9422596ebf2f: Converted Paste language selection to a typeahead.
Aug 30 2016, 12:41 AM · Paste, Contributor Onboarding
jcox closed D16463: Converted Paste language selection to a typeahead by committing rP9422596ebf2f: Converted Paste language selection to a typeahead.
Aug 30 2016, 12:41 AM

Aug 29 2016

jcox updated the diff for D16463: Converted Paste language selection to a typeahead.
  • Don't set new paste language to ''
Aug 29 2016, 9:25 PM
jcox added a comment to D16463: Converted Paste language selection to a typeahead.

Oh weird. Now when I go to create a new Paste I get this:

Aug 29 2016, 9:13 PM
jcox updated the diff for D16463: Converted Paste language selection to a typeahead.
  • Added data migration and removed un-needed conditional
Aug 29 2016, 9:10 PM
jcox updated the diff for D16463: Converted Paste language selection to a typeahead.
  • Added migration to allow language to be nullable
Aug 29 2016, 8:27 PM
jcox added a comment to D16463: Converted Paste language selection to a typeahead.

This currently works in every case for pre-existing pastes (highlights correctly, and doesn't show a language on the edit page if no language was selected).

Aug 29 2016, 2:19 PM
jcox updated the diff for D16463: Converted Paste language selection to a typeahead.
  • Removed explicit auto-detect option
Aug 29 2016, 2:15 PM

Aug 26 2016

jcox added inline comments to D16463: Converted Paste language selection to a typeahead.
Aug 26 2016, 9:11 PM
jcox updated D16463: Converted Paste language selection to a typeahead.
Aug 26 2016, 9:09 PM
jcox added a revision to T11532: Replace paste language selection dropdown with a typeahead: D16463: Converted Paste language selection to a typeahead.
Aug 26 2016, 9:09 PM · Paste, Contributor Onboarding
jcox retitled D16463: Converted Paste language selection to a typeahead from to Converted Paste language selection to a typeahead.
Aug 26 2016, 9:09 PM
avivey awarded D16459: Converted the pinned applications selector to a typeahead. a Yellow Medal token.
Aug 26 2016, 6:41 PM
jcox committed rP067d12d7168a: Converted the pinned applications selector to a typeahead. (authored by jcox).
Converted the pinned applications selector to a typeahead.
Aug 26 2016, 6:24 PM
jcox closed T11513: Convert the application selector in "pin applications" to a typeahead as Resolved by committing rP067d12d7168a: Converted the pinned applications selector to a typeahead..
Aug 26 2016, 6:24 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
jcox closed D16459: Converted the pinned applications selector to a typeahead. by committing rP067d12d7168a: Converted the pinned applications selector to a typeahead..
Aug 26 2016, 6:24 PM
michaeljs1990 awarded D16459: Converted the pinned applications selector to a typeahead. a Love token.
Aug 26 2016, 5:49 PM
jcox added a comment to D16459: Converted the pinned applications selector to a typeahead..

Yeah as is it just shows the same icon twice on these entries:

Aug 26 2016, 5:44 PM
epriestley awarded D16459: Converted the pinned applications selector to a typeahead. a 100 token.
Aug 26 2016, 5:42 PM
jcox added a comment to D16459: Converted the pinned applications selector to a typeahead..

ah good call. That looks way better:

pasted_file (354×596 px, 35 KB)

Aug 26 2016, 5:34 PM
jcox updated the diff for D16459: Converted the pinned applications selector to a typeahead..
  • Added some nice icons and descriptions to the browse view of the typeahead form
Aug 26 2016, 5:33 PM
jcox updated the test plan for D16459: Converted the pinned applications selector to a typeahead..
Aug 26 2016, 5:14 PM
jcox retitled D16459: Converted the pinned applications selector to a typeahead. from to Converted the pinned applications selector to a typeahead..
Aug 26 2016, 5:14 PM
jcox added a revision to T11513: Convert the application selector in "pin applications" to a typeahead: D16459: Converted the pinned applications selector to a typeahead..
Aug 26 2016, 5:14 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
jcox added a comment to T11513: Convert the application selector in "pin applications" to a typeahead.

@epriestley PHP noob question: what do you do for debugging? I'm having a hard time just looking at the values of the variables involved here:

$pins = $request->getStrList('pin');
$pin = head($pins);
$app = id(new PhabricatorApplicationQuery())
  ->setViewer($viewer)
  ->withPHIDs(array($phid))
  ->executeOne();
if ($app) {
  $pin = get_class($app);
}
Aug 26 2016, 3:45 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
jcox added a comment to T11513: Convert the application selector in "pin applications" to a typeahead.

Alright I'm making a bit of progress here. Posting this update on the chance that there's something obvious I'm missing. The AphrontFormTokenizerControl behaves a little bit differently than the AphrontFormSelectControl. Specifically, this is what the form post data looks like the old way (SelectControl):

Aug 26 2016, 3:03 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
jcox accepted D16454: Add a setup warning for "always_populate_raw_post_data".
Aug 26 2016, 1:28 PM

Aug 25 2016

jcox added a comment to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

I've tried a whole bunch of different post requests (after setting those config values and restarting apache) but I haven't been able to get that garbage yet.

Aug 25 2016, 8:40 PM · Contributor Onboarding, Setup
jcox committed rP9a52492f1b2c: Added autopatch to remove ponder vote data (authored by jcox).
Added autopatch to remove ponder vote data
Aug 25 2016, 8:01 PM
jcox closed T9117: Remove unused edges after Ponder comes out of beta as Resolved by committing rP9a52492f1b2c: Added autopatch to remove ponder vote data.
Aug 25 2016, 8:01 PM · Contributor Onboarding, Ponder
jcox closed T9117: Remove unused edges after Ponder comes out of beta, a subtask of T6920: Move Voting in Ponder to "Helpfuls", as Resolved.
Aug 25 2016, 8:01 PM · Ponder
jcox closed D16452: Added autopatch to remove ponder vote data by committing rP9a52492f1b2c: Added autopatch to remove ponder vote data.
Aug 25 2016, 8:01 PM
jcox added a comment to D16452: Added autopatch to remove ponder vote data.

Task ref? You should probably find the mechanism by which these are written and read, and test that rather than looking at SQL?

Aug 25 2016, 6:59 PM
jcox added a revision to T9117: Remove unused edges after Ponder comes out of beta: D16452: Added autopatch to remove ponder vote data.
Aug 25 2016, 6:57 PM · Contributor Onboarding, Ponder
jcox updated D16452: Added autopatch to remove ponder vote data.
Aug 25 2016, 6:57 PM
jcox retitled D16452: Added autopatch to remove ponder vote data from to Added autopatch to remove ponder vote data.
Aug 25 2016, 6:53 PM
jcox committed rPa7dcbe598030: Update People for handleRequest (authored by jcox).
Update People for handleRequest
Aug 25 2016, 5:42 PM
jcox closed D16451: Update People for handleRequest by committing rPa7dcbe598030: Update People for handleRequest.
Aug 25 2016, 5:42 PM
jcox retitled D16451: Update People for handleRequest from to Update People for handleRequest.
Aug 25 2016, 5:37 PM
jcox added a revision to T8628: Modernize AphrontControllers to implement handleRequest: D16451: Update People for handleRequest.
Aug 25 2016, 5:37 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
jcox committed rPa88dc2afc2a9: Added a setup check for empty REMOTE_ADDR (authored by jcox).
Added a setup check for empty REMOTE_ADDR
Aug 25 2016, 5:06 PM
jcox closed D16450: Added a setup check for empty REMOTE_ADDR by committing rPa88dc2afc2a9: Added a setup check for empty REMOTE_ADDR.
Aug 25 2016, 5:06 PM
jcox closed T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] as Resolved by committing rPa88dc2afc2a9: Added a setup check for empty REMOTE_ADDR.
Aug 25 2016, 5:06 PM · Contributor Onboarding, Setup
jcox updated the diff for D16450: Added a setup check for empty REMOTE_ADDR.
  • Updated paragraph to be more translatable
Aug 25 2016, 4:57 PM
jcox retitled D16450: Added a setup check for empty REMOTE_ADDR from to Added a setup check for empty REMOTE_ADDR.
Aug 25 2016, 4:32 PM
jcox added a revision to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR']: D16450: Added a setup check for empty REMOTE_ADDR.
Aug 25 2016, 4:32 PM · Contributor Onboarding, Setup
jcox committed rARC9e82ef979e81: Added a warning prompt if the user tries to use an API cert instead of a CLI… (authored by jcox).
Added a warning prompt if the user tries to use an API cert instead of a CLI…
Aug 25 2016, 3:34 PM
jcox closed T9692: Warn but continue when installing bot certificates with `arc install-certificate` as Resolved by committing rARC9e82ef979e81: Added a warning prompt if the user tries to use an API cert instead of a CLI….
Aug 25 2016, 3:34 PM · Contributor Onboarding, User Preferences, Arcanist
jcox closed D16448: Added a warning prompt if the user tries to use an API cert instead of a CLI cert by committing rARC9e82ef979e81: Added a warning prompt if the user tries to use an API cert instead of a CLI….
Aug 25 2016, 3:34 PM
epriestley awarded D16448: Added a warning prompt if the user tries to use an API cert instead of a CLI cert a Haypence token.
Aug 25 2016, 3:31 PM
jcox updated the diff for D16448: Added a warning prompt if the user tries to use an API cert instead of a CLI cert.
  • Added pht calls to message text
Aug 25 2016, 3:30 PM
jcox committed rPd135b3f2d56f: Added application name to the typeahead results for doc type search (authored by jcox).
Added application name to the typeahead results for doc type search
Aug 25 2016, 3:27 PM
jcox closed D16446: Added application name to the typeahead results for doc type search by committing rPd135b3f2d56f: Added application name to the typeahead results for doc type search.
Aug 25 2016, 3:26 PM
tycho.tatitscheff awarded T9692: Warn but continue when installing bot certificates with `arc install-certificate` a Love token.
Aug 25 2016, 3:17 PM · Contributor Onboarding, User Preferences, Arcanist
jcox updated the diff for D16446: Added application name to the typeahead results for doc type search.

Made line shorter

Aug 25 2016, 3:16 PM
jcox committed rP7f7c3acfac92: Remove unused apps from the DocumentType typeahead (authored by jcox).
Remove unused apps from the DocumentType typeahead
Aug 25 2016, 3:05 PM
jcox closed D16445: Remove unused apps from the DocumentType typeahead by committing rP7f7c3acfac92: Remove unused apps from the DocumentType typeahead.
Aug 25 2016, 3:05 PM
jcox retitled D16448: Added a warning prompt if the user tries to use an API cert instead of a CLI cert from to Added a warning prompt if the user tries to use an API cert instead of a CLI cert.
Aug 25 2016, 3:02 PM
jcox added a revision to T9692: Warn but continue when installing bot certificates with `arc install-certificate`: D16448: Added a warning prompt if the user tries to use an API cert instead of a CLI cert.
Aug 25 2016, 3:02 PM · Contributor Onboarding, User Preferences, Arcanist
jcox added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

Alright I was finally able to reproduce it. Calling unset($_SERVER['REMOTE_ADDR']); in the preamble didn't actually end up causing it, which is a bit strange. The only way I could get this to occur was to explicitly set $_SERVER['REMOTE_ADDR'] = null; in the preamble.

Aug 25 2016, 1:47 PM · Contributor Onboarding, Setup
jcox added inline comments to D16445: Remove unused apps from the DocumentType typeahead.
Aug 25 2016, 1:05 PM
jcox updated the diff for D16445: Remove unused apps from the DocumentType typeahead.
  • Made a line shorter
Aug 25 2016, 1:04 PM
jcox committed rPa1f25fdb3e63: Added high security requirement to add/delete email addresses (authored by jcox).
Added high security requirement to add/delete email addresses
Aug 25 2016, 1:01 PM
jcox closed T10999: Expand MFA checks to all email operations as Resolved by committing rPa1f25fdb3e63: Added high security requirement to add/delete email addresses.
Aug 25 2016, 1:01 PM · Contributor Onboarding, Security
jcox closed D16444: Added high security requirement to add/delete email addresses by committing rPa1f25fdb3e63: Added high security requirement to add/delete email addresses.
Aug 25 2016, 1:01 PM
jcox committed rP8cdf1a890a01: Updated the docs so chatbots can use the Conduit API (authored by jcox).
Updated the docs so chatbots can use the Conduit API
Aug 25 2016, 12:59 PM
jcox closed D16443: Updated the docs so chatbots can use the Conduit API by committing rP8cdf1a890a01: Updated the docs so chatbots can use the Conduit API.
Aug 25 2016, 12:59 PM
jcox updated the diff for D16443: Updated the docs so chatbots can use the Conduit API.
  • Removed references to conduit.user from the docs.
Aug 25 2016, 12:55 PM

Aug 24 2016

jcox retitled D16446: Added application name to the typeahead results for doc type search from to Added application name to the typeahead results for doc type search.
Aug 24 2016, 10:11 PM
jcox added a revision to T10951: Search shows document types corresponding to disabled apps: D16446: Added application name to the typeahead results for doc type search.
Aug 24 2016, 10:11 PM · Contributor Onboarding, Search, Bug Report
jcox added inline comments to D16445: Remove unused apps from the DocumentType typeahead.
Aug 24 2016, 9:45 PM
jcox retitled D16445: Remove unused apps from the DocumentType typeahead from to Remove unused apps from the DocumentType typeahead.
Aug 24 2016, 9:44 PM
jcox added a revision to T10951: Search shows document types corresponding to disabled apps: D16445: Remove unused apps from the DocumentType typeahead.
Aug 24 2016, 9:44 PM · Contributor Onboarding, Search, Bug Report
jcox retitled D16444: Added high security requirement to add/delete email addresses from to Added high security requirement to add/delete email addresses.
Aug 24 2016, 9:09 PM
jcox added a revision to T10999: Expand MFA checks to all email operations: D16444: Added high security requirement to add/delete email addresses.
Aug 24 2016, 9:09 PM · Contributor Onboarding, Security
jcox retitled D16443: Updated the docs so chatbots can use the Conduit API from to Updated the docs so chatbots can use the Conduit API.
Aug 24 2016, 8:25 PM
jcox committed rP605210bc95af: Make the chatbot obey the object name blacklist (authored by jcox).
Make the chatbot obey the object name blacklist
Aug 24 2016, 8:08 PM
jcox closed T11508: Create a blacklist of terms that chatbots should ignore as Resolved by committing rP605210bc95af: Make the chatbot obey the object name blacklist.
Aug 24 2016, 8:08 PM · Contributor Onboarding, Feature Request
jcox closed D16442: Make the chatbot obey the object name blacklist by committing rP605210bc95af: Make the chatbot obey the object name blacklist.
Aug 24 2016, 8:08 PM
jcox updated D16442: Make the chatbot obey the object name blacklist.
Aug 24 2016, 7:50 PM
jcox added a revision to T11508: Create a blacklist of terms that chatbots should ignore: D16442: Make the chatbot obey the object name blacklist.
Aug 24 2016, 7:50 PM · Contributor Onboarding, Feature Request
jcox retitled D16442: Make the chatbot obey the object name blacklist from to Make the chatbot obey the object name blacklist.
Aug 24 2016, 7:47 PM
jcox added inline comments to D16439: Removed unused buildApplicationPage method from PhabricatorController.
Aug 24 2016, 3:27 PM
jcox committed rP2201c65eb73f: Removed unused buildApplicationPage method from PhabricatorController (authored by jcox).
Removed unused buildApplicationPage method from PhabricatorController
Aug 24 2016, 3:25 PM
jcox closed D16439: Removed unused buildApplicationPage method from PhabricatorController by committing rP2201c65eb73f: Removed unused buildApplicationPage method from PhabricatorController.
Aug 24 2016, 3:25 PM
jcox committed rP3c62be695653: Add patch to remove conduit_connectionlog table (Fixes T9982) (authored by jcox).
Add patch to remove conduit_connectionlog table (Fixes T9982)
Aug 24 2016, 3:04 PM
jcox closed T9982: Eventually, drop the conduit_connectionlog table as Resolved by committing rP3c62be695653: Add patch to remove conduit_connectionlog table (Fixes T9982).
Aug 24 2016, 3:04 PM · Contributor Onboarding, Restricted Project, Conduit
jcox closed T9982: Eventually, drop the conduit_connectionlog table, a subtask of T9980: Give administrators better tools for managing Conduit API changes, as Resolved.
Aug 24 2016, 3:04 PM · Conduit
jcox closed D16438: Add patch to remove conduit_connectionlog table (Fixes T9982) by committing rP3c62be695653: Add patch to remove conduit_connectionlog table (Fixes T9982).
Aug 24 2016, 3:04 PM
jcox retitled D16439: Removed unused buildApplicationPage method from PhabricatorController from to Removed unused buildApplicationPage method from PhabricatorController.
Aug 24 2016, 3:01 PM
jcox added a revision to T9690: Remove calls to methods deprecated by newPage(): D16439: Removed unused buildApplicationPage method from PhabricatorController.
Aug 24 2016, 3:01 PM · Contributor Onboarding, Modernization, Infrastructure
jcox retitled D16438: Add patch to remove conduit_connectionlog table (Fixes T9982) from to Add patch to remove conduit_connectionlog table (Fixes T9982).
Aug 24 2016, 2:54 PM
jcox committed rPd26cca27d70b: Removing deprecated method calls (authored by jcox).
Removing deprecated method calls
Aug 24 2016, 2:33 PM
jcox closed D16432: Removing deprecated method calls by committing rPd26cca27d70b: Removing deprecated method calls.
Aug 24 2016, 2:33 PM