Maniphest T11541

Remove getIconURI() from PhabricatorApplication
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Aug 26 2016, 5:45 PM

Tags

Referenced Files

None

Subscribers

tycho.tatitscheff

Description

Long ago, applications used images (as in, actual image files on disk) as icons. We switched to FontAwesome but never completely got rid of this.

Remove getIconURI() from PhabricatorApplication.
Remove any callers of this method.

It actually looks like this is pretty straightforward, only 4 callsites. I thought we might have more kicking around.

Revisions and Commits

rP Phabricator
	D16470	rPf2f896c761a2 Removed all instances of getIconURI

Event Timeline

epriestley created this task.Aug 26 2016, 5:45 PM

Herald added subscribers: tycho.tatitscheff, eadler. · View Herald TranscriptAug 26 2016, 5:45 PM

epriestley moved this task from Backlog to Basic on the Contributor Onboarding board.Aug 26 2016, 5:45 PM

jcox added a revision: D16470: Removed all instances of getIconURI.Aug 30 2016, 2:00 PM

jcox closed this task as Resolved by committing rPf2f896c761a2: Removed all instances of getIconURI.Aug 30 2016, 2:11 PM

jcox added a commit: rPf2f896c761a2: Removed all instances of getIconURI.