Page MenuHomePhabricator

Added autopatch to remove ponder vote data
ClosedPublic

Authored by jcox on Aug 25 2016, 6:53 PM.
Tags
None
Referenced Files
F12846669: D16452.id39575.diff
Fri, Mar 29, 1:25 AM
Unknown Object (File)
Feb 2 2024, 10:20 PM
Unknown Object (File)
Jan 15 2024, 10:14 AM
Unknown Object (File)
Dec 21 2023, 6:52 AM
Unknown Object (File)
Dec 20 2023, 11:49 AM
Unknown Object (File)
Dec 14 2023, 1:06 PM
Unknown Object (File)
Dec 9 2023, 4:14 AM
Unknown Object (File)
Nov 30 2023, 2:30 AM

Details

Summary

Fixes T9117. Adds a migration to remove ponder vote data.

Test Plan

I added a bunch of lines to phabricator_user.edge with type 18 and they were successfully removed by this patch

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jcox retitled this revision from to Added autopatch to remove ponder vote data.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)

Task ref? You should probably find the mechanism by which these are written and read, and test that rather than looking at SQL?

Task ref? You should probably find the mechanism by which these are written and read, and test that rather than looking at SQL?

@yelirekim if I understand correctly that mechanism doesn't exist anymore since D13833

epriestley added a reviewer: epriestley.

Yeah, this is just cleaning up free-floating garbage that we were hesitant to destroy when we unlinked it from everything.

(I actually don't have any of these locally myself, either.)

One minor double-check that I didn't mention is looking at ConfigEdge Types and verifying that these constants don't appear there (they don't), just as a sanity check that the numbers aren't wildly wrong.

This revision is now accepted and ready to land.Aug 25 2016, 7:03 PM
This revision was automatically updated to reflect the committed changes.