so you've got a minimum of a week to hyperventilate about deploying this.

Right on! Didn't cause any real problems. Just confused me for a minute while I was updating.

Promote 2017 Week 14

This change appears to have made maniphest.edit (on the head of master) start failing on the following:

echo '{
  "transactions": [
    {
      "type": "priority",
      "value": "50"
    }
  ],
  "objectIdentifier": 12
}' | arc call-conduit maniphest.edit

Haha to be clear we're using an open-source self-hosted tracking solution, I was just throwing GA out there as an example. But I do understand your point vis-a-vis data security.

Why do you want to track users with Google Analytics or a similar library?

haha nice. I just posted this comment on our downstream task tracking this.

I couldn't find a project with multiple subprojects on this install otherwise I would have linked you to an example

👍 testing it now.

We've run into this a couple of times. When a user updates a revision through the web UI, the repository field (at /differential/revision/update/{REVID}/) doesn't auto-populate with the revision's repository and people sometimes forget to fill it out. This causes the repository to be stripped from the revision as well.

This will make it diphphicult to log in iph your username contains an 'f'. Should I add a database migration to automatically phix peoples' usernames?

Update celerity map

learn to count parens

In exchange, here is a cat on a mat trying to do some yoga. Not my cat, but she was at an airbnb I stayed at and my decision to not steal her came down to a coin toss

that's a great pup. 10/10

Yeah I think it probably makes sense to not distinguish between a permission error and invalid resource for the reasons you said. I know amazon S3 does a similar thing and just returns a 403 in both cases.

Update message to account for permission error

send puppy pics please

I just ran into this again but for a completely different reason. The user assured me multiple times that they were entering a valid diff ID and I repeatedly explained, "no, you don't understand. I Know What I'm Doing™".

verified

Just to clarify, I tested it locally, not on this install.

Just spent some time tracking down what ended up being this issue. I wonder if adding a check in this block to query for the given revision would be sufficient enough to detect this case and return a more sensible error message. I can submit a diff for that if that'd be acceptable

@yelirekim I think we're good here. Just needed to implement getHarbormasterPublishablePHID() for SubmitQueueIntegrationPlans, ReleaseCandidates, and ScheduledBuilds. See our downstream diff for those changes.

ah yep that seemed to work. I was still specifying releaseNotes for the field which I'm guessing is why it wasn't getting saved. Thanks again for all the help! If you're ever in Pittsburgh I think I owe you about 50 beers at this point.

I pulled in that change and I'm still seeing the same issue. Editing the field from /differential/revision/edit/... seems to work normally, but adding it via the differential.createrevision endpoint does not.

Checking in for guidance in case this is the wrong way to go. I have a custom field which extends DifferentialStoredCustomField and I'm trying to convert it in the same way as the above. Thus far my field isn't being saved when calling differential.createrevision. I've included the DifferentialCommitMessageCustomField and the DifferentialStoredCustomField below.

Thanks that did it! Still working through an issue with one of our more *ahem* exotic applications, but I suspect that'll be a more involved refactor on our end.

Doing that without defining getFieldTransactions() in my class yields this exception:

Transaction with key "1" has invalid type "devTestPHIDs". This type is not recognized. Valid types are: update, comment, title, summary, testPlan, reviewers.add, reviewers.remove, reviewers.set, repositoryPHID, tasks.add, tasks.remove, tasks.set, view, edit, projects.add, projects.remove, projects.set, subscribers.add, subscribers.remove, subscribers.set, phabricator:auditors.

Thanks for the help Evan. I've gone through and converted everything as you suggested. The conduit method then started telling me