Page MenuHomePhabricator

Added a warning prompt if the user tries to use an API cert instead of a CLI cert
ClosedPublic

Authored by jcox on Aug 25 2016, 3:02 PM.

Details

Summary

Fixes T9692. Instead of disallowing API tokens entirely, we're going to just warn the user that they might not want to do that. After that, they can proceed if they want to.

Test Plan

Run arc install-certificate.
Manually go to Settings → Conduit API Tokens in the web UI.
Generate an API token explicitly, which should have the form api-**.
Paste that into the prompt on the CLI.
It will give you a warning prompt then ask if you'd like to proceed anyway (defaults to No).

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jcox retitled this revision from to Added a warning prompt if the user tries to use an API cert instead of a CLI cert.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

One inline about translations. This is moot today since there's no way to set arc to a different language, but will likely become relevant soon (T5267).

src/workflow/ArcanistInstallCertificateWorkflow.php
127

Use pht() here, to make these messages ("Install this..."), ("Not installing...") translatable.

See here for more details about error/exception translations, or the rest of this document for discussion of pht():

https://secure.phabricator.com/book/phabcontrib/article/internationalization/#exceptions-and-errors

This revision is now accepted and ready to land.Aug 25 2016, 3:07 PM
jcox edited edge metadata.
  • Added pht calls to message text
This revision was automatically updated to reflect the committed changes.