Page MenuHomePhabricator

Remove unused apps from the DocumentType typeahead
ClosedPublic

Authored by jcox on Aug 24 2016, 9:44 PM.
Tags
None
Referenced Files
F15465528: D16445.id39558.diff
Wed, Apr 2, 8:07 PM
F15460912: D16445.id.diff
Tue, Apr 1, 3:18 AM
F15452013: D16445.id39560.diff
Sat, Mar 29, 1:08 AM
F15443855: D16445.diff
Thu, Mar 27, 6:32 AM
F15443256: D16445.id39550.diff
Thu, Mar 27, 3:20 AM
F15439221: D16445.id.diff
Wed, Mar 26, 6:23 AM
F15436508: D16445.diff
Tue, Mar 25, 2:42 PM
F15387919: D16445.id.diff
Sat, Mar 15, 3:06 AM
Subscribers

Details

Summary

Ref T10951. This diff removes uninstalled applications from the result set for DocumentType restults

Test Plan

Uninstall an application (diviner for example), then go to the document type search menu and ensure that the uninstalled application doesn't show up.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jcox retitled this revision from to Remove unused apps from the DocumentType typeahead.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php
30–31

Is there a syntactically correct way to make this shorter without renaming things?

src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php
30–31

Haha, does this fit?

$types =
  Blahblahblah::blahblah(
    $blahblahblah);
jcox edited edge metadata.
  • Made a line shorter
src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php
31

lol yep. just barely!

This revision is now accepted and ready to land.Aug 25 2016, 2:20 PM
This revision was automatically updated to reflect the committed changes.