Page MenuHomePhabricator

Removed unused buildApplicationPage method from PhabricatorController
ClosedPublic

Authored by jcox on Aug 24 2016, 3:01 PM.

Details

Summary

Getting rid of some code! This method has no callsites so it should be safe to remove completely. Ref T9690

Test Plan

Removed method and clicked around to make sure nothing broke.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jcox updated this revision to Diff 39534.Aug 24 2016, 3:01 PM
jcox retitled this revision from to Removed unused buildApplicationPage method from PhabricatorController.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Aug 24 2016, 3:22 PM
epriestley added a reviewer: epriestley.

Nice.

This revision is now accepted and ready to land.Aug 24 2016, 3:22 PM
yelirekim added inline comments.
src/applications/base/controller/PhabricatorController.php
587

RIP

This is an ATC meme-ish at this point because I wrote so many controllers without page titles when I first starting extending Phab.

This revision was automatically updated to reflect the committed changes.
jcox added inline comments.Aug 24 2016, 3:27 PM
src/applications/base/controller/PhabricatorController.php
585

I'm glad this lets me know we're dealing with serious-business here.