Converted the pinned applications selector to a typeahead.
ClosedPublic
Actions

Authored by jcox on Aug 26 2016, 5:14 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T11513: Convert the application selector in "pin applications" to a typeahead

Commits

rPbe84c051e5ba: (stable) Promote 2016 Week 35
rP067d12d7168a: Converted the pinned applications selector to a typeahead.

Summary

Fixes T11513. Previously the selector was just a giant dropdown which was just... just too much. Now there's a handy typeahead.

Test Plan

Happy Path:
Go to Settings -> Home Page -> Pin Application, start typing in the form then select one of the options. Click on "Pin Application". The application should now be in the list.

Other paths:

Type nothing into the box and submit, nothing should happen.
Choose an application that is already pinned. The list should stay the same.
Type nonsense into the box and submit, nothing should happen.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jcox updated this revision to Diff 39589.Aug 26 2016, 5:14 PM

jcox retitled this revision from to Converted the pinned applications selector to a typeahead..

jcox updated this object.

jcox edited the test plan for this revision. (Show Details)

jcox added a task: T11513: Convert the application selector in "pin applications" to a typeahead.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 26 2016, 5:14 PM

Herald added subscribers: yelirekim, epriestley. · View Herald Transcript

jcox edited the test plan for this revision. (Show Details)Aug 26 2016, 5:14 PM

jcox edited edge metadata.

Nice, this feels a lot nicer to me.

It would also be nice to add subtitles + icons to the browse view of this datasource, similar to the improvement to application document types in D16446:

Screen Shot 2016-08-26 at 10.19.45 AM.png (451×631 px, 36 KB)

I think you can $application->getIcon() to get an icon, and $application->getShortDescription() to get a reasonable subtitle/attribute.

This revision is now accepted and ready to land.Aug 26 2016, 5:22 PM

Added some nice icons and descriptions to the browse view of the typeahead form

Herald added a subscriber: Korvin. · View Herald TranscriptAug 26 2016, 5:33 PM

ah good call. That looks way better:

chad added a subscriber: chad.Aug 26 2016, 5:39 PM

chad added inline comments.

src/applications/meta/typeahead/PhabricatorApplicationDatasource.php
41–43	do we need `setImageSprite` ?

We might still need that for this menu:

Screen Shot 2016-08-26 at 10.39.43 AM.png (672×417 px, 76 KB)

Yeah, we lose the big icons in the main search menu without setImageSprite().

We don't appear to need setImageURI(), though.

Just go ahead and land this, we can figure out the setIconURI() thing separately. That method can probably be removed from all Application classes too, so it's a bigger change.