Page MenuHomePhabricator

Removed all instances of getIconURI
ClosedPublic

Authored by jcox on Aug 30 2016, 2:00 PM.
Tags
None
Referenced Files
F17958633: D16470.diff
Fri, Aug 1, 7:11 AM
F17683099: D16470.diff
Sun, Jul 13, 11:03 PM
Unknown Object (File)
Jul 3 2025, 12:29 AM
Unknown Object (File)
Jun 30 2025, 6:42 AM
Unknown Object (File)
Jun 26 2025, 11:02 PM
Unknown Object (File)
May 28 2025, 12:20 PM
Unknown Object (File)
May 27 2025, 11:27 AM
Unknown Object (File)
May 27 2025, 6:40 AM

Details

Summary

Fixes T11541. PhabricatorApplication::getIconURI() has been returning only null for a while (I assume in preparation to remove it). I removed the method and all the remaining call sites.

Test Plan

Removed the method and then clicked around. Things didn't explode!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jcox retitled this revision from to Removed all instances of getIconURI.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

Nothing exploded? Hard to believe.

This revision is now accepted and ready to land.Aug 30 2016, 2:01 PM
src/applications/meta/typeahead/PhabricatorApplicationDatasource.php
39

wait a minute... are PHP function calls case-insensitive?

(Small comfort but variables aren't, at least.)

This revision was automatically updated to reflect the committed changes.