Page MenuHomePhabricator

Make the chatbot obey the object name blacklist
ClosedPublic

Authored by jcox on Aug 24 2016, 7:47 PM.
Tags
None
Referenced Files
F17948672: D16442.diff
Thu, Jul 31, 9:41 PM
F17839853: D16442.id39546.diff
Sat, Jul 26, 8:31 PM
F17826607: D16442.diff
Sat, Jul 26, 7:27 AM
F17657543: D16442.diff
Sat, Jul 12, 12:22 PM
Unknown Object (File)
Jun 3 2025, 5:53 AM
Unknown Object (File)
May 31 2025, 3:56 PM
Unknown Object (File)
May 27 2025, 11:26 AM
Unknown Object (File)
May 6 2025, 11:58 AM
Subscribers

Details

Summary

Fixes T11508. The config entry remarkup.ignored-object-names already contains a blacklist of object names that should be ignored in the web UI. This change makes that blacklist also apply to the chatbot. This makes it possible to have a chatbot ignore things like V1, V2, Q1 and any other phrases the user may not want to generate links to objects.

Test Plan

Create objects (tasks, slowvotes, etc.) then mention the object names in chat (with the bot running). The bot should respond with helpful links to the given objects. Then add the object names to the blacklist through the config web UI. This apparently triggers the bot to restart itself. Then mention the object names in chat again. The bot should no longer respond with links because those object names have been added to the blacklist regex.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jcox retitled this revision from to Make the chatbot obey the object name blacklist.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Aug 24 2016, 7:49 PM
This revision was automatically updated to reflect the committed changes.