Page MenuHomePhabricator
Feed Advanced Search

Oct 5 2015

cburroughs added a comment to T9352: Write some custom Herald glue for driving builds through Owners.

Yeah, at least as written. You could tweak the logic or I can swap it for something else if that's easier.

Oct 5 2015, 7:47 PM · Harbormaster, Herald, Owners, Prioritized

Oct 2 2015

cburroughs added a comment to T9352: Write some custom Herald glue for driving builds through Owners.
  • The way to do multiple builds per package is to use a remarkup custom field and separate them with newlines, correct?
  • The herald rule should be "Always" instead of something to do with packages because CustomDifferentialRunPackageBuildsHeraldAction has sufficient logic of it's own?
Oct 2 2015, 7:15 PM · Harbormaster, Herald, Owners, Prioritized
cburroughs awarded D14221: Finished readme so that puny humans could understand. a Yellow Medal token.
Oct 2 2015, 12:22 PM

Sep 29 2015

alexnb awarded T9430: "Needs Audit" no longer excludes author commits a Like token.
Sep 29 2015, 2:04 PM · Restricted Project, Restricted Project, Audit

Sep 17 2015

cburroughs added a comment to T9437: Task priorities change when moved between columns in a workboard.

Is the workboard set to sort by priority when you are doing this?

Sep 17 2015, 8:48 PM · Workboards, Restricted Project

Sep 16 2015

cburroughs renamed T9430: "Needs Audit" no longer excludes author commits from This "Needs Audit" no longer excludes author commits to "Needs Audit" no longer excludes author commits.
Sep 16 2015, 1:55 PM · Restricted Project, Restricted Project, Audit
cburroughs created T9430: "Needs Audit" no longer excludes author commits.
Sep 16 2015, 1:27 PM · Restricted Project, Restricted Project, Audit
cburroughs added a comment to D14013: Modernize Audit search engine.

I am currently waiting for divine inspiration to strike and illuminate a path through T9372.

Sep 16 2015, 1:24 PM
cburroughs added a comment to D14013: Modernize Audit search engine.

Did this meet the pain threshold to fix Real Soon or would you prefer a followup task?

Sep 16 2015, 12:50 PM
cburroughs created T9427: Error Processing Mail (Multiple Receivers) when replying to audit mail.
Sep 16 2015, 12:49 PM · Mail, Audit
cburroughs added a comment to rGITTEST97826afb7189: some testing.

Meta email testing.

Sep 16 2015, 12:46 PM

Sep 15 2015

cburroughs added inline comments to D14114: Reduce garbage-level of Drydock Allocator implementation.
Sep 15 2015, 7:10 PM

Sep 14 2015

cburroughs awarded T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay` a Heartbreak token.
Sep 14 2015, 12:03 PM · Remarkup, Security, Installing & Upgrading
cburroughs awarded Q128: Is there a "resistance is phutil" pun anywhere? a Pterodactyl token.
Sep 14 2015, 12:02 PM

Sep 11 2015

cburroughs added a comment to D14013: Modernize Audit search engine.

Virtually all of our audits are triggered by Herald and not Owners, roughly following the small teams guide.

Sep 11 2015, 1:18 PM
cburroughs updated subscribers of T9395: harbormaster.sendmessage does not update build status for the same build target..
Sep 11 2015, 12:59 PM · Harbormaster, Conduit

Sep 10 2015

cburroughs added a comment to T9161: How can we fix "too much mail"?.

~50% of the preference entries include disabling self actions. There is probably a bit of hand waving to get to that that to a percentage 'all users', or 'all active users'.

Sep 10 2015, 4:57 PM · Restricted Project, User Preferences, Mail
cburroughs added a comment to D14013: Modernize Audit search engine.

This changes behavior a little bit: we previously attempted to exclude, e.g., commits which a package you own needs to audit, but which you have resigned from. This is difficult in general and I think it needs a more comprehensive solution. This shouldn't impact users much, anyway.

Sep 10 2015, 3:43 PM
cburroughs added a comment to T9161: How can we fix "too much mail"?.

14 days seemed like enough time to get some reasonable results. They are.... complicated.

  • To my surprise I'm not in the top 10 for delivered email.
  • Very roughly, people who get more email seem better at handling it.
  • Among the 'too much email it is terrible!' crowd some people turned off virtually all email in phabricator while others have a client side filter. The most vocal complainers have usually succeeded in using the available tools to no get email, but at the cost of creating larger coworkers-ignoring-each-other ones.
  • Most people are doing some filtering although perhaps ironically some of the best responders send almost everything to their client.
  • For anyone looking at the raw numbers, we have a lot of audit related mail.
Sep 10 2015, 2:31 PM · Restricted Project, User Preferences, Mail

Sep 9 2015

cburroughs added a comment to T9363: improve handling of panels that do not always return results.

The "Unbreak Now!" case is the only one I consider important. Similar behavior might be nice for "Needs Triage" + viewerprojects(). I can't think of any case that does not involve tasks since I expect the common case for audits, reviews, feeds, etc to be that there are results.

Sep 9 2015, 12:08 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project

Sep 8 2015

cburroughs changed the visibility for T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them.
Sep 8 2015, 10:08 PM · Restricted Project, Arcanist
cburroughs added a comment to T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.

Sorry I had several instances of phabricator up comparing results and must have messed up which one was which. As you pointed out viewerprojects() specifically (which really is the one I was interested in) is not available on this install.

Sep 8 2015, 7:50 PM · Restricted Project, Typeahead, Audit
cburroughs created T9363: improve handling of panels that do not always return results.
Sep 8 2015, 7:26 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project
cburroughs created T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Sep 8 2015, 7:06 PM · Restricted Project, Typeahead, Audit

Sep 7 2015

cburroughs added inline comments to D14076: Allow upgrading in branch `stable`.
Sep 7 2015, 7:28 PM

Sep 5 2015

cburroughs added a comment to D13957: Hide answer box if you asked the question in Ponder.

A number of ex-Sun engineers I have meant talk fervently about maintaining First Customer Ship Quality at all times. Sadly there are few public tellings of that tail beyond the pale shadow of a wiki page but the impression I have gotten is (1) The crisis that lead into their version of "do not break the build" was a career defining event for many of the engineers (2) The story was told and retold so it was seared into the souls of the next generation of engineers. Probably that means they don't break the build anymore, but it is even more important if they come away with a visceral feeling for the product, not any one project, is what matters ormistakes will happen; negligence cannot.

Sep 5 2015, 11:27 PM

Sep 3 2015

cburroughs awarded rGITTEST3a4ce688fc20: more testing a Mountain of Wealth token.
Sep 3 2015, 11:36 PM

Sep 2 2015

cburroughs updated the diff for D14033: staging repo compatibility for older git versions.
  • clever++, or is that ++clever?
Sep 2 2015, 12:32 PM
cburroughs added a comment to T9271: ponder (sometimes?) does not send email when an answer is added.

I have not seen this a second time.

Sep 2 2015, 12:21 PM · Ponder

Sep 1 2015

cburroughs added a comment to D14033: staging repo compatibility for older git versions.

I tried a bunch of clever/terser ways but they all ran into 'Unsafe Usage of Dynamic String' or phutil_passthru quoting even the empty string.

Sep 1 2015, 7:36 PM
cburroughs retitled D14033: staging repo compatibility for older git versions from to staging repo compatibility for older git versions.
Sep 1 2015, 7:35 PM
cburroughs added a revision to T9310: --no-verify option used for staging repositories not available in older gits: D14033: staging repo compatibility for older git versions.
Sep 1 2015, 7:35 PM · Arcanist
cburroughs created T9310: --no-verify option used for staging repositories not available in older gits.
Sep 1 2015, 6:32 PM · Arcanist

Aug 31 2015

cburroughs added a comment to T8919: owners autocomplete send to /null url.

When you say it "does not appear to do anything", do you mean that the click is completely swallowed? Or the menu closes but nothing else happens? Or the menu closes and the input is updated (this is the expected behavior), but you aren't taken anywhere and expected to be taken somewhere?

Aug 31 2015, 3:48 PM · Owners

Aug 27 2015

cburroughs created T9276: Display when builds happen with status somewhere handy, like the differential timeline.
Aug 27 2015, 6:52 PM · Restricted Project, Harbormaster (v3), Differential

Aug 26 2015

cburroughs added a comment to T9271: ponder (sometimes?) does not send email when an answer is added.

Hmm, also nothing locally or in /mail with ANSR in the subject.

Aug 26 2015, 7:20 PM · Ponder
cburroughs created T9271: ponder (sometimes?) does not send email when an answer is added.
Aug 26 2015, 5:41 PM · Ponder

Aug 25 2015

cburroughs added a comment to T182: Commit into repository directly from differential.

Using Drydock, this will be feasible for hosted and external repositories? (Assuming phabricator has a credential with push access.)

Aug 25 2015, 7:00 PM · Haskell.org, Restricted Project, Differential
cburroughs edited the content of Community Resources.
Aug 25 2015, 6:40 PM

Aug 24 2015

cburroughs added a comment to D13957: Hide answer box if you asked the question in Ponder.
  • "Storytelling", which is sort of what I was originally interested in in that task: open-ended questions with no right answer where the question is more like a writing prompt and the answers are somewhat narrative. This is how I used Quora in ~2011, and also roughly how Everything2 (a niche community I was part of many years ago) works. This is a use case I find personally interesting, but I'm increasingly unsure it has any place in the product. In this use case, the value of the answer is as much from reading a piece of writing as from getting the answer to a question.
Aug 24 2015, 7:20 PM
cburroughs updated Q103: How to avoid conflicts with branches-on-branches development? from to How to avoid conflicts with branches-on-branches development?.
Aug 24 2015, 1:10 PM · Arcanist

Aug 21 2015

cburroughs added projects to Q102: Specifying auditor for commit: Diffusion, Audit.
Aug 21 2015, 3:20 PM · Audit, Diffusion
cburroughs added a project to Q99: What is the purpose of staging area: Harbormaster.
Aug 21 2015, 3:20 PM · Harbormaster, Diffusion
cburroughs added Q102: Specifying auditor for commit (Answer 124).
Aug 21 2015, 2:33 PM
cburroughs added Q99: What is the purpose of staging area (Answer 119).
Aug 21 2015, 12:03 PM
cburroughs created T9240: Ponder Questions on this install should probably be open to the public and googlebot.
Aug 21 2015, 11:50 AM · Ponder

Aug 20 2015

cburroughs added a comment to T9223: Allow `arc diff` to run a build step like `gradle` first, then read lint and unit messages from the output.

/me is from a java shop and jumps in.

Aug 20 2015, 4:05 PM · Unit, Arcanist
cburroughs added a comment to T8258: Allow comments in JSON.

@joshuaspence Did your stab draw blood?

Aug 20 2015, 12:31 PM · Restricted Project, libphutil, Arcanist

Aug 19 2015

cburroughs added inline comments to D13941: Update diviner support documenation.
Aug 19 2015, 6:20 PM
cburroughs added a comment to T9218: Should Owners allow multiple packages to own the same file?.

For binding builds to packages to work I think they need to overlap. For example: Run the 'Super Sweet Selinium Spaces Tests' if src/applications/spaces OR src/infrastructure changes, but src/infrastructure is also a trigger for other packages.

Aug 19 2015, 12:39 PM · Owners

Aug 18 2015

cburroughs added a comment to T9212: Community Feedback: How should we handle free support?.

The IRC support was a significant positive factor when we chose Phabricator. I dug up the old evaluation doc and right at the top had "Fanatical upstream support". The fact that it is IRC on freenode was nice since that signals a thing people use (instead of some astroturf fake free support ala google apps). That isn't to say that it will continue to be a worthwhile tradeoff to do all of that support, but I am very glad you did when we were new!

Aug 18 2015, 7:46 PM · Public & Media Relations, Support
cburroughs renamed T9210: break apart Publish/Notify repo setting from break part Publish/Notify repo setting to break apart Publish/Notify repo setting.
Aug 18 2015, 12:21 PM · Restricted Project, Restricted Project, Diffusion

Aug 17 2015

cburroughs created T9210: break apart Publish/Notify repo setting.
Aug 17 2015, 11:52 PM · Restricted Project, Restricted Project, Diffusion

Aug 14 2015

cburroughs added a comment to T7338: Build more status tools for monitoring Phacility cluster health.

From T8781, monitoring instance daemon queue lengths would be particularly helpful in identifying at least 1-2 issues we've hit.

Aug 14 2015, 8:44 PM · Almanac, Phacility
cburroughs retitled D13901: variable days back for `bin/mail volume` from to variable days back for `bin/mail volume`.
Aug 14 2015, 5:16 PM
cburroughs added a revision to T9161: How can we fix "too much mail"?: D13901: variable days back for `bin/mail volume`.
Aug 14 2015, 5:16 PM · Restricted Project, User Preferences, Mail
cburroughs added a comment to T9170: parsing giganto-normous commits causes admin headaches.

FWIW The particular commit that was causing trouble eventually (!?!) was processed. Since I could reproduce multiple times times with 4x the RAM this feels spooky. Maybe the memory consumption is non-deterministic? Or somehow very different when running in the daemon instead of the cli?

Aug 14 2015, 12:56 PM · Restricted Project, Daemons, Diffusion

Aug 13 2015

cburroughs created T9171: old maniphest_custom docs hang around, posisble confusing googlers.
Aug 13 2015, 7:26 PM · Diviner
cburroughs created T9170: parsing giganto-normous commits causes admin headaches.
Aug 13 2015, 3:58 PM · Restricted Project, Daemons, Diffusion
cburroughs added a comment to D13881: Add a linter rule for detecting empty files.

FWIW Creating an hidden empty file in a directoy seems to be the convention for making git create a directory in the working copy on checkout.

Aug 13 2015, 2:46 PM

Aug 12 2015

cburroughs awarded Arcanist Workflows a Baby Tequila token.
Aug 12 2015, 7:40 PM

Aug 11 2015

cburroughs created T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule'.
Aug 11 2015, 3:11 PM · Restricted Project, Herald

Aug 10 2015

cburroughs edited P1840 repo-cloc.yaml.
Aug 10 2015, 1:12 PM

Aug 6 2015

cburroughs awarded D13813: Add a rough `bin/mail volume` command for showing mail volume a Love token.
Aug 6 2015, 6:56 PM
cburroughs added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.
  • As an admin being able to see people's email settings would be nice, but probably has thorny security issues and I think I can just go figure this out from the DB anyway without too much trouble anyway.
Aug 6 2015, 6:48 PM · Aphlict, Conpherence
cburroughs added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

I agree that too much email is often a mostly cultural problem. I'm personally only moderately annoyed by email volume, and usually only in cases where a bunch of things happened at around the same time. But I also have 30k unread emails sorted from mailing lists to read on train trips and I suspect most would view that as a bizarre edge case. Batching felt like it might be a salve of sorts for legitimately annoying cases, but I'm not particularly attached to it. Anecdotally some users have reported things along the lines of 'I have used a bunch of other systems and phabricator is the only one I have felt overwhelmed by email with' (I know that feedback is too general to be of much use here.)

Aug 6 2015, 6:00 PM · Aphlict, Conpherence
cburroughs added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

No, this refers to real-time notifications only. Users will see no difference in behavior (except an imperceptible delay in some lower-priority real-time notifications). This only improves scalability.

We do not currently plan to ever batch email.

Aug 6 2015, 3:56 PM · Aphlict, Conpherence
cburroughs awarded D13811: Unprototype Harbormaster a Mountain of Wealth token.
Aug 6 2015, 2:40 PM

Jul 31 2015

Neil_P._Quinn awarded T8135: drag & drop on a workboard sorted by priority behavior is surprising a Like token.
Jul 31 2015, 7:29 PM · Restricted Project, Workboards (v3), Restricted Project

Jul 30 2015

cburroughs added a comment to T7780: Add linter for Foodcritic.

Foodcritic has a few quirks in its interaction with Arcanist

Jul 30 2015, 1:47 PM · Restricted Project, Lint

Jul 24 2015

cburroughs added a comment to T8941: Badges don't show in certain Timeline conditions.

(max 2)

Jul 24 2015, 12:02 PM · Badges (v0)
cburroughs added a comment to T8943: Participant Badge Requests.

If I give this ticket two tokens do I get two badges?

Jul 24 2015, 11:59 AM · Badges

Jul 23 2015

cburroughs added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

With my 'I have a corporate install' hat I think 'Alternate Short Domain' is needed for the 'Shortener' case to work out in practice. phabricator.mycompany.com is already longer than an entire t.co url. Those two features are probably enough to replace our current internal shortener thingy.

Jul 23 2015, 12:34 PM · Phurl

Jul 21 2015

cburroughs created T8920: 'Another Herald rule matches' is being displayed as a raw PHID.
Jul 21 2015, 6:41 PM · Herald
cburroughs created T8919: owners autocomplete send to /null url.
Jul 21 2015, 6:22 PM · Owners
cburroughs placed T7484: Lock is not locked by this process up for grabs.

We have not had any poltergeist sightings recently.

Jul 21 2015, 6:05 PM · Restricted Project, Daemons

Jul 15 2015

cburroughs edited P1824 .hooks/arc-lint-on-commit.sh.
Jul 15 2015, 6:51 PM

Jul 10 2015

cburroughs added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I just realized the examples use the WoW rarity scheme ❤️

Jul 10 2015, 4:09 PM · Restricted Project, Badges (v0), People

Jul 9 2015

cburroughs added a comment to D13394: MetaMTA - lay some ground work for having an application.

For posterity:

  • For rough ballparks, a gzipped sql dump of our db is 2.1 GiB.
  • On our test instance (fork of the prod db from a few weeks ago) running the migration normally took 30-45 minutes.
  • For the production migration we disabled fsync (zfs set sync=disabled tank/lxc/foo) and it took 4m10.926s.
Jul 9 2015, 12:12 PM

Jul 8 2015

cburroughs added a comment to D13394: MetaMTA - lay some ground work for having an application.

Is it expected that these migrations will take a long time (like > 30 minutes)?

Jul 8 2015, 8:13 PM
cburroughs added a comment to T8783: Unprototype Nuance (v1).

Do you expect handling alert triage to be a good fit for Nuance?

Jul 8 2015, 3:21 PM · Nuance, Restricted Project

Jul 6 2015

cburroughs abandoned D10610: A batch editable page for viewing a single board column.

No longer intend to run this in production.

Jul 6 2015, 7:37 PM
cburroughs added a comment to T8738: Allow server administrators to require a minimum version of Arcanist.

As an Administrator it would be nice if there was a way to tell which version of arcanist was being used. Right now I guess based on depricated conduit calls.

Jul 6 2015, 3:17 PM · Arcanist

Jun 18 2015

cburroughs awarded T8609: Test TAsk a Pterodactyl token.
Jun 18 2015, 9:01 PM
cburroughs added a comment to T8603: repository.query is not returning required parameter `order`.

(Wait I may be crazy.)

Jun 18 2015, 4:17 PM · Disqus, Conduit
cburroughs added a project to T8603: repository.query is not returning required parameter `order`: Disqus.

The client is doing validation of the response including presence of fields and their type.

Jun 18 2015, 4:10 PM · Disqus, Conduit
cburroughs added a comment to T8594: Develop system for dumping/backing up Phriction documents.

This is a related wishlist-y thing but it would be really cool if:

  • The wiki was a repo
  • It could be mirrored in a minimal read-only way (which could mean a lot of things, maybe it renders remarkup but otherwise just links everything?) but sync with the 'main' instance somehow (master with a repo mirror?). Honestly just the raw markup in a repo would probably be good enough to make me switch.
Jun 18 2015, 3:39 PM · Phriction, Restricted Project
cburroughs renamed T8603: repository.query is not returning required parameter `order` from repository.query is not returning required paramter `order` to repository.query is not returning required parameter `order`.
Jun 18 2015, 3:02 PM · Disqus, Conduit
cburroughs created T8603: repository.query is not returning required parameter `order`.
Jun 18 2015, 3:02 PM · Disqus, Conduit

Jun 17 2015

cburroughs closed T8585: PhabricatorBot failing with Attempt to write to undeclared property as Invalid.
Jun 17 2015, 4:11 PM
cburroughs added a comment to T8585: PhabricatorBot failing with Attempt to write to undeclared property .

Oh Cowboy Commits giddyup

Jun 17 2015, 4:09 PM
cburroughs added a comment to T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.
  • We should move to giving the bot a list of channels to join, and a list of handlers to run in each channel -- not a list of handlers to run at top level, and then other top-level config for each handler about channel behaviors. This also resolves issues like T7800.
Jun 17 2015, 3:00 PM · Conpherence, Phabot
cburroughs created T8586: getting notification + email recently on this install.
Jun 17 2015, 2:52 PM
cburroughs created T8585: PhabricatorBot failing with Attempt to write to undeclared property .
Jun 17 2015, 2:41 PM

Jun 16 2015

cburroughs added a comment to T4558: Make Diviner useful for third-parties.

Is the vision for Diviner that it will become as full featured as something like sphinx (the place to write Serious Docs for all my software projects) or just moderately useful for things that are not Phabricator?

Jun 16 2015, 12:36 AM · Diviner

Jun 15 2015

cburroughs planned changes to D10289: support phids in repository.query.

Just keeping patch stack up to date.

Jun 15 2015, 7:52 PM
cburroughs updated the diff for D10289: support phids in repository.query.
  • rebase
Jun 15 2015, 7:51 PM
cburroughs added a comment to T8549: Feedback on 2015 Redesign.

https://secure.phabricator.com/book/phabflavor/article/writing_reviewable_code/ <-- Article button shows up twice now

Jun 15 2015, 3:54 PM · Design

Jun 11 2015

ox awarded Changelog a Yellow Medal token.
Jun 11 2015, 4:03 PM

Jun 6 2015

cburroughs edited the content of 2015 Week 23 (Early June).
Jun 6 2015, 9:53 PM