Page MenuHomePhabricator

variable days back for `bin/mail volume`
ClosedPublic

Authored by cburroughs on Aug 14 2015, 5:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 10, 2:31 AM
Unknown Object (File)
Sat, Aug 6, 3:03 PM
Unknown Object (File)
Fri, Jul 15, 10:37 AM
Unknown Object (File)
Jul 12 2022, 10:26 AM
Unknown Object (File)
Jul 3 2022, 1:28 PM
Unknown Object (File)
Jul 3 2022, 1:28 PM
Unknown Object (File)
Jul 3 2022, 1:28 PM
Unknown Object (File)
Jul 2 2022, 12:42 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9161: How can we fix "too much mail"?
Commits
Restricted Diffusion Commit
rP786b135a662c: variable days back for `bin/mail volume`
Summary

Email is so exciting I can't wait 30 days for initial results.

ref T9161

Test Plan
  • ./bin/mail volume --days 60 took longer and gave plausibly larger results.
  • ./bin/mail volume --days 0 quickly told me no mail had been sent.
  • ./bin/mail volume Said it was still looking 30 days back.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cburroughs retitled this revision from to variable days back for `bin/mail volume`.
cburroughs updated this object.
cburroughs edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.
epriestley added inline comments.
src/applications/metamta/management/PhabricatorMailManagementVolumeWorkflow.php
29–38

Consider retaining phutil_units() for readability.

114–116

Slightly more correct as:

pht(
  'Mail sent in the last %s day(s).',
  new PhutilNumber($args->getArg('days')));

This will allow the translation framework to produce output like this:

Mail sent in the last 1,234,567 days. (Localized decimal separators.)
Mail sent in the last day. (Localized plural nouns.)
This revision is now accepted and ready to land.Aug 27 2015, 11:38 AM
This revision was automatically updated to reflect the committed changes.