- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 10 2020
Apr 10 2020
epriestley committed rARC9e72e4ed1df5: Bring "pro" browse queries from modern hardpoint code (authored by epriestley).
Bring "pro" browse queries from modern hardpoint code
epriestley committed rPc3be82fe6e09: Fix an out-of-date API call on the destruction pathway for Pholio mocks (authored by epriestley).
Fix an out-of-date API call on the destruction pathway for Pholio mocks
epriestley added inline comments to D19914: Make Images in Pholio refer to mocks by PHID instead of ID.
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21080: Bring "pro" browse queries from modern hardpoint code.
Apr 10 2020, 2:51 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
No current plans to pursue this upstream.
epriestley committed rARC8bb81217d5d2: Bring a "pro" WorkingCopyState ref to "master" (authored by epriestley).
Bring a "pro" WorkingCopyState ref to "master"
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21079: Bring a "pro" WorkingCopyState ref to "master".
Apr 10 2020, 1:06 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley committed rARCadea2550f533: Introduce "arc inspect" and some of the new ref/hardpoint classes (authored by epriestley).
Introduce "arc inspect" and some of the new ref/hardpoint classes
epriestley requested review of D21078: Introduce "arc inspect" and some of the new ref/hardpoint classes.
Generators can't "return" until PHP 7:
Apr 10 2020, 11:43 AM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21078: Introduce "arc inspect" and some of the new ref/hardpoint classes.
Apr 10 2020, 11:39 AM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley committed rARC92b29f53f3c9: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist (authored by epriestley).
Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist
epriestley committed rARC391c1643134a: Trivially update "arc branch/feature" and "arc browse" for Toolsets (authored by epriestley).
Trivially update "arc branch/feature" and "arc browse" for Toolsets
Apr 9 2020
Apr 9 2020
epriestley committed rPa2fb91b8af4b: Remove the (hopefully) obsolete "post_max_size" check during startup (authored by epriestley).
Remove the (hopefully) obsolete "post_max_size" check during startup
epriestley requested review of D21077: Remove the (hopefully) obsolete "post_max_size" check during startup.
PHP has a setting called post_max_size. If a POST request is larger than this size, PHP does not populate $_POST or $_FILES.
epriestley committed rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator" (authored by epriestley).
Revert "Compress requests from the Conduit client to Phabricator"
epriestley requested review of D21076: Revert "Compress requests from the Conduit client to Phabricator".
Apr 8 2020
Apr 8 2020
epriestley requested review of D21075: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist.
epriestley requested review of D21074: Trivially update "arc branch/feature" and "arc browse" for Toolsets.
epriestley committed rARC7e25288f4968: Compress requests from the Conduit client to Phabricator (authored by epriestley).
Compress requests from the Conduit client to Phabricator
epriestley committed rARCdeb72c37db84: Remove onboard future bulk-resolution from ConduitEngine (authored by epriestley).
Remove onboard future bulk-resolution from ConduitEngine
epriestley committed rARC85141c4d909b: Add new "Hardpoint" classes to support request parallelization (authored by epriestley).
Add new "Hardpoint" classes to support request parallelization
epriestley committed rARC0b3cd39230e9: Update the "WorkingCopy" API and create a fallback "Filesystem" working copy (authored by epriestley).
Update the "WorkingCopy" API and create a fallback "Filesystem" working copy
epriestley added a comment to D21071: Add new "Hardpoint" classes to support request parallelization.
This also updates the XHPAST linter to target PHP 5.5 (see T13492); it complained about Generator otherwise.
epriestley requested review of D21071: Add new "Hardpoint" classes to support request parallelization.
In T11968#251717, @epriestley wrote:XHPAST currently can't build an AST for $result = yield ..., even though this is a valid construct. This is probably a straightforward fix.
Apr 7 2020
Apr 7 2020
epriestley committed rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;" (authored by epriestley).
Fix improper XHPAST parsing of namespace grammar like "use x as private;"
epriestley committed rARCe03431def8c0: Fix XHPAST parsing of variadic calls (authored by epriestley).
Fix XHPAST parsing of variadic calls
epriestley committed rARCa689dee22826: Update XHPAST "expect" test blocks to the new stable, human-readable format (authored by epriestley).
Update XHPAST "expect" test blocks to the new stable, human-readable format
epriestley committed rARC8a7ce97b51a0: Make XHPAST unit test "expect" blocks stable and human-readable (authored by epriestley).
Make XHPAST unit test "expect" blocks stable and human-readable
epriestley committed rARC6d15c6ea4869: Remove duplication of XHPAST version in PHP and C code (authored by epriestley).
Remove duplication of XHPAST version in PHP and C code
epriestley committed rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3 (authored by epriestley).
Revert xhpast changes that impacted builds under Bison 2.3
Superseded by D21066.
Much of this is supported now; T13492 has some general followup.
In T13492#251814, @epriestley wrote:XHPAST currently can not parse $x = yield $y;.
epriestley requested review of D21065: Make XHPAST unit test "expect" blocks stable and human-readable.
Test failures are expected.
(This was ultimately superseded by D21065.)
epriestley renamed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) from XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) to XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3).
This is entangled with T9753.
XHPAST currently can not parse $x = yield $y;. I suspect this was added to the PHP grammar after XHPAST diverged. I'm hopeful the fix is straightforward.
epriestley moved T6925: XHPAST is out of date on Windows from Backlog to Windows on the XHPAST board.
epriestley moved T8653: xhpast generation does not work properly under MinGW if the repo has CRLF line endings from Backlog to Windows on the XHPAST board.
epriestley moved T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits from Backlog to Future on the XHPAST board.
No current plans to pursue this.
epriestley moved T10971: php lint: catch `"${var}"` vs `"{$var}"` from Backlog to String Variables on the XHPAST board.
epriestley moved T8049: Improve parsing of variables embedded in strings in XHPAST from Backlog to String Variables on the XHPAST board.