Page MenuHomePhabricator

Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist
ClosedPublic

Authored by epriestley on Apr 8 2020, 7:37 PM.
Tags
None
Referenced Files
F19508073: D21075.diff
Sat, Jan 10, 1:03 AM
F19468994: D21075.id50210.diff
Sun, Jan 4, 1:55 PM
F19111653: D21075.diff
Dec 9 2025, 4:42 PM
F19083223: D21075.id50210.diff
Dec 2 2025, 12:32 PM
F18985389: D21075.id50204.diff
Nov 17 2025, 1:01 PM
F18959852: D21075.diff
Nov 13 2025, 8:45 AM
F18936255: D21075.id.diff
Nov 10 2025, 8:01 PM
F18759718: D21075.id50210.diff
Oct 6 2025, 5:34 AM
Subscribers
None

Details

Summary

Depends on D21074. Ref T13490. Ref T11968. Before toolsets, Arcanist has a "WorkingCopyIdentity" object. After toolsets, it has a "WorkingCopy" object.

Most workflows don't access either one, so make a slightly-breaking API change to simplify the transition.

  • "getWorkingCopy()" now returns a modern object (a "WorkingCopy").
  • "getWorkingCopyIdentity()" now returns an older object (a "WorkingCopyIdentity").

This isn't backward-compatible, but out-of-date code should get an explicit failure with clear resolution steps.

Test Plan

Ran "arc lint", "arc branch", and a few other commands. Grepped for "getWorkingCopy()".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 11:24 AM
This revision was automatically updated to reflect the committed changes.