Page MenuHomePhabricator
Differential D21075

Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist
ClosedPublic
Actions

Authored by epriestley on Apr 8 2020, 7:37 PM.
Tags
None
Referenced Files
F15575726: D21075.id50204.diff
Tue, May 6, 6:31 AM
F15561055: D21075.id50210.diff
Tue, Apr 29, 5:55 PM
F15559842: D21075.id50204.diff
Tue, Apr 29, 11:22 AM
F15552496: D21075.id.diff
Sun, Apr 27, 9:10 PM
F15550330: D21075.id50210.diff
Sun, Apr 27, 11:09 AM
F15542563: D21075.diff
Fri, Apr 25, 5:26 PM
F15507991: D21075.diff
Wed, Apr 16, 12:52 AM
F15501125: D21075.id50204.diff
Sun, Apr 13, 8:49 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11968: Decide the fate of FutureGraph
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARC92b29f53f3c9: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist
Summary

Depends on D21074. Ref T13490. Ref T11968. Before toolsets, Arcanist has a "WorkingCopyIdentity" object. After toolsets, it has a "WorkingCopy" object.

Most workflows don't access either one, so make a slightly-breaking API change to simplify the transition.

  • "getWorkingCopy()" now returns a modern object (a "WorkingCopy").
  • "getWorkingCopyIdentity()" now returns an older object (a "WorkingCopyIdentity").

This isn't backward-compatible, but out-of-date code should get an explicit failure with clear resolution steps.

Test Plan

Ran "arc lint", "arc branch", and a few other commands. Grepped for "getWorkingCopy()".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 8 2020, 7:37 PM
Harbormaster completed remote builds in B24022: Diff 50204.Apr 8 2020, 7:37 PM
epriestley requested review of this revision.Apr 8 2020, 7:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 11:24 AM
Closed by commit rARC92b29f53f3c9: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC92b29f53f3c9: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist.

Revision Contents
Changeset List

Diff 50210

View Options

src/workflow/ArcanistFeatureWorkflow.php

Loading...
View Options

src/workflow/ArcanistGetConfigWorkflow.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
View Options

src/workflow/ArcanistUnitWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility