Page MenuHomePhabricator

Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist
ClosedPublic

Authored by epriestley on Apr 8 2020, 7:37 PM.
Tags
None
Referenced Files
F10766701: D21075.id50210.diff
Fri, May 27, 7:03 AM
F10764949: D21075.id.diff
Thu, May 26, 9:34 PM
Unknown Object (File)
Wed, May 25, 1:28 AM
Subscribers
None

Details

Summary

Depends on D21074. Ref T13490. Ref T11968. Before toolsets, Arcanist has a "WorkingCopyIdentity" object. After toolsets, it has a "WorkingCopy" object.

Most workflows don't access either one, so make a slightly-breaking API change to simplify the transition.

  • "getWorkingCopy()" now returns a modern object (a "WorkingCopy").
  • "getWorkingCopyIdentity()" now returns an older object (a "WorkingCopyIdentity").

This isn't backward-compatible, but out-of-date code should get an explicit failure with clear resolution steps.

Test Plan

Ran "arc lint", "arc branch", and a few other commands. Grepped for "getWorkingCopy()".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 11:24 AM
This revision was automatically updated to reflect the committed changes.