Page MenuHomePhabricator

Remove onboard future bulk-resolution from ConduitEngine
ClosedPublic

Authored by epriestley on Apr 8 2020, 3:55 PM.
Tags
None
Referenced Files
F13086171: D21072.diff
Thu, Apr 25, 12:05 AM
Unknown Object (File)
Sat, Apr 20, 5:10 PM
Unknown Object (File)
Sat, Apr 13, 12:14 AM
Unknown Object (File)
Thu, Apr 11, 8:22 AM
Unknown Object (File)
Sat, Mar 30, 9:12 AM
Unknown Object (File)
Thu, Mar 28, 6:08 PM
Unknown Object (File)
Feb 3 2024, 11:56 PM
Unknown Object (File)
Jan 28 2024, 2:03 AM
Subscribers
None

Details

Summary

Depends on D21071. Ref T11968. Currently, "ConduitEngine" tries to lightly parallelize futures. This was a compromise when the initial "hardpoint" change didn't plan to pursue real request paralleization.

Now that the newer hardpoint change does, we don't need onboard resolution in ConduitEngine. Throw it away.

When the engine is supposed to resolve a future, it now just resolves that future on its own. This should be functionally identical to the previous behavior, except that it may be slower.

(In practice, because HTTP futures are backed by an internal cURL request pool, this proably has little effect anywhere. Moving to modern hardpoints will make performance no worse than it was prior to this change, in any case.)

Test Plan

Ran various modern "arc" commands.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2020, 4:24 PM
This revision was automatically updated to reflect the committed changes.