Differential D21068

Fix improper XHPAST parsing of namespace grammar like "use x as private;"
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:24 PM.

Tags

None

Referenced Files

	F18100953: D21068.id.diff
	Sat, Aug 9, 12:12 PM

	F18087470: D21068.id50187.diff
	Wed, Aug 6, 4:08 AM

	F18081913: D21068.id50193.diff
	Tue, Aug 5, 3:03 AM

	F17860711: D21068.id.diff
	Jul 27 2025, 10:04 PM

	F17826420: D21068.diff
	Jul 26 2025, 7:16 AM

	F17788717: D21068.id.diff
	Jul 24 2025, 6:13 PM

	F17756591: D21068.diff
	Jul 22 2025, 2:25 PM

	Unknown Object (File)
	Jul 5 2025, 3:17 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits: rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;"

Summary

Depends on D21067. Ref T13492. Converting unit tests to be readable exposed this error in the grammar.

Normally, "grammar_rule" rules emit a standalone Node. In this case, the bottom-level grammar rule is a collection of trivial rules and the callers configure the Node. Wrap the bottom-level rule in a configuration rule so the node is configured correctly and consistently, in exactly one place.

Test Plan

Ran unit tests.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 7 2020, 9:24 PM

Harbormaster completed remote builds in B24006: Diff 50187.Apr 7 2020, 9:25 PM

epriestley requested review of this revision.Apr 7 2020, 9:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 9:35 PM

Closed by commit rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;".

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

php-traits.php.test

2 lines

bin/

PhutilXHPASTBinary.php

2 lines

support/

xhpast/

12 lines

parser.yacc.cpp

Diff 50193

src/parser/xhpast/tests/data/php-traits.php.test

Loading...

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...

support/xhpast/parser.y

Loading...

support/xhpast/parser.yacc.cpp

Loading...