Page MenuHomePhabricator

Make XHPAST unit test "expect" blocks stable and human-readable
ClosedPublic

Authored by epriestley on Apr 7 2020, 9:08 PM.

Details

Summary

Depends on D21064. Ref T13492. Earlier, see D17819. This is essentially the same change, although I inlined the token stream into the node list.

This intentionally breaks most tests since it just has the new "expect" generator; the next change will fix them by swapping the test bodies.

Test Plan

Ran "arc unit --everything" after the next change (which fixes all the tests), got a clean build. This change on its own fails all existing XHPAST tests since the block formats don't match.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2020, 9:09 PM
Harbormaster failed remote builds in B24003: Diff 50184!

Test failures are expected.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 9:32 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.