Page MenuHomePhabricator

Fix XHPAST parsing of variadic calls
ClosedPublic

Authored by epriestley on Apr 7 2020, 9:12 PM.
Tags
None
Referenced Files
F15528065: D21067.id.diff
Tue, Apr 22, 8:39 AM
F15525858: D21067.id50186.diff
Mon, Apr 21, 5:21 PM
F15482985: D21067.id50186.diff
Wed, Apr 9, 9:00 AM
F15482413: D21067.id50192.diff
Wed, Apr 9, 5:16 AM
F15479630: D21067.id.diff
Tue, Apr 8, 8:31 AM
F15477323: D21067.diff
Apr 7 2025, 1:28 PM
F15440281: D21067.diff
Mar 26 2025, 11:51 AM
F15423880: D21067.id50186.diff
Mar 22 2025, 7:10 PM
Subscribers
None

Details

Summary

Depends on D21066. Ref T13492. The switch of unit test data to stable/readable output exposed this bug in parsing of variadic calls: some nodes are not given types properly.

Fix the parser and update the test.

Test Plan

Ran the test, which now works.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable