Page MenuHomePhabricator

Introduce "arc inspect" and some of the new ref/hardpoint classes
ClosedPublic

Authored by epriestley on Apr 10 2020, 11:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 3 2024, 11:58 PM
Unknown Object (File)
Jan 30 2024, 11:15 AM
Unknown Object (File)
Jan 24 2024, 9:50 PM
Unknown Object (File)
Jan 10 2024, 10:37 AM
Unknown Object (File)
Dec 30 2023, 12:09 AM
Unknown Object (File)
Dec 26 2023, 5:36 AM
Unknown Object (File)
Dec 22 2023, 5:04 PM
Unknown Object (File)
Dec 14 2023, 6:42 AM
Subscribers
None

Details

Summary

Ref T11968. Inches toward the new ref/hardpoint code by introducing the modern refs as "RefPro" objects and supporting an "arc inspect <object>" to load objects and hardpoints.

This doesn't impact any existing runtime behavior.

Test Plan

Ran "arc inspect [--all] commit(...)", got hardpoint queries and yield-based data fetching.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 10 2020, 11:40 AM
Harbormaster failed remote builds in B24029: Diff 50211!
  • Don't "return $value" inside generators, since this does not work until PHP7.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 12:01 PM
This revision was automatically updated to reflect the committed changes.