Page MenuHomePhabricator
Differential D21064

Remove duplication of XHPAST version in PHP and C code
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:04 PM.
Tags
None
Referenced Files
F19094439: D21064.id50189.diff
Thu, Dec 4, 12:49 AM
F19094289: D21064.id50189.diff
Thu, Dec 4, 12:13 AM
F19087181: D21064.id.diff
Tue, Dec 2, 11:58 PM
F19075367: D21064.diff
Mon, Dec 1, 9:36 AM
F19055388: D21064.diff
Fri, Nov 28, 5:21 PM
F19055377: D21064.diff
Fri, Nov 28, 5:14 PM
F18857653: D21064.diff
Nov 1 2025, 4:58 PM
F18854376: D21064.id.diff
Oct 31 2025, 11:45 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits
rARC6d15c6ea4869: Remove duplication of XHPAST version in PHP and C code
Summary

Depends on D21063. Ref T13492. Currently, XHPAST defines a version in both PHP code and C code, and they must be kept in sync.

Switch to a single definition in PHP, then carry it through the build pipeline into C.

Test Plan

Did a clean rebuild of XHPAST, saw a version number carried in from PHP. Ran "xhpast --version".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
support/
xhpast/
5 lines
bin/
xhpast-generate-nodes.php
generate_nodes.php
21 lines
bin/
8 lines
7 lines

Diff 50189

View Options

support/xhpast/Makefile

Loading...
View Options

support/xhpast/bin/xhpast-generate-nodes.php

Loading...
View Options

support/xhpast/bin/xhpast-generate-version.php

Loading...
View Options

support/xhpast/generate_nodes.php

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility