Page MenuHomePhabricator

Remove duplication of XHPAST version in PHP and C code
ClosedPublic

Authored by epriestley on Apr 7 2020, 9:04 PM.

Details

Summary

Depends on D21063. Ref T13492. Currently, XHPAST defines a version in both PHP code and C code, and they must be kept in sync.

Switch to a single definition in PHP, then carry it through the build pipeline into C.

Test Plan

Did a clean rebuild of XHPAST, saw a version number carried in from PHP. Ran "xhpast --version".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable