Page MenuHomePhabricator
Differential D21064

Remove duplication of XHPAST version in PHP and C code
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:04 PM.
Tags
None
Referenced Files
F15581475: D21064.diff
Wed, May 7, 11:11 AM
F15572926: D21064.id.diff
Mon, May 5, 6:20 PM
F15524227: D21064.diff
Mon, Apr 21, 6:43 AM
F15481297: D21064.id50183.diff
Tue, Apr 8, 7:55 PM
F15480672: D21064.id50189.diff
Tue, Apr 8, 3:38 PM
F15478424: D21064.id.diff
Apr 7 2025, 11:14 PM
F15474609: D21064.diff
Apr 6 2025, 10:11 AM
F15471557: D21064.diff
Apr 5 2025, 5:56 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits
rARC6d15c6ea4869: Remove duplication of XHPAST version in PHP and C code
Summary

Depends on D21063. Ref T13492. Currently, XHPAST defines a version in both PHP code and C code, and they must be kept in sync.

Switch to a single definition in PHP, then carry it through the build pipeline into C.

Test Plan

Did a clean rebuild of XHPAST, saw a version number carried in from PHP. Ran "xhpast --version".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
support/
xhpast/
5 lines
bin/
xhpast-generate-nodes.php
generate_nodes.php
21 lines
bin/
8 lines
7 lines

Diff 50189

View Options

support/xhpast/Makefile

Loading...
View Options

support/xhpast/bin/xhpast-generate-nodes.php

Loading...
View Options

support/xhpast/bin/xhpast-generate-version.php

Loading...
View Options

support/xhpast/generate_nodes.php

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility