Remove the (hopefully) obsolete "post_max_size" check during startup
ClosedPublic
Actions

Authored by epriestley on Apr 9 2020, 8:27 PM.

Details

Reviewers: None
Maniphest Tasks: T13507: Compress Conduit client requests
Commits: rPa2fb91b8af4b: Remove the (hopefully) obsolete "post_max_size" check during startup

Summary

Ref T13507. See that task for discussion. This check appears to be obsolete in all common cases and misfires if the client submits compressed requests.

Since the cases where it could still trigger correctly are extremely rare and should still have plausible behavior, just remove it.

Test Plan

Grepped for calls.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 9 2020, 8:27 PM

Harbormaster completed remote builds in B24025: Diff 50207.Apr 9 2020, 8:28 PM

epriestley requested review of this revision.Apr 9 2020, 8:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2020, 8:33 PM

Closed by commit rPa2fb91b8af4b: Remove the (hopefully) obsolete "post_max_size" check during startup (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa2fb91b8af4b: Remove the (hopefully) obsolete "post_max_size" check during startup.

Revision Contents
Changeset List

Path

Size

support/

startup/

PhabricatorStartup.php

100 lines

Diff 50208

View Options

support/startup/PhabricatorStartup.php

Remove the (hopefully) obsolete "post_max_size" check during startupClosedPublicActions