Page MenuHomePhabricator
Feed Advanced Search

Feb 10 2018

epriestley added a comment to T7467: Consider giving deleted files a more prominent treatment in the changeset UI.

See also PHI356.

Feb 10 2018, 7:47 PM · Restricted Project, Differential
epriestley closed T7257: Incorrect diff between patches of different owners as Invalid.

This report doesn't meet the reproduction instruction requirement for modern bug reports.

Feb 10 2018, 7:46 PM · Differential
epriestley added a comment to T6410: Differential: Allow collapsing and expanding folders in file tree view.

See also PHI356.

Feb 10 2018, 7:44 PM · Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T4698: Support for SVN patches, created by PhpStorm.
Feb 10 2018, 7:43 PM · Arcanist, Differential
epriestley added a parent task for T4698: Support for SVN patches, created by PhpStorm: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Feb 10 2018, 7:43 PM · Subversion, Differential
epriestley moved T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated from Backlog to Far Future Work on the Differential board.
Feb 10 2018, 7:40 PM · Diffusion, Herald
epriestley added a revision to T11154: Build results don't always get conferred to their buildable: Unknown Object (Differential Revision).
Feb 10 2018, 7:38 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a revision to T10746: Aborted build in Harbormaster still shows as building in Diffusion: Restricted Differential Revision.
Feb 10 2018, 7:38 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: Restricted Differential Revision.
Feb 10 2018, 7:38 PM · Plans, Differential, Harbormaster
epriestley updated the task description for T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Feb 10 2018, 7:35 PM · Plans, Differential, Harbormaster
epriestley updated the task description for T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Feb 10 2018, 7:13 PM · Plans, Differential, Harbormaster
epriestley updated the task description for T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Feb 10 2018, 7:13 PM · Plans, Differential, Harbormaster
epriestley renamed T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction from Plans: Harbormaster Interactions with Differential to Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Feb 10 2018, 7:09 PM · Plans, Differential, Harbormaster
kuba-orlik awarded T731: Allow revisions to have alternate acceptance conditions a Like token.
Feb 10 2018, 2:21 PM · Restricted Project, Restricted Project, Differential
epriestley edited the content of Changelog.
Feb 10 2018, 1:17 AM
epriestley created 2018 Week 6 (Early February).
Feb 10 2018, 1:16 AM
epriestley closed T12677: Support multiple mail delivery services for automatic failover as Resolved.

This hasn't blown up in 24 hours and is about to promote, so anything else can be handled in followups.

Feb 10 2018, 12:40 AM · Phacility, Mail

Feb 9 2018

epriestley added a comment to T13053: Plans: Mail Tags and Failover.

(Testing "secure" flag in webhooks. 🐑)

Feb 9 2018, 11:09 PM · Plans, Must Encrypt Mail, Mail
epriestley triaged T13070: Deprecate and remove `feed.http-hooks` as Wishlist priority.
Feb 9 2018, 11:08 PM · Feed
epriestley renamed T10363: Reorient Doorkeeper publishing around transactions instead of feed stories from Reorient publishing (Doorkeeper, feed.http-hooks) around transactions instead of feed stories to Reorient Doorkeeper publishing around transactions instead of feed stories.
Feb 9 2018, 11:06 PM · Nuance, Restricted Project, Feed, Doorkeeper
epriestley updated the task description for T5462: How do I publish Phabricator events into remote systems?.
Feb 9 2018, 11:05 PM · Guides, Herald, Feed, Doorkeeper
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 9 2018, 10:42 PM · Phacility, Mail
epriestley closed T6121: Support non-latin characters in macros as Resolved by committing Restricted Diffusion Commit.
Feb 9 2018, 10:34 PM · Macros
epriestley added a revision to T6121: Support non-latin characters in macros: Unknown Object (Differential Revision).
Feb 9 2018, 10:32 PM · Macros
epriestley added a comment to T6121: Support non-latin characters in macros.

See PHI357.

Feb 9 2018, 10:18 PM · Macros
epriestley added a comment to T11330: Allow Herald to "Queue Call to Webhook: ...".

I'm not entirely sure this resolves the original request, but we have webhooks now. See also PHI348 and PHI349. There's some documentation that should publish shortly and the changelog should have more details in the next couple hours.

Feb 9 2018, 10:09 PM · Feature Request
epriestley closed T11330: Allow Herald to "Queue Call to Webhook: ...", a subtask of T5462: How do I publish Phabricator events into remote systems?, as Resolved.
Feb 9 2018, 9:57 PM · Guides, Herald, Feed, Doorkeeper
epriestley closed T11330: Allow Herald to "Queue Call to Webhook: ..." as Resolved by committing Restricted Diffusion Commit.
Feb 9 2018, 9:57 PM · Feature Request
epriestley added a revision to T11330: Allow Herald to "Queue Call to Webhook: ...": Unknown Object (Differential Revision).
Feb 9 2018, 9:38 PM · Feature Request
epriestley added a revision to T11330: Allow Herald to "Queue Call to Webhook: ...": Unknown Object (Differential Revision).
Feb 9 2018, 8:23 PM · Feature Request
epriestley added a revision to T11330: Allow Herald to "Queue Call to Webhook: ...": Unknown Object (Differential Revision).
Feb 9 2018, 8:09 PM · Feature Request
epriestley added a revision to T11330: Allow Herald to "Queue Call to Webhook: ...": Unknown Object (Differential Revision).
Feb 9 2018, 7:47 PM · Feature Request
epriestley added a revision to T11330: Allow Herald to "Queue Call to Webhook: ...": Unknown Object (Differential Revision).
Feb 9 2018, 7:42 PM · Feature Request
epriestley added a revision to T11330: Allow Herald to "Queue Call to Webhook: ...": Unknown Object (Differential Revision).
Feb 9 2018, 5:42 PM · Feature Request
epriestley closed T5726: Add more information to story POSTs during the feed.http-hooks hook as Wontfix.

I'm planning to build T11330 ("policy-blind" webhooks) instead, and deprecate feed.http-hooks. See that task for details.

Feb 9 2018, 1:29 PM · Feed
epriestley closed T5726: Add more information to story POSTs during the feed.http-hooks hook, a subtask of T11330: Allow Herald to "Queue Call to Webhook: ...", as Wontfix.
Feb 9 2018, 1:29 PM · Feature Request
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.

Seems OK:

Feb 9 2018, 2:17 AM · Phacility, Mail
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.

(I've muted this task so I shouldn't get mail about it.)

Feb 9 2018, 2:16 AM · Phacility, Mail
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.

"Quack, quack" said the duck.

Feb 9 2018, 2:13 AM · Phacility, Mail
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.

We now have Postmark configured as a primary mailer for this domain with inbound (via MX record) and outbound (via cluster.mailers) failover to Mailgun. 📫

Feb 9 2018, 2:13 AM · Phacility, Mail
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.

"Moo", said the cow.

Feb 9 2018, 2:12 AM · Phacility, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 9 2018, 1:50 AM · Phacility, Mail
epriestley added a comment to T12677: Support multiple mail delivery services for automatic failover.
  • PhabricatorMailSetupCheck should be removed, but some of the SES stuff should stick around.
Feb 9 2018, 1:48 AM · Phacility, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 9 2018, 1:27 AM · Phacility, Mail

Feb 8 2018

epriestley closed T4434: Track object closed/completed date and actor as Resolved by committing Restricted Diffusion Commit.
Feb 8 2018, 11:42 PM · Restricted Project, Projects, Maniphest
epriestley added a revision to T4434: Track object closed/completed date and actor: Unknown Object (Differential Revision).
Feb 8 2018, 11:16 PM · Restricted Project, Projects, Maniphest
epriestley added a revision to T4434: Track object closed/completed date and actor: Unknown Object (Differential Revision).
Feb 8 2018, 11:03 PM · Restricted Project, Projects, Maniphest
epriestley added a revision to T4434: Track object closed/completed date and actor: Unknown Object (Differential Revision).
Feb 8 2018, 10:46 PM · Restricted Project, Projects, Maniphest
epriestley added a comment to T4434: Track object closed/completed date and actor.

See also PHI347.

Feb 8 2018, 10:43 PM · Restricted Project, Projects, Maniphest
epriestley added a project to T9031: When I ignore subscription changes, I'm not notified of being cc'ed: Mail.
Feb 8 2018, 8:49 PM · Mail, Notifications
epriestley added a revision to T9031: When I ignore subscription changes, I'm not notified of being cc'ed: Unknown Object (Differential Revision).
Feb 8 2018, 8:37 PM · Mail, Notifications
epriestley added a comment to T13068: Refinements for "Mute Notifications".

I largely agree. This is getting leeway because it's backed by support mana (PHI126 basically just asks for this feature, verbatim). I think the actual change in D19033 is small enough that I don't feel too bad about giving this a shot, but I'd like this feature to see significant use and not generate a lot of confusion/support load if it's going to stay in the upstream. I'm also more comfortable trying this because it's very easy to revert.

Feb 8 2018, 8:10 PM · Notifications, Mail
epriestley closed T13053: Plans: Mail Tags and Failover as Resolved.

See T13069 for followups on mail stamps.

Feb 8 2018, 7:35 PM · Plans, Must Encrypt Mail, Mail
epriestley closed T11363: Differential "revision updated" mail preference is pretty useless, a subtask of T10448: Modularize mail tags, as Resolved.
Feb 8 2018, 7:29 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T11363: Differential "revision updated" mail preference is pretty useless as Resolved.

See T13069 for this and other similar use cases.

Feb 8 2018, 7:29 PM · Customer Impact, Restricted Project, Differential, Mail
epriestley closed T10448: Modularize mail tags as Resolved.

I'm going to roll this forward into T13069, which discusses remaining work for "mail stamps".

Feb 8 2018, 7:29 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc, a subtask of T10448: Modularize mail tags, as Resolved.
Feb 8 2018, 7:28 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc as Resolved.

I'm going to roll this forward into T13069.

Feb 8 2018, 7:28 PM · Customer Impact, Restricted Project, Mail
epriestley triaged T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags as Normal priority.
Feb 8 2018, 7:24 PM · Mail
epriestley added a comment to T13068: Refinements for "Mute Notifications".

If this feature doesn't see much use, I'd like to remove or deemphasize it (for example, by moving it to a keystroke or removing the UI and just providing access via !mute) at some point since I think UI space in the curtain is premium real estate. This doesn't need to be 200 mutes per user per day, but I could imagine this seeing essentially zero use.

Feb 8 2018, 6:59 PM · Notifications, Mail
epriestley triaged T13068: Refinements for "Mute Notifications" as Low priority.
Feb 8 2018, 6:55 PM · Notifications, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 8 2018, 6:48 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

If we make "Must Encrypt" stateful, that flag should also probably live in this table.

Feb 8 2018, 6:02 PM · Mail
epriestley moved T7477: Handle inbound email with phabricator address in the CC from Stamps/Failover to Future on the Mail board.
Feb 8 2018, 6:02 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

The scope on T13053 didn't end up making it very far in this direction so I think this missed the boat for now.

Feb 8 2018, 6:02 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T8363: Include reply action ("!action") hints in outbound email.

T11934 plans to add these commands everywhere. If they're available all over the place, it might be less necessary to add reminders.

Feb 8 2018, 6:00 PM · llvm, Restricted Project, Mail
epriestley moved T8363: Include reply action ("!action") hints in outbound email from Backlog to Future on the Mail board.
Feb 8 2018, 5:58 PM · llvm, Restricted Project, Mail
epriestley closed T11389: Object links merged in plain text email as Resolved by committing Restricted Diffusion Commit.
Feb 8 2018, 5:52 PM · Remarkup, Bug Report, Mail
epriestley closed T7804: Implement an "Acting User" Herald condition as Resolved by committing Restricted Diffusion Commit.
Feb 8 2018, 5:52 PM · Restricted Project, Herald, Mail
epriestley added a comment to T11389: Object links merged in plain text email.

D19032 now renders D123 in text contexts (plaintext email) as D123 <https://dev.tyrellcorp.com/D123> instead of https://dev.tyrellcorp.com/D123.

Feb 8 2018, 5:51 PM · Remarkup, Bug Report, Mail
epriestley added a revision to T11389: Object links merged in plain text email: Unknown Object (Differential Revision).
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley moved T11389: Object links merged in plain text email from Backlog to Stamps/Failover on the Mail board.
Feb 8 2018, 5:50 PM · Remarkup, Bug Report, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 8 2018, 5:41 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T7804: Implement an "Acting User" Herald condition: Unknown Object (Differential Revision).
Feb 8 2018, 5:41 PM · Restricted Project, Herald, Mail
epriestley moved T7804: Implement an "Acting User" Herald condition from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:40 PM · Restricted Project, Herald, Mail
epriestley closed T10189: Differential email headers seem to be missing as Resolved by committing Restricted Diffusion Commit.
Feb 8 2018, 5:31 PM · Differential, Mail, Bug Report
epriestley closed T7463: after changed mailbox to office 365, mail format is strange as Invalid.

I'm not sure how to reproduce whatever remaining issues are described here so I don't see how to move this forward.

Feb 8 2018, 5:26 PM · Mail
epriestley added a comment to T10189: Differential email headers seem to be missing.

D19030 marks this as fixed: it removes this documentation.

Feb 8 2018, 5:23 PM · Differential, Mail, Bug Report
epriestley moved T10189: Differential email headers seem to be missing from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 8 2018, 5:21 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T10189: Differential email headers seem to be missing: Unknown Object (Differential Revision).
Feb 8 2018, 5:21 PM · Differential, Mail, Bug Report
epriestley moved T10874: Add repository or project to email subject from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:14 PM · Restricted Project, Mail, Feature Request
epriestley merged T10874: Add repository or project to email subject into T10448: Modularize mail tags.
Feb 8 2018, 5:13 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T10874: Add repository or project to email subject into T10448: Modularize mail tags.
Feb 8 2018, 5:13 PM · Restricted Project, Mail, Feature Request
epriestley added a comment to T10874: Add repository or project to email subject.

I'm going to merge this into T10448, which exposes this information in an X-Header and optionally in mail bodies.

Feb 8 2018, 5:13 PM · Restricted Project, Mail, Feature Request
epriestley closed T6576: HTML bodies are not passed to all emails, a subtask of T992: Send rich HTML mail bodies without impacting reply handling functionality, as Resolved.
Feb 8 2018, 5:12 PM · Mail, Differential
epriestley closed T6576: HTML bodies are not passed to all emails as Resolved by committing Restricted Diffusion Commit.
Feb 8 2018, 5:12 PM · llvm, Mail
epriestley moved T10283: improve differential emails, optimizing for efficiency from Backlog to Stamps/Failover on the Mail board.
Feb 8 2018, 5:11 PM · Mail, Restricted Project, Feature Request
epriestley added a project to T10283: improve differential emails, optimizing for efficiency: Mail.
Feb 8 2018, 5:11 PM · Mail, Restricted Project, Feature Request
epriestley closed T10283: improve differential emails, optimizing for efficiency as Resolved.

(I think everything actionable here was addressed, or survives in followups.)

Feb 8 2018, 5:10 PM · Mail, Restricted Project, Feature Request
epriestley added a comment to T6576: HTML bodies are not passed to all emails.

I've marked D19029 as resolving this since it fixes the last one of these that I'm aware of. HTML mail has been the default for a long time now so this presumably isn't really causing problems even if there are other cases.

Feb 8 2018, 5:08 PM · llvm, Mail
epriestley added a revision to T6576: HTML bodies are not passed to all emails: Unknown Object (Differential Revision).
Feb 8 2018, 5:08 PM · llvm, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 8 2018, 5:08 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 8 2018, 5:05 PM · Plans, Must Encrypt Mail, Mail
epriestley moved T6576: HTML bodies are not passed to all emails from v3 to Stamps/Failover on the Mail board.
Feb 8 2018, 5:04 PM · llvm, Mail
epriestley moved T13065: Move storage for `mailKey` to the Mail application from Backlog to Far Future on the Mail board.
Feb 8 2018, 5:00 PM · Mail
epriestley moved T13066: Refine inbound mail error behaviors, distinguishing between actual mail sender and acting-as sender from Backlog to Far Future on the Mail board.
Feb 8 2018, 5:00 PM · Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 8 2018, 5:00 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 8 2018, 4:52 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 8 2018, 3:03 PM · Plans, Must Encrypt Mail, Mail