Page MenuHomePhabricator
Create Task
Maniphest T10746

Aborted build in Harbormaster still shows as building in Diffusion
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
swisspol
Apr 7 2016, 9:17 PM
Tags
Referenced Files
F1764543: pasted_file
Aug 17 2016, 7:45 PM
F1209938: pasted_file
Apr 7 2016, 9:17 PM
F1209940: pasted_file
Apr 7 2016, 9:17 PM
Subscribers
avivey
eadler
epriestley
joshuaspence
kiptonui
rabahmeradi
swisspol

Description

(Observed on Phacility)

Aborted build in Harbor Master...

pasted_file (478×678 px, 37 KB)

...still shows as building in Diffusion:

pasted_file (104×597 px, 19 KB)

And the tooltip says "Building" as well

Revisions and Commits

rP Phabricator
ClosedD16480 Correctly calculate "any_failed"
D19055rPa2d02aed2211 When a build is aborted, fail the buildable

Related Objects

Event Timeline

swisspol created this task.Apr 7 2016, 9:17 PM
chad renamed this task from Aborted build in Harbor Master still shows as building in Diffusion to Aborted build in Harbormaster still shows as building in Diffusion.Apr 11 2016, 2:31 AM
chad added a project: Harbormaster.
joshuaspence added a subscriber: joshuaspence.May 9 2016, 9:43 PM
eadler added a project: Restricted Project.Aug 5 2016, 4:45 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 5 2016, 4:45 PM
avivey added a subscriber: avivey.Aug 17 2016, 7:45 PM

I'm also seeing this for failed builds:

pasted_file (91×438 px, 12 KB)

avivey merged a task: T11528: Revision build status doesn't status when one of the build step was failed.Aug 26 2016, 12:04 AM
avivey added a subscriber: rabahmeradi.

I've seen this happening here too (B13428)

avivey claimed this task.Aug 31 2016, 9:23 PM
avivey added a revision: D16480: Correctly calculate "any_failed".Aug 31 2016, 9:29 PM
avivey mentioned this in D16480: Correctly calculate "any_failed".Aug 31 2016, 9:31 PM
avivey mentioned this in rP25a7266d15dc: Correctly calculate "any_failed".Aug 31 2016, 9:36 PM
avivey removed avivey as the assignee of this task.Aug 31 2016, 9:38 PM

"Failed builds show as building" is actually very different from "Aborted builds show as building". Handling the Aborting one is a more involved than I'd like to dig into right now.

avivey mentioned this in T11154: Build results don't always get conferred to their buildable.Oct 20 2016, 6:56 PM
avivey merged a task: T11807: Aborted status in Harbormaster.Nov 1 2016, 6:31 PM
avivey added a subscriber: kiptonui.
epriestley mentioned this in T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.Jan 30 2018, 8:53 PM
epriestley added a revision: D19055: When a build is aborted, fail the buildable.Feb 10 2018, 7:38 PM
epriestley closed this task as Resolved by committing rPa2d02aed2211: When a build is aborted, fail the buildable.Feb 11 2018, 12:08 AM
epriestley added a commit: rPa2d02aed2211: When a build is aborted, fail the buildable.
swisspol added a comment.Feb 11 2018, 12:17 AM

Is this retroactive to builds in this half state prior to this commit and
deploy?

epriestley added a subscriber: epriestley.Feb 11 2018, 12:41 AM

It isn't currently retroactive: the fix is in transition logic and the transition just didn't trigger before.

I think I can add a migration to (at least mostly) fix this retroactively, but it's possible that other work in T13054 will moot this before changes promote this week (e.g., there are some outstanding requests for things like "advisory builds" which don't cause a buildable failure, and it's possible that buildable status will become computed-at-runtime to address those requests). I'm not currently sure if we'll end up there, but I'll add a note there and get the simple migration in if nothing else fixes this before then.

epriestley mentioned this in T13072: Merge Harbormaster BuildCommand into BuildMessage.Feb 12 2018, 11:04 PM
epriestley mentioned this in D19091: Fail outstanding buildables with aborted builds.Feb 15 2018, 3:08 AM
epriestley mentioned this in rP2b0f98900bcb: Fail outstanding buildables with aborted builds.Feb 15 2018, 11:57 AM
Phabricator · Built by Phacility