Page MenuHomePhabricator

Reorient Doorkeeper publishing around transactions instead of feed stories
Open, Needs TriagePublic

Assigned To
Authored By
Feb 16 2016, 1:27 PM
Referenced Files
"Like" token, awarded by darkwing."Piece of Eight" token, awarded by nornagon."Like" token, awarded by avivey.


Currently, the outbound publishing pathways (Doorkeeper and feed.http-hooks) are oriented around feed stories. They came into existence in a time when feed stories were more complex, not all transaction-driven, and a primary use case for feed.http-hooks was unsophisticated chat bots that only really wanted rendered text.

In the modern codebase, pushing these down a level so they're an extension of transaction publishing makes more sense. Particularly, we do not currently publish events which don't generate feed stories through these pipelines, but "is this interesting to humans in feed?" shouldn't be a requirement for external systems to learn about transactions. The pipeline should still have access to the feed story if one generated, but should be oriented primarily around transaction groups like other publishing steps are.

Broad motivations:

  • If Nuance includes an attempt at bi-direcitonal sync for objects like GitHub Issues, we'll likely need this before then.
  • feed.http-hooks is a crumbling ruin (see T5726, etc) and making it transaction oriented would partly dig us out of that pit cheaply, especially after T5873 provides better transaction access via the API.
  • At least one sensible install wants to do reasonable things with Harbormaster transactions (see T10260) that may not make sense or may take a while to get to in the upstream, but currently can not because Harbormaster doesn't yet interact with Feed.

Event Timeline

epriestley moved this task from Backlog to v1 on the Nuance board.
epriestley edited projects, added Nuance (v1); removed Nuance.
eadler added a project: Restricted Project.Mar 24 2016, 8:14 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
epriestley edited projects, added Nuance; removed Nuance (v1).
epriestley renamed this task from Reorient publishing (Doorkeeper, feed.http-hooks) around transactions instead of feed stories to Reorient Doorkeeper publishing around transactions instead of feed stories.Feb 9 2018, 11:06 PM