I thought there was one in Diffusion too

This will break existing anchors (depending on how much we change the algorithm), although that's probably not a huuuuge deal.

I think these already broke once from D18465 and presumably it hasn't caused issues for anyone

This can be fixed by adjusting the regexp in PhabricatorObjectRemarkupRule->getObjectReferencePattern() to accept ., but then we'll match #xxx. as an anchor. In most cases, a terminal period is probably a punctuation character, not an anchor, like: For details, see D123#abc.

With T13001, the commit page itself now gives you disambiguation options if the commits are in the same repository. This is a narrower case than ambiguous commits across multiple repositories, but related if we did pursue something like hovercards or a multi-repository disambiguation page.

Another approach that might make sense would be to highlight the hash and then show a hovercard which lists the commits with that hash. Of course this wouldn't scale too far but it should handle the case where 2 or 3 commits have the same hash.

In https://hackerone.com/reports/259246 (not currently disclosed) a researcher found an actual issue with figlet. Although it would probably be hard to develop into a practical attack, it does make me feel better about the decision to pull all this stuff into PHP (not just dot) when the dot issue was originally identified.

• Remarkup areas got inline previews in D14855.
• EditEngine got some extensions to restore similar on-page previews to Maniphest.

Sorry, I should have led with a screenshot! I'm the biggest nitpicker, I know.

I can verify this fixes it! Thanks for this guys.

Thanks, that's much more clear than the original description!

No they're not. I know it's a tiny difference, but look at this closely (left is my proposal, right is the current state):

I'm confused here -- the icons are already struck in every browser on my system (Safari, Firefox, Chrome):

This should now be fixed in HEAD of master, and promote to stable within about 12 hours. Thanks for the report! Let us know if you run into anything else.

I’m fine waiting for the fix. Thanks @epriestley

I think a minimal reproduction case which is typical of this example is:

Looks to be just the presence of the "?" in the text

"XXX://123456 XXX XXX XXX://123456 XXX XXX"

You and me both. I am super confused.

Well the stack trace says PhabricatorYoutubeRemarkupRule, so I'm confused what the issue is.

LOL @chad Literally reproduced this issue here by trying to paste the above line without the back ticks. It refuses to let me comment.

I'm not sure how without giving you the entire commit message which I cannot. I think key would be a having a commit with a line (probably the first one) that looks like this "XXX://123456 XXX XXX XXX? XXX://123456 XXX XXX XXX"

How can we reproduce this issue locally?

There also seems like there may be an issue with the current parsing logic since the "detected URI" has spaces which I do not think are valid in a uri and it should have been detected as two separate URI's with some stuff in the middle.

The URI that is ambiguous is a URI to a company App on MacOS. The only part of the URI that matters is the xxx://123456. The rest is just the title of the item referenced by this URI and this title contains a "?" which mixed with T12526 may be causing this issue. There may also be a place you now need to catch exceptions thanks to URI parsing logic changes. Just guessing here from what I can tell in the code.

I had a similiar issue except my ] that caused the link syntax to close was in the text I was telling the link to render (I was auto generating links to template class ref pages and the template type wrappers are [] i.e. Array[Byte]). We got around this by not specifying text in the link syntax and just letting ReMarkUp grab the page title (which had the correct []) instead when rendering the link.

I'm not really sold on this use case, but I think the result is unintuitive/buggy enough to fix anyway.

Unicode Zero Width Space to the rescue!

Thank you for the helpful summary. The Discouraged creative solution worked for me. I expect this will be a one off, if it is not I'll try and setup some ignored phrases.

If you want to type sequences like O2 without triggering remarkup, you can:

I was trying to type the phrases "visible within O2's network" and "the O2 SIM card" but something is interpreting the company name as markup. I could type "visible within O2's network" but that seems a little odd. Is there a better solution for this off edge case?

In T5698#223992, @chad wrote:

Oh hai Cura uses Phabricator? I have a Lulzbot at home!

Oh hai Cura uses Phabricator? I have a Lulzbot at home!

@Krinkle, @pablocarrillo I second your requests. Great suggestion. I have a large README.md that I would love to split into multiple documentation files, without losing all the formatting.

• If you want to implement backslashes or thunderclouds as escape characters, feel free to do so locally. I don't plan to bring these changes upstream.
• If you want to strip zero-width spaces or escape literals, feel free to do so locally. I don't plan to bring these changes upstream.
• I do not plan to implement any sort of generalized inline escape character, sequence, or block in upstream Remarkup at this time.

Yes, it would be very easy! Feel free to implement such a rule locally.

Would it be possible for reMarkup to strip all zero-width non-breaking
spaces from its output, unless there was more than one in a row (in which
case the number would be decreased by 1)? That would solve the problem.

Heh, zero-width spaces are an option, yes. A bit too subtle in my eyes, but fair enough.

Okay: H3

I didn't mention backslashes on purpose, as I'm not specifically interested in any kind of escape characters. I just would like to have a specific occurrence of H3 to not be hyperlinked: any mechanism to do so would be fine, be it an escape character, an escape sequence, an inline version of the literal block, or something else entirely like an emoji. :) Thanks!

Perfectly clear.

@epriestley, @chad, is the use-case in T5301#218589 clear enough?

This is also extremely silly, but I sometimes do it because I'm dumb and have muscle-memory for ⌘+1+⇥+⌘+V+⏎: searching for an object URL doesn't jump you to that object URL, but you probably meant to put it in the other box.

A related issue is that when you use {Fxxx} to embed an image as a thumbnail, we can fail with a default thumbnail if:

I think:

What's the status on this right now? Looks like a fun thing to try and get over the finish line.

This is probably the fix:

It looks like the existing test cases in master fail on PHP 7.1, presumably because of T10929, so that needs to be fixed before I can fix this.

This rule is constructed very awkwardly and I'd sort of prefer to remove it entirely, but I think we can technically fix this without really disrupting things.

We're happy to take a patch, too!

In T8845#214252, @SvHu wrote:

It's pretty big deal for us because we are using phriction to collect helpdesk FAQ. We have modified TOC to be displayed in the beginning of the page and would like to use ponder are storing questions. Atm using ponder links in phriction as headings also shows toc values as X.

Recent security issues in GitHub, GitLab, etc., with markdown:

If nothing's been typed in the text field for more than 5 seconds the user probably wants memes

How about "i" for "image"?

⇧ + ↓

I am also keeping an eye on https://www.reddit.com/r/bonehurtingjuice/. It's still a small meme but if it takes off we're all going to be drinking bone hurting juice this time next month.

just need to assign a trigger for the typeahead.....hmmmmmmmmm....

Also our meme format is very outdated, the new meme format is: