Page MenuHomePhabricator

Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]]
Closed, ResolvedPublic

Description

After D17647, I now have some broken phriction pages that were submitted before that change. I'm fine with the fact that this is done, but can I fix the pages? At the moment I get an exception and there is no edit button.

Phabricator version: acaa2e148f578dff279fc8b2614aaafe30026d72

Steps to reproduce: I can reproduce the same exception by trying to put something like the following in a new phriction document:

[[ http://good.com#u:p@evil.com/ | broken]]

The result is an exception page with no actions. My bug is subtly different. I have some pages that were valid before D17647. But now loading them, i.e., visit /w/was_a_valid_page, and I get the same exception, and no option to edit the page.

I suspect I could reproduce it by installing a version earlier than D17647 and inserting the above content into a page. But that is a bit beyond what I can do right now.

Event Timeline

Please read and follow Contributing Bug Reports, we don't accept incomplete bug reports.

Specifically we need steps to reproduce the issue. I don't know what "the pages" means, or where you expect an edit page to be found. We have lots of applications and fields that URIs could be in.

Ok sorry, I will improve the report.

I have added some more details. Let me know if you need any more.

jbeck renamed this task from Ambiguous URL rejection broke some pages to Ambiguous URL rejection broke some phriction pages.Jun 5 2017, 6:38 AM

Thanks for updating your report with reproduction instructions, they were very helpful in reproducing and fixing the bug.

After D18076, Phriction pages (and other remarkup blocks) with these ambiguous URIs should render again. The links themselves won't work, but they had ambiguous behavior in the first place.

This should land on HEAD of master a little later today. I'll also cherry-pick it to stable once it does.

epriestley renamed this task from Ambiguous URL rejection broke some phriction pages to Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .Jun 5 2017, 12:51 PM