Page MenuHomePhabricator
Feed Advanced Search

Jan 18 2017

epriestley added a revision to T5867: Move Quick Create to MenuItemEngine: Unknown Object (Differential Revision).
Jan 18 2017, 2:07 PM · Design
epriestley added a revision to T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED': Unknown Object (Differential Revision).
Jan 18 2017, 1:59 PM · Audit, Diffusion, Conduit, Bug Report
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

If you'd like us to look at it, please file a new issue following Contributing Bug Reports.

Jan 18 2017, 1:50 PM · Config, Bug Report
20after4 awarded T12101: Phabricator PHP 7 Compatibility a Mountain of Wealth token.
Jan 18 2017, 5:36 AM · Infrastructure, Guides

Jan 17 2017

epriestley added a revision to T5867: Move Quick Create to MenuItemEngine: Unknown Object (Differential Revision).
Jan 17 2017, 10:23 PM · Design
epriestley added a revision to T5867: Move Quick Create to MenuItemEngine: Unknown Object (Differential Revision).
Jan 17 2017, 10:01 PM · Design
epriestley added a revision to T5867: Move Quick Create to MenuItemEngine: Unknown Object (Differential Revision).
Jan 17 2017, 8:49 PM · Design
epriestley added a project to T12115: ApplicationTransactionPublishWorker can retry indefinitely, sending email as a side effect, if a transaction takes more than 2 hours to publish: Restricted Project.
Jan 17 2017, 8:08 PM · Restricted Project, Daemons, Differential, Transactions
epriestley created T12115: ApplicationTransactionPublishWorker can retry indefinitely, sending email as a side effect, if a transaction takes more than 2 hours to publish.
Jan 17 2017, 8:08 PM · Restricted Project, Daemons, Differential, Transactions
epriestley added a revision to T12113: Email in LDAP registration form is empty: Unknown Object (Differential Revision).
Jan 17 2017, 7:26 PM · Bug Report (Needs Information)
epriestley added a comment to T12113: Email in LDAP registration form is empty.

See also T3472.

Jan 17 2017, 6:58 PM · Bug Report (Needs Information)
epriestley closed T12113: Email in LDAP registration form is empty as Resolved.
Jan 17 2017, 6:54 PM · Bug Report (Needs Information)
epriestley removed a project from T12109: Updating revision reverts description changes, if you edit the description while `arc` is running: 🐳.
Jan 17 2017, 6:09 PM · Differential, Bug Report
epriestley added a comment to T12112: Upload file stalles network connections .

I can't reproduce this, so we can't move forward. Next steps:

Jan 17 2017, 6:08 PM · Bug Report (Needs Information)
epriestley added a comment to T12112: Upload file stalles network connections .

I can not reproduce this. Here's what I did:

Jan 17 2017, 6:04 PM · Bug Report (Needs Information)
epriestley closed T12114: Upside-down segment in task graph as Resolved by committing Restricted Diffusion Commit.
Jan 17 2017, 5:18 PM · Maniphest, Bug Report
epriestley closed T12111: Daemons keep failing but then I can't restart as Invalid.

Closing for lack of feedback.

Jan 17 2017, 4:45 PM · Bug Report (Needs Information)
epriestley added a revision to T12114: Upside-down segment in task graph: Unknown Object (Differential Revision).
Jan 17 2017, 4:40 PM · Maniphest, Bug Report
epriestley moved T11153: Provide better tools for preventing deadlocks in build plans which acquire multiple resources from Far Future to Backlog on the Drydock board.
Jan 17 2017, 3:29 PM · Restricted Project, Drydock, Harbormaster, Feature Request
epriestley added a comment to T12113: Email in LDAP registration form is empty.

So, is it possible that the email field is shown when there is already an existing phabricator account with the same email address?

Jan 17 2017, 3:27 PM · Bug Report (Needs Information)
epriestley added a comment to T12114: Upside-down segment in task graph.

I was able to reproduce this locally -- or something close enough, at least -- by recreating the simpler graph in T12114#207542, so I have enough to move forward.

Jan 17 2017, 3:26 PM · Maniphest, Bug Report
salvian awarded T12101: Phabricator PHP 7 Compatibility a Yellow Medal token.
Jan 17 2017, 9:35 AM · Infrastructure, Guides

Jan 16 2017

epriestley renamed T12109: Updating revision reverts description changes, if you edit the description while `arc` is running from Updating revision reverts description changes to Updating revision reverts description changes, if you edit the description while `arc` is running.
Jan 16 2017, 9:35 PM · Differential, Bug Report
epriestley added a comment to T12109: Updating revision reverts description changes, if you edit the description while `arc` is running.

Starting arc diff and then making changes probably races, although I think that's likely pre-existing. I can look at it when arc gets another update, but I think we can't really fix it on the server side.

Jan 16 2017, 9:35 PM · Differential, Bug Report
epriestley reassigned T12109: Updating revision reverts description changes, if you edit the description while `arc` is running from epriestley to chad.

Actually I can't reproduce this? I did this:

Jan 16 2017, 9:22 PM · Differential, Bug Report
mcsharma1990 awarded T12101: Phabricator PHP 7 Compatibility a Orange Medal token.
Jan 16 2017, 9:04 PM · Infrastructure, Guides
epriestley added a revision to T12107: Pick new icon for Phame: Unknown Object (Differential Revision).
Jan 16 2017, 6:51 PM · Phame, Design
epriestley closed T6660: Unsubmitted comments icon for Audits as Resolved by committing Restricted Diffusion Commit.
Jan 16 2017, 6:29 PM · Restricted Project, Audit
adamchainz awarded T12101: Phabricator PHP 7 Compatibility a Mountain of Wealth token.
Jan 16 2017, 6:26 PM · Infrastructure, Guides
epriestley edited projects for T12113: Email in LDAP registration form is empty, added: Bug Report (Needs Information); removed Bug Report.

I can't reproduce this issue with the information provided. To move forward:

Jan 16 2017, 5:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12113: Email in LDAP registration form is empty.

I can't reproduce this. Here's what I tried:

Jan 16 2017, 5:56 PM · Bug Report (Needs Information)
epriestley claimed T12109: Updating revision reverts description changes, if you edit the description while `arc` is running.

There was previously a shouldOverwriteWhenBlahBlah() method that probably didn't get transitioned forward cleanly.

Jan 16 2017, 4:56 PM · Differential, Bug Report
epriestley edited the content of Welcome.
Jan 16 2017, 4:53 PM
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.
  • I changed CIReleaseNotesDifferentialCustomField->shouldAppearInApplicationTransactions() to return true to make the web edit to work correctly. (Did you not want this field to be editable from the web?)
  • I changed CIReleaseNotesDifferentialCommitMessageCustomField::FIELDKEY to integrator:release-notes (the same value as CIReleaseNotesDifferentialCustomField::KEY_RELEASE_NOTES). Although this is not strictly required, it needs to be the same in some cases to bind the CommitMessage field to the Custom field, and making them the same makes several behaviors work correctly without additional changes.
  • I implemented CIReleaseNotesDifferentialCustomField->shouldAppearInConduitTransactions() to return true;.
  • I implemented CIReleaseNotesDifferentialCustomField->newConduitEditParameterType() to return new ConduitStringParameterType();.
Jan 16 2017, 4:50 PM · Bug Report
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

Alright, I'll take a more detailed look.

Jan 16 2017, 4:28 PM · Bug Report
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

@jcox, do you have 62cf4e6b95abbebc8ae2b1591039967651188c6e (D17207) yet? That might be the fix. Nothing jumps out at me as wrong, but I can take a closer look if that change doesn't help.

Jan 16 2017, 3:46 PM · Bug Report

Jan 15 2017

epriestley added a comment to T12107: Pick new icon for Phame.

no no those are for the Meterology application

Jan 15 2017, 9:00 PM · Phame, Design
epriestley added a comment to T12107: Pick new icon for Phame.

also conflicts with Phabricator Health Records Application

Jan 15 2017, 8:49 PM · Phame, Design
epriestley added a comment to T12107: Pick new icon for Phame.

Or use heart for favorites?

Jan 15 2017, 8:42 PM · Phame, Design

Jan 14 2017

epriestley added a revision to T6660: Unsubmitted comments icon for Audits: Unknown Object (Differential Revision).
Jan 14 2017, 5:30 PM · Restricted Project, Audit
epriestley closed T4343: Implement "arc audit" as Wontfix.

I'm going to close this since the original use case seems to have not panned out. We're still open to building this, but would like to see a modern use case driving it -- feel free to file a new request (or leave a comment here) if you have one.

Jan 14 2017, 5:05 PM · Audit, Diffusion
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

We probably would not use an option to turn the feature off (versus just supporting it) so don't worry about adding it on our behalf. At the point where I was set up to convincingly test that turning the feature off worked -- and we had navigated bundle2 in some way -- I'd probably be most of the way toward proper support anyway.

Jan 14 2017, 3:46 PM · Diffusion, Mercurial

Jan 13 2017

epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

It also occurs to me that Project profile menus already show up in a main menu dropdown on mobile, so we must have some PhabricatorActionView::newActionViewFromItemView(...) sort of code in there somewhere.

Jan 13 2017, 11:57 PM · Design
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

Sweet.

Jan 13 2017, 11:50 PM · Installing & Upgrading, Differential
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

Yes, if you aren't in edit mode. Here's normal mode (includes field):

Jan 13 2017, 11:46 PM · Installing & Upgrading, Differential
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

In particular, your code may just work as-is after updating. If not, compare them with those "MagicFlag" fields and/or let me know what you're still seeing?

Jan 13 2017, 11:33 PM · Installing & Upgrading, Differential
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

Alright, after D17207 I think these are analogous to what you're doing?

Jan 13 2017, 11:31 PM · Installing & Upgrading, Differential
epriestley added a revision to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages: Unknown Object (Differential Revision).
Jan 13 2017, 11:18 PM · Installing & Upgrading, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 13 2017, 11:18 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
joshuaspence awarded T12101: Phabricator PHP 7 Compatibility a Mountain of Wealth token.
Jan 13 2017, 10:51 PM · Infrastructure, Guides
epriestley edited the content of Changelog.
Jan 13 2017, 10:40 PM
epriestley renamed 2017 Week 2 (Mid January) from 2017 Week 02 (Mid January) to 2017 Week 2 (Mid January).
Jan 13 2017, 10:39 PM
epriestley created 2017 Week 2 (Mid January).
Jan 13 2017, 10:38 PM
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

please also add "close menu" and a label that says "menu items" and help text that says "click an item to activate it"

Jan 13 2017, 9:39 PM · Design
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

Yeah, I'm not aware of any real difference between them or good reason to have both. Maybe I'm forgetting something but I'm pretty sure we can merge them eventually.

Jan 13 2017, 8:06 PM · Design
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

I think there are two approaches:

Jan 13 2017, 8:00 PM · Design
epriestley closed T12105: Put shards 13-16 into production in the Phacility cluster as Resolved.

These are now in production. I inched some other automation forward but no major changes.

Jan 13 2017, 7:29 PM · Phacility, Ops
epriestley added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

They are not related. That search uses fulltext indexes (see T11922 / T11741 for recent discussion), not ngram indexes.

Jan 13 2017, 5:50 PM · Owners, Files, ApplicationSearch
epriestley edited the content of Phacility Cluster Devices.
Jan 13 2017, 5:15 PM
epriestley created T12105: Put shards 13-16 into production in the Phacility cluster.
Jan 13 2017, 5:15 PM · Phacility, Ops
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

uhoh

Jan 13 2017, 5:05 PM · Installing & Upgrading, Differential
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

Hour or two if nothing's on fire -- probably today, just later this evening.

Jan 13 2017, 5:04 PM · Installing & Upgrading, Differential
epriestley closed T12095: Differential reads and writes draft status to different tables, leading to various UI inconsistencies as Resolved by committing Restricted Diffusion Commit.
Jan 13 2017, 5:02 PM · Differential, Bug Report
epriestley added a comment to T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.

@jmeador, I think I have a fix for your use case but it touches enough stuff that I'm going to hold it until after release promotion. Your use case is a bit unusual but should be possible to support.

Jan 13 2017, 5:01 PM · Installing & Upgrading, Differential
epriestley created T12104: Clean up remnants of old Differential draft storage.
Jan 13 2017, 3:45 PM · Infrastructure, Differential
epriestley added a revision to T6660: Unsubmitted comments icon for Audits: Unknown Object (Differential Revision).
Jan 13 2017, 3:37 PM · Restricted Project, Audit
epriestley added a revision to T12095: Differential reads and writes draft status to different tables, leading to various UI inconsistencies: Unknown Object (Differential Revision).
Jan 13 2017, 3:37 PM · Differential, Bug Report
pouyana awarded T12101: Phabricator PHP 7 Compatibility a Mountain of Wealth token.
Jan 13 2017, 3:10 PM · Infrastructure, Guides
epriestley added a revision to T12098: Create Revision from FavoritesMenuItem doesn't work: Unknown Object (Differential Revision).
Jan 13 2017, 2:21 PM · Dashboards, Differential
skibbipl awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 13 2017, 12:09 PM · Prioritized, Restricted Project, Infrastructure
cmmata awarded T9640: Make Phabricator compatible with PHP7 a 100 token.
Jan 13 2017, 10:16 AM · Prioritized, Restricted Project, Infrastructure
Zolli awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jan 13 2017, 6:03 AM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T12081: "Unable to establish a connection to any database host" via ssh git push.

(I no longer need access to the server.)

Jan 13 2017, 1:48 AM · Bug Report (Needs Information)
epriestley closed T12081: "Unable to establish a connection to any database host" via ssh git push as Invalid.

Having run the scripts on a new server the only thing I can think of is the fact that the scripts change #!/usr/bin/env php to #!/usr/bin/env php5.6

Jan 13 2017, 1:46 AM · Bug Report (Needs Information)
epriestley added a revision to T9482: Problems in the "Commits in this Package that Need Attention" view: Unknown Object (Differential Revision).
Jan 13 2017, 12:33 AM · Restricted Project, Restricted Project, Audit
chad awarded T12101: Phabricator PHP 7 Compatibility a Doubloon token.
Jan 13 2017, 12:17 AM · Infrastructure, Guides
epriestley closed T9640: Make Phabricator compatible with PHP7 as Resolved.

This was prioritized privately and PHP7 is now supported. Not sure I got everything, but I'm on PHP7 locally now so presumably I'll hit any remaining issues before too long. T12101 is the new informational task. We will now accept bug reports against PHP7. The documentation should regenerate within a day or so. These changes will promote to stable in about 24 hours.

Jan 13 2017, 12:16 AM · Prioritized, Restricted Project, Infrastructure
epriestley closed T9640: Make Phabricator compatible with PHP7, a subtask of T10987: /config/issue/ causes coredump in PHP-FPM, as Resolved.
Jan 13 2017, 12:16 AM · Bug Report
epriestley changed the destination URL U28 PHP7 from https://secure.phabricator.com/T9640 to https://secure.phabricator.com/T12101.
Jan 13 2017, 12:13 AM
epriestley added projects to T12101: Phabricator PHP 7 Compatibility: Guides, Infrastructure.
Jan 13 2017, 12:13 AM · Infrastructure, Guides
epriestley created T12101: Phabricator PHP 7 Compatibility.
Jan 13 2017, 12:13 AM · Infrastructure, Guides
epriestley renamed T9640: Make Phabricator compatible with PHP7 from Phabricator PHP 7 Compatibility to Make Phabricator compatible with PHP7.
Jan 13 2017, 12:08 AM · Prioritized, Restricted Project, Infrastructure

Jan 12 2017

epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:55 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:53 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:53 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:44 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:43 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:41 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T9640: Make Phabricator compatible with PHP7: Unknown Object (Differential Revision).
Jan 12 2017, 11:39 PM · Prioritized, Restricted Project, Infrastructure
epriestley claimed T9640: Make Phabricator compatible with PHP7.
Jan 12 2017, 10:12 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T12100: Consider removing "maximum-scale" from "viewport" tag.

There are at least some nontrivial effects, like searching for text without "maximum-scale" can imply a zoom:

Jan 12 2017, 10:11 PM · Mobile
epriestley renamed T12100: Consider removing "maximum-scale" from "viewport" tag from Don't prevent zooming on phones to Consider removing "maximum-scale" from "viewport" tag.
Jan 12 2017, 10:07 PM · Mobile
epriestley added a comment to T12100: Consider removing "maximum-scale" from "viewport" tag.

Oh, sorry, you just wanted maximum-scale removed.

Jan 12 2017, 10:01 PM · Mobile
epriestley added a comment to T12100: Consider removing "maximum-scale" from "viewport" tag.

Here are some screenshots of Phabricator with this tag removed, as you suggest:

Jan 12 2017, 9:58 PM · Mobile
epriestley closed T9482: Problems in the "Commits in this Package that Need Attention" view as Resolved by committing Restricted Diffusion Commit.
Jan 12 2017, 9:41 PM · Restricted Project, Restricted Project, Audit
epriestley closed T9482: Problems in the "Commits in this Package that Need Attention" view, a subtask of T9279: Sort commit history chronologically, as Resolved.
Jan 12 2017, 9:41 PM · Audit, Restricted Project
epriestley closed T7076: Show status of linked revisions for tasks as Resolved by committing Restricted Diffusion Commit.
Jan 12 2017, 9:23 PM · Restricted Project, Differential, Maniphest
epriestley closed T12100: Consider removing "maximum-scale" from "viewport" tag as Invalid.

As you might already have guessed, this isn't a bug.

Jan 12 2017, 9:22 PM · Mobile
epriestley added a comment to T12032: Make sure Chrome 55 anchor issue does not impact Differential.

Chrome 56 has merged a fix for this so it should be moot in the not-too-distant future, although I'm not exactly sure what the Chrome release schedule looks like. If this only impacts ghost inlines for a few more weeks it's pretty tempting to just wait for it to resolve itself, but I may be digging around in that code soon so perhaps I'll take a more detailed look.

Jan 12 2017, 9:06 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley added a revision to T9482: Problems in the "Commits in this Package that Need Attention" view: Unknown Object (Differential Revision).
Jan 12 2017, 8:59 PM · Restricted Project, Restricted Project, Audit