Page MenuHomePhabricator
Feed Advanced Search

Sep 9 2016

epriestley closed T11607: Put inline styles on `{key ...}` for email as Resolved by committing Restricted Diffusion Commit.
Sep 9 2016, 12:11 AM · Remarkup

Sep 8 2016

epriestley added a revision to T11607: Put inline styles on `{key ...}` for email: Restricted Differential Revision.
Sep 8 2016, 11:39 PM · Remarkup
avivey added a comment to T11609: Don't resize small pictures in Remarkup.

oh, wow, the preview already handles tiny pictures differently...

Sep 8 2016, 10:49 PM · Remarkup
avivey created T11609: Don't resize small pictures in Remarkup.
Sep 8 2016, 10:44 PM · Remarkup
epriestley created T11607: Put inline styles on `{key ...}` for email.
Sep 8 2016, 8:51 PM · Remarkup

Sep 2 2016

epriestley closed T11542: Make remarkup checklists interactive as Invalid.

See Contributing Feature Requests and Describing Root Problems. The context and discussion in T3945 and T9652 may be helpful in formulating a problem description.

Sep 2 2016, 10:25 PM · Remarkup, Feature Request

Aug 31 2016

chad triaged T11542: Make remarkup checklists interactive as Wishlist priority.
Aug 31 2016, 6:21 PM · Remarkup, Feature Request

Aug 27 2016

20after4 added a comment to T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment.

This would be awesome.

Aug 27 2016, 2:21 AM · Restricted Project, Remarkup, Feature Request

Aug 26 2016

epriestley renamed T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment from Remarkup autocomplete for tasks to Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment.
Aug 26 2016, 11:02 PM · Restricted Project, Remarkup, Feature Request
epriestley merged task T7138: Remarkup should have an "Link Wiki page" button with typeahead into T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment.
Aug 26 2016, 11:00 PM · Remarkup
avivey added a project to T11389: Object links merged in plain text email: Remarkup.
Aug 26 2016, 8:50 PM · Remarkup, Bug Report, Mail

Aug 25 2016

epriestley added a comment to T4190: Rebuild remarkup image proxying.

I've also never used seamless so I'm not sure how support looks in practice, but this isn't immediately reassuring:

Aug 25 2016, 5:00 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.

I think that only prevents referrer leaking -- it doesn't deal with the other issues in T4190#60441 (or request amplification attacks), right?

Aug 25 2016, 4:58 PM · Contributor Onboarding, Remarkup
eadler added a comment to T4190: Rebuild remarkup image proxying.

Can we avoid the need for this entirely using the approach outlined in T11126 (using CSP or <iframe seamless referrerpolicy="no-referrer">)?

Aug 25 2016, 4:57 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.

The vaguely related T5378 is also in the queue somewhere. It may not really intersect with this, but if we do end up trying to auto-embed any URI that ends in .jpg again it probably will. I'm not sure we should, but just a heads up for context.

Aug 25 2016, 4:29 PM · Contributor Onboarding, Remarkup
epriestley moved T4190: Rebuild remarkup image proxying from Backlog to Intermediate on the Contributor Onboarding board.
Aug 25 2016, 4:25 PM · Contributor Onboarding, Remarkup
epriestley reassigned T4190: Rebuild remarkup image proxying from epriestley to jcox.

The general shape of what we're trying to do here is that when a user writes the URL of an image in a comment (e.g., http://funny.lol/silly-dog.jpg, perhaps with some magic *$!symbols$*!) it would be nice to just show the image. Today, they'd have to download and re-upload it, which is somewhat cumbersome.

Aug 25 2016, 4:25 PM · Contributor Onboarding, Remarkup
epriestley added a project to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Contributor Onboarding.
Aug 25 2016, 3:30 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia

Aug 23 2016

epriestley closed T4485: Try to guess when a user copy/pastes a giant block of output from something? as Wontfix.

I haven't come up with any kind of rule for this in the last couple years which feels sufficiently un-magical, even in theory. It hasn't happened all that often recently, either, at least that I can recall.

Aug 23 2016, 7:11 PM · Remarkup
epriestley added a project to T4190: Rebuild remarkup image proxying: Contributor Onboarding.
Aug 23 2016, 6:53 PM · Contributor Onboarding, Remarkup

Aug 22 2016

epriestley moved T9900: Figlet does not properly render apostrophes with some characters from Backlog to Intermediate on the Contributor Onboarding board.
Aug 22 2016, 8:07 PM · Contributor Onboarding, Remarkup
epriestley assigned T9900: Figlet does not properly render apostrophes with some characters to jcox.

PhabricatorRemarkupFigletBlockInterpreter is a remarkup rule for rendering figlet fonts, invoked like this:

Aug 22 2016, 8:07 PM · Contributor Onboarding, Remarkup
epriestley added a project to T9854: Support date/time reformatting in Remarkup: Contributor Onboarding.
Aug 22 2016, 6:23 PM · Contributor Onboarding, Restricted Project, Remarkup
epriestley added a project to T9900: Figlet does not properly render apostrophes with some characters: Contributor Onboarding.
Aug 22 2016, 6:21 PM · Contributor Onboarding, Remarkup

Aug 18 2016

epriestley added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

(I believe we already show any changes that pressing the submit button will make to subscribers accurately in the preview. This wasn't always true prior to EditEngine and I think the preview/actual effect would sometimes disagree in weird cases, but I believe the preview is now always fully accurate. However, it's quite easy to miss.)

Aug 18 2016, 9:51 PM · Remarkup, Bug Report
chad added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

When a user writes a Maniphest comment, I think fully and correctly populating the "Change Subscribers" field, including its new/upcoming additions, would be a good and unobjectionable feature. This would allow the currently unconditional additions to be removed manually prior to form submission. This would still be tedious, but at least I could make a comment without having to either mangle the quote or go back after commenting to perform a separate manual action unsubscribing the user that I didn't intend to add.

Aug 18 2016, 3:18 PM · Remarkup, Bug Report
MZMcBride added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

If you don't like the @mention-implies-CC behavior, you can disable it by applying this patch to your install:

[...]

Aug 18 2016, 2:20 PM · Remarkup, Bug Report
nemobis added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

If you don't like the @mention-implies-CC behavior

Aug 18 2016, 12:07 PM · Remarkup, Bug Report
chad closed T11491: Preview of remarkup with a checkbox doesn't render properly as Resolved by committing Restricted Diffusion Commit.
Aug 18 2016, 1:23 AM · Remarkup, Bug Report

Aug 17 2016

chad added a revision to T11491: Preview of remarkup with a checkbox doesn't render properly: Restricted Differential Revision.
Aug 17 2016, 9:58 PM · Remarkup, Bug Report
chad added a comment to T11491: Preview of remarkup with a checkbox doesn't render properly.

.aphront-form-input input is to blame.

Aug 17 2016, 9:47 PM · Remarkup, Bug Report
cspeckmim created T11491: Preview of remarkup with a checkbox doesn't render properly.
Aug 17 2016, 9:34 PM · Remarkup, Bug Report

Aug 14 2016

epriestley added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

If you don't like the @mention-implies-CC behavior, you can disable it by applying this patch to your install:

Aug 14 2016, 12:38 PM · Remarkup, Bug Report
MZMcBride added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.
In T11471#190079, @chad wrote:

I don't consider this to be a bug and any fix would likely lead to additional user confusion over "magic".

Aug 14 2016, 12:21 PM · Remarkup, Bug Report
epriestley added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

I also don't necessarily consider this a bug (I think a human explicitly @mention-ing a user definitely should add them again, and that quoting someone is pretty close to mentioning them, and that reasonable users could probably expect either behavior, and perhaps that the "add them again" behavior is more obvious or more expected) but T11035 discusses this and some other behaviors which have varying amounts of grey area.

Aug 14 2016, 11:56 AM · Remarkup, Bug Report
epriestley closed T11474: Incorrect rendering of links with adjanced text as Invalid.

The use case in that linked task is "using Remarkup to demonstrate the behavior of a different markup language", which isn't something we expect Remarkup to support.

Aug 14 2016, 11:46 AM · Remarkup, Bug Report
Danny_B added a comment to T11474: Incorrect rendering of links with adjanced text.

The example is pretty descriptive, I'd say. Because of linking to the description of that exact part of the word.

Aug 14 2016, 11:44 AM · Remarkup, Bug Report
epriestley added a comment to T11474: Incorrect rendering of links with adjanced text.

Why do you want to link part of a word?

Aug 14 2016, 11:31 AM · Remarkup, Bug Report
Danny_B created T11474: Incorrect rendering of links with adjanced text.
Aug 14 2016, 11:28 AM · Remarkup, Bug Report
epriestley merged T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks into T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
Aug 14 2016, 2:33 AM · Prioritized, Wikimedia, Remarkup
epriestley merged task T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks into T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
Aug 14 2016, 2:33 AM · Remarkup, Bug Report

Aug 13 2016

chad added a project to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks: Remarkup.
Aug 13 2016, 11:54 PM · Remarkup, Bug Report

Aug 8 2016

epriestley closed T7783: phriction diffs don't default to remarkup as Wontfix.

These use the prose algorithm now, and I don't plan to try to implement syntax highlighting for prose diffs.

Aug 8 2016, 4:36 PM · Remarkup, Phriction

Aug 7 2016

eadler added a project to T6609: Support math (LaTeX) equation in Remarkup: Restricted Project.
Aug 7 2016, 8:12 PM · Restricted Project, Remarkup
eadler added a project to T11126: Allow embedding XKCD panes in Remarkup: Restricted Project.
Aug 7 2016, 7:59 PM · Restricted Project, User Delight, Remarkup, Feature Request

Aug 5 2016

eadler added a project to T8430: Support emoticons: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Remarkup
eadler added a project to T8200: Upload File explanation dialog displays behind fullscreen editor: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Remarkup, Files
eadler added a project to T9854: Support date/time reformatting in Remarkup: Restricted Project.
Aug 5 2016, 5:24 PM · Contributor Onboarding, Restricted Project, Remarkup
chad added a parent task for T7783: phriction diffs don't default to remarkup: T9379: Build Phriction v3.
Aug 5 2016, 1:48 AM · Remarkup, Phriction

Jul 26 2016

epriestley merged T11374: Phriction TOC not rendering headings correctly into T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki.
Jul 26 2016, 2:09 PM · libphutil, Remarkup
epriestley renamed T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki from Headings matching M\d+ seem to become an `x` in Table of Contents on Wiki to Headings which resolve with markup become an `X` in Table of Contents on Wiki.
Jul 26 2016, 2:09 PM · libphutil, Remarkup
epriestley merged T11376: Provide a way to have lists in tables into T10354: Remarkup block elements may not contain other block elements (like lists and tables inside tables).
Jul 26 2016, 1:55 PM · Feature Request, Remarkup
epriestley merged task T11376: Provide a way to have lists in tables into T10354: Remarkup block elements may not contain other block elements (like lists and tables inside tables).
Jul 26 2016, 1:55 PM · Remarkup, Feature Request
Danny_B created T11376: Provide a way to have lists in tables.
Jul 26 2016, 1:53 PM · Remarkup, Feature Request
isiahmeadows added a comment to T4939: Block level items in lists in remarkup.

This would be very useful for things like blocks of code. If you're suggesting a few options for a certain bit of code, or using a list to explain changes to multiple interfaces (code is much more concise than prose), nested code blocks would be very useful.

Jul 26 2016, 9:48 AM · Remarkup

Jul 12 2016

avivey moved T5698: Github-style Remarkup previews on a checked-in resource from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 12 2016, 9:55 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup

Jul 11 2016

Krinkle added a comment to T11284: Allow line breaks in list items.
In T11284#184462, @chad wrote:

Can you give an example of what specifically you are trying to build in Phabricator?

Jul 11 2016, 11:35 PM · Remarkup

Jul 10 2016

chad renamed T8200: Upload File explanation dialog displays behind fullscreen editor from Upload File explanation dialog on descriptions/comments is broken in fullscreen remarkup editor to Upload File explanation dialog displays behind fullscreen editor.
Jul 10 2016, 3:25 AM · Restricted Project, Remarkup, Files

Jul 8 2016

chad edited projects for T11229: Quotes breaks headings by default, added: Remarkup; removed Maniphest.
Jul 8 2016, 4:12 PM · Remarkup, Bug Report

Jul 7 2016

dtf added a comment to T11284: Allow line breaks in list items.

Maybe something like long lists with "titles" or "summaries" for list elements?

# Something top-level
  Long, multi-sentence description of this top-level list item.
 - Sub-element with "title" <br/>
   Long, multi-sentence description of this inner list item.
 - **Another sub-element, highlighted even** <br/>
   Another long description.
   Very long and very descriptive. 
# Something else

which renders like:

1. Something top-level
   Long, multi-sentence description of this top-level list item.
Jul 7 2016, 9:03 AM · Remarkup
dtf added a comment to T11284: Allow line breaks in list items.
Jul 7 2016, 9:01 AM · Remarkup
epriestley moved T6299: Remarkup links to objects in Phame break if a CNAME is set from Backlog to Future on the Phame board.
Jul 7 2016, 1:40 AM · Haskell.org, Remarkup, Phame
epriestley removed a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Jul 7 2016, 1:40 AM · Haskell.org, Remarkup, Phame
chad added a comment to T11284: Allow line breaks in list items.

Cursory research yields Markdown uses two spaces to indicate a <br />.

Jul 7 2016, 12:04 AM · Remarkup

Jul 6 2016

chad added a comment to T11284: Allow line breaks in list items.

Can you give an example of what specifically you are trying to build in Phabricator?

Jul 6 2016, 10:12 PM · Remarkup
Krinkle updated the task description for T11284: Allow line breaks in list items.
Jul 6 2016, 9:42 PM · Remarkup
Krinkle created T11284: Allow line breaks in list items.
Jul 6 2016, 9:33 PM · Remarkup

Jul 3 2016

epriestley added a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Jul 3 2016, 9:00 AM · Haskell.org, Remarkup, Phame
epriestley removed a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Jul 3 2016, 9:00 AM · Haskell.org, Remarkup, Phame

Jul 2 2016

epriestley moved T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks from The Queue to Paused on the Prioritized board.
Jul 2 2016, 7:11 PM · Prioritized, Wikimedia, Remarkup

Jul 1 2016

chad added a comment to T11253: Make it possible to paste images.

oh man, I even filed it.

Jul 1 2016, 7:28 PM · Restricted Project, Remarkup, Pholio, Feature Request
epriestley merged task T11253: Make it possible to paste images into T7916: Can't paste images from clipboard in Firefox / Safari.
Jul 1 2016, 7:19 PM · Restricted Project, Remarkup, Pholio, Feature Request
chad added a comment to T11253: Make it possible to paste images.

Any particular system this doesn't work on?

Jul 1 2016, 7:11 PM · Restricted Project, Remarkup, Pholio, Feature Request
chad added a comment to T11253: Make it possible to paste images.

News to me that we don't support it.

Jul 1 2016, 7:08 PM · Restricted Project, Remarkup, Pholio, Feature Request
eadler added a project to T11253: Make it possible to paste images: Restricted Project.
Jul 1 2016, 7:04 PM · Restricted Project, Remarkup, Pholio, Feature Request
eadler created T11253: Make it possible to paste images.
Jul 1 2016, 7:04 PM · Restricted Project, Remarkup, Pholio, Feature Request
eadler added a project to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Restricted Project.
Jul 1 2016, 6:59 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia

Jun 28 2016

epriestley added a comment to T11228: Please add hr rule to Remarkup Documentation.

Docs regenerate on a cron so this won't actually show up live until sometime tonight, but D16186 has a screenshot.

Jun 28 2016, 10:04 PM · Documentation, Remarkup, Feature Request
epriestley closed T11228: Please add hr rule to Remarkup Documentation as Resolved by committing Restricted Diffusion Commit.
Jun 28 2016, 9:57 PM · Documentation, Remarkup, Feature Request
epriestley added a revision to T11228: Please add hr rule to Remarkup Documentation: Restricted Differential Revision.
Jun 28 2016, 9:33 PM · Documentation, Remarkup, Feature Request
chad added a project to T11228: Please add hr rule to Remarkup Documentation: Documentation.
Jun 28 2016, 9:29 PM · Documentation, Remarkup, Feature Request
chad added a comment to T10110: Floating images in Phriction can make everything else afterwards float... forever.

Filed as T11228

Jun 28 2016, 9:26 PM · Remarkup, Bug Report
chad created T11228: Please add hr rule to Remarkup Documentation.
Jun 28 2016, 9:26 PM · Documentation, Remarkup, Feature Request
robertkraig added a comment to T10110: Floating images in Phriction can make everything else afterwards float... forever.

Please add the triple dash to the documentation page, I couldn't find it clicking on the main life-saver icon link.

Jun 28 2016, 9:21 PM · Remarkup, Bug Report
chad renamed T3975: Add the ability to show Google Docs in Remarkup from Add the ability to show Google Docs on Phriction pages to Add the ability to show Google Docs in Remarkup.
Jun 28 2016, 7:03 PM · Remarkup
chad edited projects for T3975: Add the ability to show Google Docs in Remarkup, added: Remarkup; removed Phriction.
Jun 28 2016, 7:02 PM · Remarkup
chad removed a project from T5567: Add custom charts to a page: Phriction.
Jun 28 2016, 7:02 PM · Remarkup
chad removed a project from T5427: Force a line break in a table cell: Phriction.
Jun 28 2016, 7:02 PM · Remarkup

Jun 27 2016

epriestley added a comment to T6299: Remarkup links to objects in Phame break if a CNAME is set.

In live comments, these links are bad offhand:

Jun 27 2016, 3:52 PM · Haskell.org, Remarkup, Phame
epriestley added a comment to T6299: Remarkup links to objects in Phame break if a CNAME is set.
  • The stuff above should be better now, but I'm not sure if I got everything. We should run through that list again.
  • The "Subscribers" and "Projects" links here do not link to the correct domain, and fixing them isn't trivial because they're event-driven extensions:
Jun 27 2016, 3:43 PM · Haskell.org, Remarkup, Phame

Jun 25 2016

epriestley closed T11189: Add more Markdown Italics support to Remarkup as Wontfix.

I'm not completely opposed to ever changing this, but I think there are pretty good reasons for the current behavior.

Jun 25 2016, 2:23 PM · Remarkup, Feature Request

Jun 24 2016

avivey added a comment to T11209: JIRA links with really long names overflow in Revision Details view.

happycat

Jun 24 2016, 8:41 PM · Remarkup, Doorkeeper, Restricted Project, Bug Report, Restricted Project, Differential
chad closed T11209: JIRA links with really long names overflow in Revision Details view as Resolved by committing Restricted Diffusion Commit.
Jun 24 2016, 8:41 PM · Remarkup, Doorkeeper, Restricted Project, Bug Report, Restricted Project, Differential
chad added a revision to T11209: JIRA links with really long names overflow in Revision Details view: Restricted Differential Revision.
Jun 24 2016, 7:10 PM · Remarkup, Doorkeeper, Restricted Project, Bug Report, Restricted Project, Differential
avivey added a comment to T11209: JIRA links with really long names overflow in Revision Details view.

I think it starts out as a URL, and then replaced on the client-side with the name after some AJAX. Most of the time I don't have time to see the "before" text.

Jun 24 2016, 7:05 PM · Remarkup, Doorkeeper, Restricted Project, Bug Report, Restricted Project, Differential
chad added a comment to T11209: JIRA links with really long names overflow in Revision Details view.

I don't understand why it's a tag. Does the JIRA link look like a URL or an actual name?

Jun 24 2016, 7:03 PM · Remarkup, Doorkeeper, Restricted Project, Bug Report, Restricted Project, Differential
avivey added a comment to T11209: JIRA links with really long names overflow in Revision Details view.

css is it's own world of magick.

Jun 24 2016, 7:02 PM · Remarkup, Doorkeeper, Restricted Project, Bug Report, Restricted Project, Differential
chad added a comment to T11209: JIRA links with really long names overflow in Revision Details view.

I'm faking my way through it.

Jun 24 2016, 7:02 PM · Remarkup, Doorkeeper, Restricted Project, Bug Report, Restricted Project, Differential
avivey added a comment to T11209: JIRA links with really long names overflow in Revision Details view.

Here's Chrome's Style page for the element:

pasted_file (990×464 px, 101 KB)

Jun 24 2016, 7:00 PM · Remarkup, Doorkeeper, Restricted Project, Bug Report, Restricted Project, Differential
chad added a comment to T11209: JIRA links with really long names overflow in Revision Details view.

I'm just surprised to hear something is still overflowing after D16081.

Jun 24 2016, 6:53 PM · Remarkup, Doorkeeper, Restricted Project, Bug Report, Restricted Project, Differential