Page MenuHomePhabricator
Feed All Stories

Jun 4 2019

epriestley merged task T10307: Option to move child pages when parent in renamed into T6004: When moving a wiki page with subpages prompt to also move subpages.
Jun 4 2019, 8:01 PM · Feature Request, Phriction
epriestley added a comment to T6004: When moving a wiki page with subpages prompt to also move subpages.

See also PHI1275. Now that Phriction supports relative references in [[ ... ]] syntax, moves should be able to modify those references.

Jun 4 2019, 7:46 PM · Phriction
epriestley added 1 mock(s) for T13289: Plans: 2019 Week 21-23 Bonus Content: M1479: Meow Meow.
Jun 4 2019, 7:38 PM · Plans
epriestley added 1 task(s) for M1479: Meow Meow: T13289: Plans: 2019 Week 21-23 Bonus Content.
Jun 4 2019, 7:38 PM
epriestley added a comment to T13289: Plans: 2019 Week 21-23 Bonus Content.

  • Jun 4 2019, 7:37 PM · Plans
    epriestley updated images of M1479: Meow Meow.
    Jun 4 2019, 7:36 PM
    epriestley added a revision to T13160: Support <colgroup> in the verbose remarkup <table> syntax for specifying column widths: Unknown Object (Differential Revision).
    Jun 4 2019, 4:32 PM · Remarkup
    epriestley closed T13300: When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote as Resolved by committing Restricted Diffusion Commit.
    Jun 4 2019, 1:56 PM · Diffusion, Differential

    May 31 2019

    epriestley added a revision to T13298: Improve Herald profiling information available in transcripts: Unknown Object (Differential Revision).
    May 31 2019, 2:59 PM · Herald
    epriestley added a revision to T13298: Improve Herald profiling information available in transcripts: Unknown Object (Differential Revision).
    May 31 2019, 2:33 PM · Herald
    epriestley added a revision to T13300: When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote: Unknown Object (Differential Revision).
    May 31 2019, 1:18 PM · Diffusion, Differential

    May 30 2019

    epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
    May 30 2019, 11:48 PM · Plans
    epriestley added a comment to T13297: "vi" and "vim" may exit with errors even though edits succeed.

    I'm just going to close this in the hope it fades quietly into the night now that it has been "fixed".

    May 30 2019, 11:47 PM · Arcanist
    epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

    D20563 probably fixes mail. I don't think (?) it will fix notifications but haven't hunted that down yet.

    May 30 2019, 11:15 PM · Transactions
    epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: Unknown Object (Differential Revision).
    May 30 2019, 10:37 PM · Transactions
    epriestley updated the task description for T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
    May 30 2019, 7:10 PM · Quicksand
    epriestley renamed T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes from There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changs to There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
    May 30 2019, 7:09 PM · Transactions
    epriestley created T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
    May 30 2019, 7:09 PM · Transactions
    epriestley added a comment to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

    This likely affects other similar dialogs. The fix is to duct-tape something in Quicksand to something in the "click an area to click a link" behavior, most likely.

    May 30 2019, 7:07 PM · Quicksand
    epriestley created T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
    May 30 2019, 7:05 PM · Quicksand
    asherkin added a comment to T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled.

    The changelog for PHP 7.3.6 mentions "Fixed possible crashes, because of inconsistent PCRE cache and opcache SHM reset." which might be relevant, but no bug link so who knows.

    May 30 2019, 6:52 PM · Infrastructure
    epriestley created T13301: Browser "Find..." feature isn't very useful in Safari on Workboards.
    May 30 2019, 3:29 PM · Workboards

    May 28 2019

    epriestley edited the content of Changelog.
    May 28 2019, 5:29 PM
    epriestley created an object: 2019 Week 21 (Very Late May).
    May 28 2019, 5:27 PM
    epriestley triaged T13300: When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote as Low priority.
    May 28 2019, 5:22 PM · Diffusion, Differential
    epriestley created T13300: When a "Draft" revision is closed into "Published" (not "Abandoned"), it should immediately promote.
    May 28 2019, 5:22 PM · Diffusion, Differential
    epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: Unknown Object (Differential Revision).
    May 28 2019, 5:14 PM · Plans

    May 27 2019

    epriestley moved T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Far Future to Next on the Herald board.
    May 27 2019, 3:36 PM · Diffusion, Herald
    epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

    A sort of broad issue here is that Herald sometimes knows (or could know, or could guess, or maybe could speculate) that a rule won't do what you expect, but it doesn't tell you.

    May 27 2019, 3:36 PM · Diffusion, Herald
    epriestley triaged T13299: Herald only triggers for commits once, during the initial publish phase as Normal priority.
    May 27 2019, 3:34 PM · Diffusion, Herald
    epriestley closed T13283: When Herald acts, include the transaction group as part of the "state" it acts upon as Resolved.

    I think this is about as good as we're going to get, and we've only taken a very small step toward the precipice of a self-aware Herald that hates humankind.

    May 27 2019, 2:56 PM · Herald
    epriestley triaged T13298: Improve Herald profiling information available in transcripts as Normal priority.
    May 27 2019, 2:54 PM · Herald
    epriestley closed T12257: Add an "author email" field to the "Differential Diff" Herald rule as Wontfix.

    KDE appears to be moving to GitLab (see: https://gitlab.com/gitlab-org/gitlab-ce/issues/53206) and we haven't seen this request from other installs, so I'm just going to close this out.

    May 27 2019, 2:38 PM · KDE, Herald, Differential
    epriestley closed T8804: Replacing a Herald rule with a Doorkeeper extension as Wontfix.

    I think the modern answer here is "use Webhooks". They may not do everything you want if you're writing a chat bot (notably, they intentionally do not currently provide a human-readable text representation of transactions) but there generally suitable for publishing changes to Phabricator objects into a remote system and will produce a program with generally reasonable behaviors and no weird demons lurking under the surface.

    May 27 2019, 2:30 PM · Restricted Project, Herald, Doorkeeper

    May 24 2019

    epriestley added a comment to T13297: "vi" and "vim" may exit with errors even though edits succeed.

    Here's a more concise test:

    May 24 2019, 9:10 PM · Arcanist
    avivey added a comment to T13297: "vi" and "vim" may exit with errors even though edits succeed.

    Running the thing on my ubuntu exists with 0...

    $ vi --version
    VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 10 2018 21:31:58)
    Included patches: 1-1453
    .....
    .....
    Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -Wdate-time  -g -O2 -fdebug-prefix-map=/build/vim-NQEcoP/vim-8.0.1453=. -fstack-protector-strong -Wformat -Werror=format-security -DTINY_VIMRC -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
    Linking: gcc   -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim    -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo  -lselinux -lacl -lattr -ldl
    May 24 2019, 9:04 PM · Arcanist
    epriestley triaged T13297: "vi" and "vim" may exit with errors even though edits succeed as Low priority.
    May 24 2019, 8:15 PM · Arcanist
    trevorsummerssmith awarded T6004: When moving a wiki page with subpages prompt to also move subpages a Like token.
    May 24 2019, 1:54 PM · Phriction
    thuffir added a comment to T4752: Daemons may not have permission to remove files from local disk storage engine.

    setfacl -Rdm u:phab-phd:rw /var/local/phabricator/filestore
    setfacl -Rm u:phab-phd:rw /var/local/phabricator/filestore

    May 24 2019, 9:21 AM · Files

    May 23 2019

    epriestley lowered the priority of T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled from Normal to Low.
    May 23 2019, 11:54 PM · Infrastructure
    epriestley added a comment to T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled.

    I built my PHP from source in T13232 so this is presumably not a Homebrew issue.

    May 23 2019, 11:49 PM · Infrastructure
    epriestley updated the task description for T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled.
    May 23 2019, 11:42 PM · Infrastructure
    epriestley added a revision to T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled: Unknown Object (Differential Revision).
    May 23 2019, 11:36 PM · Infrastructure
    epriestley triaged T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled as Normal priority.
    May 23 2019, 11:29 PM · Infrastructure
    epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
    May 23 2019, 7:03 PM · Plans
    epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: Unknown Object (Differential Revision).
    May 23 2019, 6:55 PM · Plans
    epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: Unknown Object (Differential Revision).
    May 23 2019, 6:45 PM · Plans
    epriestley triaged T13295: Clean up magic / passthrough request parameters as Low priority.
    May 23 2019, 6:34 PM · Transactions
    epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: Unknown Object (Differential Revision).
    May 23 2019, 6:02 PM · Plans
    epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Unknown Object (Differential Revision).
    May 23 2019, 5:00 PM
    epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Unknown Object (Differential Revision).
    May 23 2019, 4:55 PM
    epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
    May 23 2019, 4:42 PM · Plans
    epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
    May 23 2019, 4:11 PM · Plans
    epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
    May 23 2019, 3:51 PM · Plans
    epriestley moved T6276: Cannot Create Named Link to URI with Brackets from Parser to Next on the Remarkup board.
    May 23 2019, 2:49 PM · Remarkup
    epriestley moved T12191: Remarkup autocomplete can remain open after keyboard form submission from Backlog to Next on the Remarkup board.
    May 23 2019, 2:48 PM · Remarkup, PHUI
    epriestley removed a project from T10667: Improve ambiguity when resolving commits that appear in multiple repositories: Remarkup.
    May 23 2019, 2:48 PM · Diffusion (v3)
    epriestley moved T7967: impossible to link string that contain ']' with remarkup syntax. from Backlog to Next on the Remarkup board.
    May 23 2019, 2:47 PM · Remarkup
    epriestley edited projects for T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster, added: Phacility; removed Customer Impact, Remarkup, Feature Request.
    May 23 2019, 2:46 PM · Phacility
    epriestley moved T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained from Backlog to Next on the Remarkup board.
    May 23 2019, 2:46 PM · Documentation, Remarkup
    epriestley moved T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion from Backlog to Next on the Remarkup board.
    May 23 2019, 2:45 PM · Remarkup, Diffusion
    epriestley edited projects for T9825: Remarkup is rendered literally in Diviner, added: Diviner; removed Remarkup.
    May 23 2019, 2:45 PM · Diviner
    epriestley removed a project from T12973: Commit list changes based on hash in URL: Remarkup.
    May 23 2019, 2:44 PM · Diffusion
    asherkin closed T13293: `arc land` using git-svn fails in certain configurations as Resolved by committing Restricted Diffusion Commit.
    May 23 2019, 9:58 AM · Subversion, Git, Arcanist

    May 22 2019

    epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: Unknown Object (Differential Revision).
    May 22 2019, 10:15 PM · Plans
    epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: Unknown Object (Differential Revision).
    May 22 2019, 9:48 PM · Herald
    epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: Unknown Object (Differential Revision).
    May 22 2019, 9:41 PM · Herald
    epriestley added a revision to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits": Unknown Object (Differential Revision).
    May 22 2019, 9:31 PM · Diffusion, Differential
    epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Unknown Object (Differential Revision).
    May 22 2019, 9:15 PM · Remarkup, Diffusion
    epriestley added a revision to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits": Unknown Object (Differential Revision).
    May 22 2019, 9:15 PM · Diffusion, Differential
    epriestley added a comment to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon.

    Currently, I think the primary transactions and transactions triggered by Herald are getting different group IDs. They should be the same group ID, e.g. all these transactions should be in the same "group" for the purposes of collecting transactions into effect groups:

    May 22 2019, 7:56 PM · Herald
    epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

    (This is mostly for my own notes and contains roughly zero insight.)

    May 22 2019, 6:07 PM · Diffusion, Differential
    epriestley added a project to T13292: Create a "Sounds" application: Sounds.
    May 22 2019, 4:56 PM · Sounds
    epriestley created Sounds.
    May 22 2019, 4:56 PM
    epriestley added a comment to T13292: Create a "Sounds" application.

    If we were just doing personal notification sounds, I think there'd be a good argument for making this a Settings panel.

    May 22 2019, 4:54 PM · Sounds
    epriestley triaged T13293: `arc land` using git-svn fails in certain configurations as Low priority.
    May 22 2019, 4:30 PM · Subversion, Git, Arcanist
    epriestley added projects to T13293: `arc land` using git-svn fails in certain configurations: Arcanist, Git, Subversion.
    May 22 2019, 4:30 PM · Subversion, Git, Arcanist
    epriestley added a comment to T13294: Provide a transaction-level view of feed.

    Per D20533, the major query this UI uses is currently unkeyed (no dateCreated key on transaction tables).

    May 22 2019, 3:44 PM · Feed, Transactions
    epriestley added a comment to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.

    See also T13290. Now that full URIs count as mentions (D20527), the text "Differential Revision: ..." in commits is counting as a mention, and "mentioning" the associated revision.

    May 22 2019, 11:51 AM · Remarkup, Diffusion

    May 21 2019

    epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Unknown Object (Differential Revision).
    May 21 2019, 7:01 PM · Remarkup, Diffusion
    epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Unknown Object (Differential Revision).
    May 21 2019, 4:46 PM · Remarkup, Diffusion
    epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
    May 21 2019, 4:03 PM · Plans
    epriestley added a revision to T13289: Plans: 2019 Week 21-23 Bonus Content: Unknown Object (Differential Revision).
    May 21 2019, 2:26 PM · Plans
    epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
    May 21 2019, 2:24 PM · Plans
    epriestley edited the content of Dependencies.
    May 21 2019, 1:20 PM
    epriestley edited the content of Dependencies.
    May 21 2019, 1:20 PM
    epriestley edited the content of Dependencies.
    May 21 2019, 1:18 PM
    epriestley added a revision to T13294: Provide a transaction-level view of feed: Unknown Object (Differential Revision).
    May 21 2019, 1:06 PM · Feed, Transactions
    epriestley added a revision to T13294: Provide a transaction-level view of feed: Unknown Object (Differential Revision).
    May 21 2019, 12:25 PM · Feed, Transactions
    joshuaspence added a revision to T6854: Modify the `lint-test` file format to allow for assertions against linter codes: Unknown Object (Differential Revision).
    May 21 2019, 8:02 AM · Lint
    joshuaspence closed T6854: Modify the `lint-test` file format to allow for assertions against linter codes as Resolved by committing Restricted Diffusion Commit.
    May 21 2019, 3:48 AM · Lint

    May 20 2019

    epriestley added a revision to T13294: Provide a transaction-level view of feed: Unknown Object (Differential Revision).
    May 20 2019, 9:23 PM · Feed, Transactions
    epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Restricted Differential Revision.
    May 20 2019, 6:45 PM · Remarkup, Diffusion
    epriestley added a revision to T13285: Service failures in JIRA can cascade into service failures in Phabricator: Restricted Differential Revision.
    May 20 2019, 6:45 PM · Doorkeeper
    epriestley added a revision to T13285: Service failures in JIRA can cascade into service failures in Phabricator: Unknown Object (Differential Revision).
    May 20 2019, 6:39 PM · Doorkeeper
    epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Unknown Object (Differential Revision).
    May 20 2019, 6:39 PM · Remarkup, Diffusion
    epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Unknown Object (Differential Revision).
    May 20 2019, 6:23 PM · Remarkup, Diffusion
    epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Unknown Object (Differential Revision).
    May 20 2019, 4:59 PM · Remarkup, Diffusion
    epriestley triaged T13294: Provide a transaction-level view of feed as Normal priority.
    May 20 2019, 1:03 PM · Feed, Transactions
    epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
    May 20 2019, 12:56 PM · Plans