Page MenuHomePhabricator
Feed Advanced Search

Jun 7 2017

janitorial created T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.
Jun 7 2017, 7:22 PM · Diffusion, Bug Report
epriestley added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

(I think that's also filed in T10767.)

Jun 7 2017, 7:19 PM · Diffusion, Design
richardvanvelzen added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

I'd love folder shortcuts (for directories that only contain a single directory). Clicking through a few levels in various Java projects would be slightly more pleasant.

Jun 7 2017, 7:18 PM · Diffusion, Design
robertkraig added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Have a most recently accessed repo list in there somewhere. Right now the order is always listed by most recently updated repo shows at the top. Maybe a additional column in there that shows most frequented repos? or maybe a "favorites" list for repos. A user can have access to many repos but not use them frequently, so pushing them towards the bottom.

Jun 7 2017, 6:44 PM · Diffusion, Design
epriestley added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

T8442 would help a lot for those "I have to many repositories"

Jun 7 2017, 6:10 PM · Diffusion, Design
epriestley added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

GitHub, which has an omnibox

Jun 7 2017, 6:07 PM · Diffusion, Design
mbm added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

I find it really annoying how there isn't a real repository search (grep files) before you go click on "Browse". Generally speaking, search in Diffusion is very confusing with three different search fields in comparison to GitHub, which has an omnibox.

Jun 7 2017, 5:23 PM · Diffusion, Design
sascha-egerer added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

T8442 would help a lot for those "I have to many repositories"

Jun 7 2017, 4:22 PM · Diffusion, Design
epriestley added a comment to T4322: Diffusion show folders first.

(That said, GitHub does show an accurate count so who knows. Maybe the page is slow because they aren't doing anything stream-oriented. In this case, a directory with 3M files probably just crashes.)

Jun 7 2017, 10:18 AM · Diffusion
epriestley added a comment to T4322: Diffusion show folders first.

I also suspect that GitHub compromises here for performance. If you look at a very large directory on GitHub, it shows only the first 1,000 files fairly slowly (page takes 1-2 seconds for me) with no pager, and a warning that the directory is too large:

Jun 7 2017, 10:16 AM · Diffusion
epriestley added a comment to T4322: Diffusion show folders first.

The reason this isn't trivial is that we ask git, hg, or svn for a list of files, for example with git ls-tree.

Jun 7 2017, 10:10 AM · Diffusion
epriestley added a comment to T4322: Diffusion show folders first.

yes I believe you have been coaxed into a clever trap -- and your predicament is of your own making!!!

Jun 7 2017, 10:02 AM · Diffusion
chad moved T8276: Diffusion shows no author information if it was associated with a deleted user from Triage to UI Refresh on the Diffusion board.
Jun 7 2017, 3:03 AM · Restricted Project, Diffusion
chad moved T2442: Show images in Diffusion diffs from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 3:02 AM · Wikimedia, Diffusion
chad moved T6131: Mirror Status on repository edit view from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 3:02 AM · Diffusion
chad moved T7701: Surface Code/File search better in Diffusion from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 3:01 AM · Restricted Project, Design, Diffusion
chad moved T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting." from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 2:59 AM · Diffusion
chad moved T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 2:57 AM · Diffusion, Feature Request
chad moved T12749: Performance test and tune DiffusionHistoryListView from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 2:55 AM · Performance, Diffusion
chad moved T12752: Pager in Diffusion doesn't tell you what page you're on from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 2:55 AM · Design, Diffusion
chad moved T12804: Diffusion pre-redesign UI feedback (June 2017) from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 2:55 AM · Diffusion, Design
chad moved T4322: Diffusion show folders first from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 2:54 AM · Diffusion
chad claimed T12804: Diffusion pre-redesign UI feedback (June 2017).
Jun 7 2017, 2:53 AM · Diffusion, Design
chad created T12804: Diffusion pre-redesign UI feedback (June 2017).
Jun 7 2017, 2:49 AM · Diffusion, Design
cspeckmim added a comment to T4322: Diffusion show folders first.

This will help

deerstalker.jpg (900×900 px, 64 KB)

Jun 7 2017, 12:53 AM · Diffusion
chad added a comment to T4322: Diffusion show folders first.

I’ve been catfished.

Jun 7 2017, 12:52 AM · Diffusion
chad added a comment to T4322: Diffusion show folders first.

Yeah I just realized this isn't a front end change, I got to trace it down to the source.

Jun 7 2017, 12:49 AM · Diffusion
cspeckmim added a comment to T4322: Diffusion show folders first.

I'd offer assistance with testing mercurial on a large repository - but the largest repository I have doesn't have more than ~50 items per directory (that I'm aware of~), so I don't think it would hit the stress points you're looking for.

Jun 7 2017, 12:47 AM · Diffusion
chad added a comment to T4322: Diffusion show folders first.

oh

Jun 7 2017, 12:44 AM · Diffusion

Jun 6 2017

chad added a comment to T4322: Diffusion show folders first.

👍

Jun 6 2017, 11:36 PM · Diffusion
epriestley added a comment to T4322: Diffusion show folders first.

(Poems doesn't have an example of the first kind of directory, and I don't know of any offhand, but you could build one locally in a couple minutes I think.)

Jun 6 2017, 11:29 PM · Diffusion
epriestley added a comment to T4322: Diffusion show folders first.

Offhand, I don't know if the kernel has directories with a lot of files in it or not -- like, Phabricator itself probably has only 1-2 directories with more than 100 files (resources/sql/autopatches/) and might have none with 100+ files and directories, so you could implement this wrong (pick the first 100 paths, then sort them by "directoryness") without there being any counterexamples in Phabricator. It's possible the kernel is the same.

Jun 6 2017, 11:29 PM · Diffusion
chad added a comment to T4322: Diffusion show folders first.

Is poems the best example or do you have another suggestion? I can try the linux kernal.

Jun 6 2017, 11:25 PM · Diffusion
epriestley added a comment to T4322: Diffusion show folders first.

Or, specifically, a list of files like this:

Jun 6 2017, 11:24 PM · Diffusion
epriestley added a comment to T4322: Diffusion show folders first.

(That is, more than 100 non-directory files.)

Jun 6 2017, 11:16 PM · Diffusion
epriestley added a comment to T4322: Diffusion show folders first.

I don't care too much.

Jun 6 2017, 11:16 PM · Diffusion
chad added a comment to T4322: Diffusion show folders first.

@epriestley Do you care if I just flip this. The hypothesis being folders are clicked more than files, and having them first makes more sense for me, and in our case, brings them above the page fold currently for rP.

Jun 6 2017, 11:01 PM · Diffusion
chad added a comment to T4322: Diffusion show folders first.

I'd probably pass on the preference, I think folders should just go first. My main observation here is if you instrumented clicks of folders vs. clicks of files, folders are probably chosen 2-1, my expectation here is that people have to dig down first, then open the file they were looking for.

Jun 6 2017, 10:55 PM · Diffusion

Jun 2 2017

• 1stone added a comment to T8747: "Path Does Not Exist" error caused by not standard characters.

Same here with a german umlaut ("ä") in the file name.

Jun 2 2017, 11:04 AM · Diffusion

May 28 2017

chad merged T12769: Applications page shows Diffusion on admin into T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
May 28 2017, 2:58 AM · Audit, Diffusion, Wikimedia

May 26 2017

epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

See Planning for information on timelines and priorities.

May 26 2017, 6:52 PM · Diffusion, Mercurial
jeremy.norris added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Just curious if there is any news on this front?

May 26 2017, 6:50 PM · Diffusion, Mercurial
chad added a comment to T12749: Performance test and tune DiffusionHistoryListView.

Yeah I just didn't want to add the (...) view to DiffusionHistory if it's going to slow those pages down. I'd just leave the feature out.

May 26 2017, 4:39 PM · Performance, Diffusion
epriestley added a comment to T12749: Performance test and tune DiffusionHistoryListView.

I think using a Pool (like HandlePool) is not too much more work (at least, if I'm implementing it) than AJAX it and will be useful in more cases. I believe we need the Pool implementation regardless, sooner or later.

May 26 2017, 4:34 PM · Performance, Diffusion
chad updated subscribers of T12749: Performance test and tune DiffusionHistoryListView.

@epriestley maybe this should just AJAX?

May 26 2017, 4:28 PM · Performance, Diffusion

May 24 2017

epriestley added a comment to T12752: Pager in Diffusion doesn't tell you what page you're on.

😢

May 24 2017, 8:40 PM · Design, Diffusion
chad updated subscribers of T12752: Pager in Diffusion doesn't tell you what page you're on.
May 24 2017, 8:38 PM · Design, Diffusion
epriestley added a comment to T12752: Pager in Diffusion doesn't tell you what page you're on.

hahaha

May 24 2017, 8:38 PM · Design, Diffusion
avivey added a comment to T12752: Pager in Diffusion doesn't tell you what page you're on.

Does it at least tell you how fast you're going?

May 24 2017, 8:37 PM · Design, Diffusion
chad created T12752: Pager in Diffusion doesn't tell you what page you're on.
May 24 2017, 5:38 PM · Design, Diffusion
chad created T12749: Performance test and tune DiffusionHistoryListView.
May 24 2017, 5:09 PM · Performance, Diffusion
michelkaeser added a comment to T8238: Formally support side-band change handoff in external repositories.

Not sure if this is the correct ticket for it, but I got here via D13020.

May 24 2017, 9:08 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster

May 17 2017

marcio-ao added a comment to T5698: Github-style Remarkup previews on a checked-in resource.
In T5698#223992, @chad wrote:

Oh hai Cura uses Phabricator? I have a Lulzbot at home!

May 17 2017, 2:37 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
chad added a comment to T5698: Github-style Remarkup previews on a checked-in resource.

Oh hai Cura uses Phabricator? I have a Lulzbot at home!

May 17 2017, 2:32 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
marcio-ao added a comment to T5698: Github-style Remarkup previews on a checked-in resource.

@Krinkle, @pablocarrillo I second your requests. Great suggestion. I have a large README.md that I would love to split into multiple documentation files, without losing all the formatting.

May 17 2017, 2:12 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup

May 6 2017

adityar7 added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

When using Mercurial, can Diffusion handle multiple remote bookmarks on the same branch?

May 6 2017, 8:55 AM · Diffusion

May 3 2017

epriestley added a comment to T3498: Allow ignore whitespace in Audit/Diffusion diffs.

Yes, this will be implemented.

May 3 2017, 5:59 PM · Diffusion
joineral32 added a comment to T3498: Allow ignore whitespace in Audit/Diffusion diffs.

Is there any chance this will ever get implemented? The lack of this feature makes our lives a lot harder, and it's a highly ubiquitous feature (GitLab, GitHub, BitBucket, Gerrit, etc. all have it). We're trying to modernize a very old codebase, and any time anybody auto-formats a file to match our standard, Phabricator's diffs become completely useless. This wouldn't be a problem if we were using any other tool.

May 3 2017, 5:58 PM · Diffusion

May 2 2017

epriestley added a parent task for T2999: When we detect a file as binary, explain why: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:56 PM · Arcanist, Diffusion

Apr 27 2017

danijepg added a comment to T7471: Unable to connect to SVN repo with invalid SSL cert.

Any idea of how to do this on CentOs?

Apr 27 2017, 5:07 PM · Subversion, Diffusion

Apr 25 2017

chad updated the task description for T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Apr 25 2017, 2:18 PM · Remarkup
chad merged T12640: Project descriptions remarkup is not parsed in query object selection into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Apr 25 2017, 2:17 PM · Remarkup

Apr 24 2017

epriestley added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..
  • I deployed D17774 to secure.
  • I verified that rSVNTEST now correctly raised an error because it was backed by a service with muliple hosts.
  • I moved rSVNTEST and rHGTEST to a one-host service, securex-legacy.phacility.net.
  • I can no longer reproduce any issues against this host.
Apr 24 2017, 5:54 PM · Diffusion, Bug Report
k_kazu added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

Problems do not reproduce when downgrading svn client:

Apr 24 2017, 2:10 PM · Diffusion, Bug Report

Apr 23 2017

epriestley added a revision to T12613: In diffusion hosting subversion repository, several commands do not return (freeze).: Restricted Differential Revision.
Apr 23 2017, 1:19 PM · Diffusion, Bug Report

Apr 22 2017

chad added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

https://secure.phabricator.com/rSVNTEST10

Apr 22 2017, 11:52 PM · Diffusion, Bug Report
chad added a comment to T12620: Add link to external bug tracker feature in Differential.

Please use Conphernce or Ponder if you have questions about Phabricator.

Apr 22 2017, 1:29 PM · Diffusion, Differential, Feature Request
chad closed T12620: Add link to external bug tracker feature in Differential as Invalid.
Apr 22 2017, 1:27 PM · Diffusion, Differential, Feature Request
mirage315 created T12620: Add link to external bug tracker feature in Differential.
Apr 22 2017, 10:22 AM · Diffusion, Differential, Feature Request
chad added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

fails for my MacBook:

Apr 22 2017, 5:57 AM · Diffusion, Bug Report
k_kazu added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

Thank you for replay.
Umm..., Reproduce with the same procedure on my environment.
It may depend on the client environment.

Apr 22 2017, 2:11 AM · Diffusion, Bug Report

Apr 21 2017

chad closed T12604: Pager hard to notice in Diffusion as Resolved by committing Restricted Diffusion Commit.
Apr 21 2017, 6:43 PM · Design, Bug Report, Diffusion
chad added a revision to T12604: Pager hard to notice in Diffusion: Restricted Differential Revision.
Apr 21 2017, 6:32 PM · Design, Bug Report, Diffusion
chad added a revision to T12604: Pager hard to notice in Diffusion: Restricted Differential Revision.
Apr 21 2017, 6:17 PM · Design, Bug Report, Diffusion
epriestley merged task T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) into T11401: Add ability to quote, edit, view raw, view history, and remove inline comments.
Apr 21 2017, 12:04 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley added a comment to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).

I'm just going to merge this into T11401, at least for the moment. That may eventually split out into application-specific tasks when it gets underway.

Apr 21 2017, 12:04 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley closed T3462: In Differential, expose "featurename (branched from master)" via Conduit, a subtask of T6486: Pending Differential Revisions isn't filtered by branch, as Wontfix.
Apr 21 2017, 11:51 AM · Diffusion
epriestley added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..

I can't reproduce this:

Apr 21 2017, 11:09 AM · Diffusion, Bug Report
k_kazu updated the task description for T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..
Apr 21 2017, 3:45 AM · Diffusion, Bug Report
k_kazu created T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..
Apr 21 2017, 3:32 AM · Diffusion, Bug Report

Apr 20 2017

chad renamed T12604: Pager hard to notice in Diffusion from Can't find folder in Diffusion to Pager hard to notice in Diffusion.
Apr 20 2017, 8:04 PM · Design, Bug Report, Diffusion
jmeador added a comment to T12604: Pager hard to notice in Diffusion.

I agree, pagination way below the fold is rather inconspicuous

Apr 20 2017, 5:59 PM · Design, Bug Report, Diffusion
chad added a comment to T12604: Pager hard to notice in Diffusion.

hahaha, thanks... really easy to miss those

Apr 20 2017, 5:58 PM · Design, Bug Report, Diffusion
chad added a project to T12604: Pager hard to notice in Diffusion: Design.
Apr 20 2017, 5:58 PM · Design, Bug Report, Diffusion
jmeador added a comment to T12604: Pager hard to notice in Diffusion.

Bystander input: try page 3: https://phabricator.kde.org/source/krita/browse/master/libs/ui/?offset=200

Apr 20 2017, 5:57 PM · Design, Bug Report, Diffusion
chad created T12604: Pager hard to notice in Diffusion.
Apr 20 2017, 5:38 PM · Design, Bug Report, Diffusion

Apr 19 2017

epriestley closed T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field as Resolved by committing Restricted Diffusion Commit.
Apr 19 2017, 11:14 PM · Diffusion
epriestley added a revision to T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field: Restricted Differential Revision.
Apr 19 2017, 11:12 PM · Diffusion
epriestley claimed T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field.
Apr 19 2017, 11:11 PM · Diffusion
epriestley added a comment to T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field.

(I assumed it was a keydown vs keypress vs whatever event sort of thing but haven't actually looked into it.)

Apr 19 2017, 10:32 PM · Diffusion
epriestley added a comment to T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field.

Yeah, this bites me half the time too.

Apr 19 2017, 10:32 PM · Diffusion
amckinley created T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field.
Apr 19 2017, 10:31 PM · Diffusion

Apr 17 2017

manoj.katikar added a comment to T11137: Unable to update Git repositories with latest stable.

When I trying to update the hosted repository from the remote GIT installed location. It is throwing following error message:
Error updating working copy: Command failed with error #255!
COMMAND
git fetch origin '+refs/*:refs/*' --prune

Apr 17 2017, 10:41 AM · Diffusion, Bug Report
manoj.katikar added a comment to T9213: Unable to set up a GIT hosted repository.

It helps to resolve my issue also.

Apr 17 2017, 6:47 AM · Diffusion

Apr 15 2017

epriestley added a comment to T5698: Github-style Remarkup previews on a checked-in resource.

Recent security issues in GitHub, GitLab, etc., with markdown:

Apr 15 2017, 11:22 AM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup

Apr 14 2017

epriestley closed T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes as Resolved by committing Restricted Diffusion Commit.
Apr 14 2017, 3:03 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley added a comment to T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.

Totally my fault, I just didn't read half that sentence. 🐈

Apr 14 2017, 2:59 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
edward added a comment to T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.

Thanks for looking into this so quickly.

Apr 14 2017, 2:59 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley claimed T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.
Apr 14 2017, 12:59 PM · Customer Impact, Infrastructure, Diffusion, Bug Report
epriestley added a comment to T12554: PhabricatorAuthSSHKeyQuery cache is not dirtied on username changes.

And thanks for the report! Let us know if you run into anything else.

Apr 14 2017, 12:10 PM · Customer Impact, Infrastructure, Diffusion, Bug Report