Page MenuHomePhabricator
Feed Advanced Search

Feb 2 2017

epriestley moved T3788: Improve encoding management in Diffusion from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:02 PM · Restricted Project, Diffusion
epriestley moved T1758: Diffusion reveals EOF context incorrectly for unchanged missing newline from Backlog to Triage on the Diffusion board.
Feb 2 2017, 4:02 PM · Diffusion
epriestley closed T1180: Allow users to navigate between revisions when viewing a file. as Wontfix.

We haven't seen more interest in this since 2012 and this task no longer meets modern criteria for feature requests (see Contributing Feature Requests).

Feb 2 2017, 4:01 PM · Diffusion
epriestley moved T491: Inline Comments for Paste / Diffusion Files from Backlog to Far Future on the Diffusion board.
Feb 2 2017, 3:58 PM · Restricted Project, Diffusion, Paste
epriestley moved T5826: Behaviour of "browse" while viewing a commit only in one branch from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Diffusion
epriestley moved T5028: Commit message text formatting in remote git repository (SSH) is not preserved from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Diffusion
epriestley moved T4801: Error with unclear next steps from `git push` to hosted repository from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Git, Diffusion
epriestley moved T4405: Detect `sudo` errors on HTTP repository access from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Diffusion
epriestley moved T4255: SVN property changes on directories not shown in Diffusion diff views? from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:58 PM · Subversion, Diffusion
epriestley moved T4197: Change parser fails for changes affecting paths longer than 512 characters from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:57 PM · Diffusion
epriestley moved T4030: Phabricator can't process commits which delete files from a relocated directory from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:57 PM · Diffusion, Subversion
epriestley moved T2999: When we detect a file as binary, explain why from Backlog to Triage on the Diffusion board.
Feb 2 2017, 3:57 PM · Arcanist, Diffusion
epriestley moved T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool from Backlog to Far Future on the Diffusion board.
Feb 2 2017, 3:57 PM · Diffusion
epriestley moved T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior from Backlog to Wow! Features! on the Diffusion (v3) board.
Feb 2 2017, 3:56 PM · Diffusion (v3), Bug Report
epriestley moved T11029: Colorized html inline diffs for Diffusion from Backlog to Wow! Features! on the Diffusion (v3) board.
Feb 2 2017, 3:55 PM · Diffusion (v3), Audit
epriestley moved T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw from Backlog to Wow! Features! on the Diffusion (v3) board.
Feb 2 2017, 3:54 PM · Diffusion (v3)
epriestley edited projects for T11968: Decide the fate of FutureGraph, added: Diffusion; removed Diffusion (v3).
Feb 2 2017, 3:54 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley moved T12164: Put an indirection layer between author/committer strings and user accounts from Backlog to Wow! Features! on the Diffusion (v3) board.
Feb 2 2017, 3:53 PM · Customer Impact, Diffusion (v3)
epriestley moved T12185: Action Lists on Repository edit pages don't display on tablet/mobile from Backlog to Probably Actual Bugs on the Diffusion (v3) board.
Feb 2 2017, 3:53 PM · Diffusion (v3), Bug Report
epriestley moved T12163: Long lines overflow in Diffusion browser from Backlog to Probably Actual Bugs on the Diffusion (v3) board.
Feb 2 2017, 3:53 PM · Bug Report, Diffusion (v3), PHUI
epriestley moved T12033: Large diffs can still repeatedly fail to insert from Backlog to Probably Actual Bugs on the Diffusion (v3) board.
Feb 2 2017, 3:53 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley moved T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Backlog to Probably Actual Bugs on the Diffusion (v3) board.
Feb 2 2017, 3:53 PM · Diffusion (v3), Differential, Mail
epriestley moved T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application from Backlog to Probably Actual Bugs on the Diffusion (v3) board.
Feb 2 2017, 3:53 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
epriestley moved T11165: Changing a callsign throws a 404 from Backlog to Probably Actual Bugs on the Diffusion (v3) board.
Feb 2 2017, 3:52 PM · Diffusion (v3), Bug Report
epriestley moved T10604: Allow application code to stream request data from Backlog to HTTP Streaming on the Diffusion (v3) board.
Feb 2 2017, 3:51 PM · Diffusion (v3), Restricted Project
epriestley moved T4369: Phabricator HTTP repository hosting has fairly severe scalability limits from Backlog to HTTP Streaming on the Diffusion (v3) board.
Feb 2 2017, 3:51 PM · Diffusion (v3), Restricted Project
epriestley moved T6722: Support "Create similar repository..." in Diffusion from Backlog to git push = save changes on the Diffusion (v3) board.
Feb 2 2017, 3:51 PM · Diffusion (v3), Restricted Project
epriestley moved T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches from Backlog to git push = save changes on the Diffusion (v3) board.
Feb 2 2017, 3:50 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley moved T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it from Backlog to git push = save changes on the Diffusion (v3) board.
Feb 2 2017, 3:50 PM · Diffusion
epriestley moved T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs from Backlog to git push = save changes on the Diffusion (v3) board.
Feb 2 2017, 3:50 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley moved T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) from Backlog to git push = save changes on the Diffusion (v3) board.
Feb 2 2017, 3:50 PM · Diffusion, Herald, Bug Report
epriestley moved T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist from Backlog to Meta on the Diffusion (v3) board.
Feb 2 2017, 3:49 PM · Diffusion (v3), Arcanist, Differential
epriestley moved T12168: Upgrading: Owners Packages/Commits now use edges from Backlog to Meta on the Diffusion (v3) board.
Feb 2 2017, 3:49 PM · Diffusion (v3), Installing & Upgrading, Audit
epriestley edited projects for T9524: Show aggregate subdirectory coverage in Diffusion browse views, added: Diffusion; removed Diffusion (v3).

Kicking this out of scope for now.

Feb 2 2017, 3:48 PM · Diffusion, Restricted Project
jon.rimmer awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Feb 2 2017, 3:46 PM · Workboards (v3), Restricted Project
epriestley added a comment to T12174: Home Menu Errata.

I think D17298 is probably a good change for Favorites either way (so we don't have a "pin" UI there that doesn't do anything) since it's pretty simple.

Feb 2 2017, 3:44 PM · Dashboards (v2), Profile Menu Item
epriestley added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Feb 2 2017, 3:40 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

Pinning on Favorites has no effect.

Feb 2 2017, 3:30 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

You want to use top-most displayable even if the user has two personal dashboards and has explicitly clicked the pin icon on the second one to make it their default item?

Feb 2 2017, 3:27 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

You can change the rules for picking a default item in PhabricatorProfileMenuEngine->loadItems() if you want to use different rules.

Feb 2 2017, 3:26 PM · Dashboards (v2), Profile Menu Item
epriestley moved T12163: Long lines overflow in Diffusion browser from Backlog to v3 on the Diffusion board.
Feb 2 2017, 3:20 PM · Bug Report, Diffusion (v3), PHUI
epriestley moved T12168: Upgrading: Owners Packages/Commits now use edges from Backlog to v3 on the Diffusion board.
Feb 2 2017, 3:20 PM · Diffusion (v3), Installing & Upgrading, Audit
epriestley moved T12185: Action Lists on Repository edit pages don't display on tablet/mobile from Backlog to v3 on the Diffusion board.
Feb 2 2017, 3:20 PM · Diffusion (v3), Bug Report
epriestley added a comment to T12174: Home Menu Errata.

There isn't a way to un-set a default, or pick a different global default as a default, although you can effectively do either by creating a copy of whatever global item you want to be default and pinning it, except "magic home", which you can't copy. So there are a couple of messy edge cases there but they don't feel too important to me.

Feb 2 2017, 3:19 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

If Admin "sets default" on Global, and users have not set a default, the page follow admin default. (I had to set my dashboard as default, as seems to be no way of un-setting a default).

Feb 2 2017, 3:16 PM · Dashboards (v2), Profile Menu Item
epriestley added a subtask for T12101: Phabricator PHP 7 Compatibility: T12190: In PHP7, include-time warnings from source files are ignored.
Feb 2 2017, 3:11 PM · Infrastructure, Guides
epriestley added a parent task for T12190: In PHP7, include-time warnings from source files are ignored: T12101: Phabricator PHP 7 Compatibility.
Feb 2 2017, 3:11 PM · Infrastructure
epriestley closed T12187: Editing Menu Items leads into daemon or transaction errors as Resolved by committing Restricted Diffusion Commit.
Feb 2 2017, 3:02 PM · Bug Report
epriestley closed T12187: Editing Menu Items leads into daemon or transaction errors, a subtask of T12190: In PHP7, include-time warnings from source files are ignored, as Resolved.
Feb 2 2017, 3:02 PM · Infrastructure
epriestley added a comment to T12184: Large (~750MB) git push fails over SSH.
  • For HTTP, this is broadly expected in some sense until T4369 is resolved.
  • For SSH, this is not expected but the linked file is 1.75GB. Did you encounter this in a more realistic scenario and the size of that file is just for demonstration purposes, or are you trying to store ~1GB binary assets in a Git repository? Git is generally not well suited to serve as a binary asset store. GitLFS (T7789) or possible future changes like T11367 are likely better fits for this use case.
Feb 2 2017, 3:01 PM · Diffusion, Bug Report
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

Completely fine to make the engine aware of the viewer running the query, I think we just didn't have use cases for that when this stuff was written.

Feb 2 2017, 2:39 PM · Elasticsearch, Search
epriestley added a comment to T12187: Editing Menu Items leads into daemon or transaction errors.

In 99% of cases, the right thing to do when you see an error in the daemon logs is:

Feb 2 2017, 2:19 PM · Bug Report
epriestley edited projects for T12189: My Account is locked after delete project using CLI, added: Bug Report (Needs Information); removed Bug Report.

This report is missing version information. See Contributing Bug Reports and Providing Version Information for help. To move forward:

Feb 2 2017, 2:10 PM · Bug Report (Needs Information)
epriestley merged T12188: Provide a global configuration option for repository "Autoclose On" branch setting into T10691: Support GitHub-like forking of repositories.
Feb 2 2017, 2:07 PM · Restricted Project, Diffusion, Feature Request
epriestley merged task T12188: Provide a global configuration option for repository "Autoclose On" branch setting into T10691: Support GitHub-like forking of repositories.
Feb 2 2017, 2:07 PM · Feature Request
epriestley added a revision to T12187: Editing Menu Items leads into daemon or transaction errors: Unknown Object (Differential Revision).
Feb 2 2017, 2:03 PM · Bug Report
epriestley added a revision to T12190: In PHP7, include-time warnings from source files are ignored: Unknown Object (Differential Revision).
Feb 2 2017, 2:03 PM · Infrastructure
epriestley added a parent task for T12187: Editing Menu Items leads into daemon or transaction errors: T12190: In PHP7, include-time warnings from source files are ignored.
Feb 2 2017, 2:00 PM · Bug Report
epriestley added a subtask for T12190: In PHP7, include-time warnings from source files are ignored: T12187: Editing Menu Items leads into daemon or transaction errors.
Feb 2 2017, 2:00 PM · Infrastructure
epriestley created T12190: In PHP7, include-time warnings from source files are ignored.
Feb 2 2017, 2:00 PM · Infrastructure
epriestley closed T12186: Unable to resign from audit / remove own concern from authored commit as Invalid.

We can only accept bug reports against current versions of Phabricator, as detailed in Contributing Bug Reports. Feel free to file a new report against a modern version, if this issue still reproduces at HEAD of master or stable.

Feb 2 2017, 1:37 PM · Audit, Bug Report
epriestley added a comment to T12174: Home Menu Errata.

I think D17294 + guidance is maybe good enough?

Feb 2 2017, 1:14 AM · Dashboards (v2), Profile Menu Item
epriestley closed T5722: Support meta-audit of arbitrary baskets of nonadjacent commits as Resolved.

I'm going to close this as tentatively resolved since it's fairly old and things have changed a fair bit since it was filed. I believe we may now handle this use case reasonably well. If you still have use cases for this that aren't addressed at HEAD, feel free to file a new issue describing what problems you currently face after upgrading (following Contributing Feature Requests).

Feb 2 2017, 1:10 AM · Audit

Feb 1 2017

Netrics awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Feb 1 2017, 9:11 PM · Workboards (v3), Restricted Project
epriestley updated the task description for T12174: Home Menu Errata.
Feb 1 2017, 6:18 PM · Dashboards (v2), Profile Menu Item
epriestley added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Feb 1 2017, 6:18 PM · Dashboards (v2), Profile Menu Item
epriestley updated the task description for T12174: Home Menu Errata.
Feb 1 2017, 6:01 PM · Dashboards (v2), Profile Menu Item
epriestley added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Feb 1 2017, 6:01 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

Why do we need to allow it to be hidden?

Feb 1 2017, 5:58 PM · Dashboards (v2), Profile Menu Item
epriestley added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Feb 1 2017, 5:57 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

It looks like it works, it's just a little confusing since "Home" doesn't show up. I'll fix that:

Feb 1 2017, 5:54 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

Also, we might be torpedoing open-source installs which don't have a dashboard right now since the magic "Home" doesn't show up if you're logged out. I'll look at that.

Feb 1 2017, 5:53 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

I think that's a whole pile of work, I was just thinking that administrators could disable the global item.

Feb 1 2017, 5:47 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

Leave the default fake 'Home' as is (corporate install, your stuff)

Feb 1 2017, 5:39 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

I also, generally, can't come up with any uses for links that or other items which are only visible after you log in, outside of dashboards.

Feb 1 2017, 5:33 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

I'd like to wait until we have a good answer on how we'd use this feature before we pursue it. I worry that it adds a significant amount of complexity and may really have zero use cases. In the best case, it is useful to only a tiny number of open source installs.

Feb 1 2017, 5:31 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

Oh, or is that non-hypothetical?

Feb 1 2017, 5:23 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

How would you like the two dashboards to differ on this install?

Feb 1 2017, 5:21 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

Oh, maybe I misunderstood then. How would you like to make the logged-out vs logged-in menus different on this install, or how do you think other open source installs would benefit from this? (This only impacts open-source installs, right?)

Feb 1 2017, 5:15 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

I'm not really sold on the use case -- which is just letting open source installs have a logged-in dashboard tailored to the user, right?

Feb 1 2017, 5:09 PM · Dashboards (v2), Profile Menu Item
epriestley closed T12183: Stop Subscribe on Comment as Invalid.

Please follow the rules in Contributing Feature Requests when submitting feature requests.

Feb 1 2017, 2:21 PM · Feature Request
epriestley added a comment to T12173: Support Buildkite as a Harbormaster target.
  • After D17282, we do branch=phabricator/diff/689, commit=HEAD when building revisions.
  • After D17282, we do branch=<one arbitrary containing branch>, commit=<commit hash> when building commits.
  • The "GitHub Settings" workaround above resolved the "tags disabled" issue, as suggested.
Feb 1 2017, 1:55 PM · Harbormaster, Phacility
epriestley created T12182: PhabricatorPeopleProfilePictureController (and maybe other photo upload controllers) can fatal.
Feb 1 2017, 1:24 PM · Files
epriestley closed T12181: Bulk Deleting Audits does not remove "Audit Required" from Commit as Resolved.

Yeah, run bin/audit synchronize --all (or rXYZ for just one repository) after doing manual cleanup with bin/audit delete. This is noted in the documentation at HEAD as of ~yesterday, although it may not have regenerated in production yet.

Feb 1 2017, 1:19 PM · Bug Report
epriestley closed T10978: Modernize Audit as Resolved.

I think I've pushed this approximately as far as I plan to in this iteration. Everything mentioned in the description has been tackled, and audits on this install are now in a relatively sane state.

Feb 1 2017, 3:05 AM · Audit
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

(arc list will also grow some kind of --reviewer=me --status=open mode in T7715, but I suspect that no one would really care if arc patch just did that by default.)

Feb 1 2017, 2:58 AM · Differential
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

D17283 allows you to double-click the D1234 crumb to select it, since it's no longer a link. I don't know if double-clicks are too complicated or not.

Feb 1 2017, 2:54 AM · Differential
epriestley added a revision to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision": Unknown Object (Differential Revision).
Feb 1 2017, 2:53 AM · Differential
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

The selection junk is caused by float: left which apparently fixed some kind of IE thing in 2014 (T5902) so that may be involved to fix.

Feb 1 2017, 2:52 AM · Differential
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

Also a lot of users do not notice this text is in the URL since on Safari the browser hides everything except the domain until you click on it.

Feb 1 2017, 2:44 AM · Differential
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

One general improvement we could make is to have arc patch without arguments offer you open, non-authored revisions in the same repository, using the new numerical menu selector from T10895. That might moot this, and I can't immediately imagine any other default behaviors for arc patch with no arguments (other than showing you how to provide arguments, as it currently does, but we could retain this text in an abbreviated form).

Feb 1 2017, 2:40 AM · Differential
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

I'm also confused about this:

Feb 1 2017, 2:32 AM · Differential
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

arc list will eventually be more flexible (T7715) but today it's only your stuff.

Feb 1 2017, 2:28 AM · Differential
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

Er, oh, other reviews. Then maybe this feedback should be on T12026, rather than here.

Feb 1 2017, 2:27 AM · Differential
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

Oh, then arc list?

Feb 1 2017, 2:26 AM · Differential
epriestley added a comment to T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".

@jcarrillo7: there is no command line way to get back a list of reviews (with their identifiers) that are active for the current repo.

Feb 1 2017, 2:24 AM · Differential
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

We queried a subset of instances to gain insight about how frequently repository data is hosted on GitLab, so we're better prepared to respond to any indirect fallout from a recent operational incident on their side:

Feb 1 2017, 1:25 AM · Phacility
epriestley created T12178: Users can send messages to Conpherence rooms they do not have CAN_JOIN permission for.
Feb 1 2017, 1:10 AM · Conpherence (v4), Security
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

Broadly, I'm supportive.

Feb 1 2017, 12:54 AM · Elasticsearch, Search
epriestley added a comment to T5301: Inline Remarkup escaping.

All changes in Phabricator need to be driven by strong, real-world use-cases.

Feb 1 2017, 12:42 AM · Remarkup