Page MenuHomePhabricator
Feed Advanced Search

Nov 17 2016

epriestley closed T11882: Suggestion for easier port handling when setting up phabricator as a git repo as Wontfix.

Actually, this also means that users can't copy/paste the thing in the web UI, right? They'll need to copy "ssh://secure@secure.phabricator.com/source/phabricator.git" from the web UI, manually edit the URI to have their host alias, then execute the command?

Nov 17 2016, 12:46 AM · Feature Request

Nov 16 2016

epriestley reopened T8588: One instance has a severe, global performance issue as "Open".
Nov 16 2016, 11:55 PM · Restricted Project
epriestley reopened T8588: One instance has a severe, global performance issue, a subtask of T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error), as Open.
Nov 16 2016, 11:55 PM · Restricted Project, Workboards
epriestley reopened T8588: One instance has a severe, global performance issue, a subtask of T8444: Increase typeahead speed, as Open.
Nov 16 2016, 11:55 PM · Typeahead, PHUI, Restricted Project
• Gadget0624 awarded T2374: Have `bin/phd stop` look for daemons and warn you about them, or nuke them with some flag a Hungry Hippo token.
Nov 16 2016, 9:08 PM · OS Students 2013, Daemons
epriestley created T11884: Comment text areas lost the green highlight when a file is dropped into them in the recent comment update.
Nov 16 2016, 6:19 PM · Remarkup, Design
epriestley added a comment to T11882: Suggestion for easier port handling when setting up phabricator as a git repo.

I made the claim that this is the easiest way because my experience is that "have all your users do something" is always harder than "do something yourself", at least in the roles I held at Facebook and here. I'd gladly solder pins on the motherboard if I didn't have to tell users to make a simple configuration change.

Nov 16 2016, 6:17 PM · Feature Request
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Ah. I believe I fixed a simpler version of that case earlier, but not the specific case you describe. D16881 should fix that case.

Nov 16 2016, 6:08 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Nov 16 2016, 6:05 PM · Prioritized, Transactions
epriestley closed T7643: Improve prose diffs (was: description changes don't generate usable diffs) as Resolved.
  • D16853 tweaked one issue that I caught.
  • T11881 is a followup for restoring code diffs in a small set of scenarios.
  • I haven't seen other issues for a while, so I'm going to consider this resolved until they crop up. If you do run into cases where the new algorithm isn't doing a great job, let us know.
Nov 16 2016, 5:17 PM · Prioritized, Transactions
epriestley created T11881: Make Paste content changes render as code diffs again, not prose diffs.
Nov 16 2016, 5:15 PM · Restricted Project, Paste, Transactions
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.
  • D16877 includes the entire CLDR "windows to the rest of the world" map in things we'll recognize.
    • Neither that map or the Microsoft map have "Russian Time", but maybe that's just what the UI shows for zones like "Russia Time Zone 10", and not what actually appears in the ICS file? Otherwise we're going to have to keep digging.
  • D16878 fixes the form customization stuff I mentioned above, mostly by preventing quirky/confusing fields from being customized (at least, for now).
  • D16879 fixes a rendering bug with "All Day" events that could shift them forward or backwards by a day.
  • D16880 uses the same rendering logic for subheaders (which now appears to be correct) and tooltips (which had a different, older copy of very similar logic).
Nov 16 2016, 3:53 PM · Restricted Project, Calendar
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

From T11878, these patterns aren't obvious:

Nov 16 2016, 3:48 PM · Restricted Project, Herald
epriestley added a comment to T11878: New Herald Action To trigger evaluation of another herald rule.

It also occurs to me that if I needed multiple and conditions I could make a rule that did nothing but just matched those conditions,

Nov 16 2016, 3:43 PM · Feature Request
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 16 2016, 3:37 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 16 2016, 3:24 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 16 2016, 2:59 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 16 2016, 2:48 PM · Restricted Project, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.
  • Editing the EditEngine default form and removing "Host" means that "Host" no longer prefills. This is the same as T10222. A temporary workaround would be to prevent that field from being defaulted. It should be defaultable in the long run, but is probably low-value to assign a default to, so it's probably better to just lock it for now and make it behave a little more sensibly.
Nov 16 2016, 2:17 PM · Restricted Project, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Some other stuff:

Nov 16 2016, 2:15 PM · Restricted Project, Calendar
epriestley added a comment to T11878: New Herald Action To trigger evaluation of another herald rule.

epriestley's "Another herald rule" condition does not solve the problem.

Nov 16 2016, 2:04 PM · Feature Request
epriestley added a comment to T7789: Support Git Large File Storage.

No, there's no specific support for LFS mirroring yet.

Nov 16 2016, 1:13 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley closed T11879: Highlight trailing white spaces at end of lines as Resolved.

Configure ArcanistTextLinter, which can detect and automatically correct these errors:

Nov 16 2016, 1:01 PM · Feature Request
epriestley added a comment to T10308: Bring back links to task lists on project pages; List name of assignee in workboard cards.

Oh, sorry! I added you to Community so you should now have edit power.

Nov 16 2016, 12:58 PM · Projects (v3), Feature Request
epriestley added a member for Community: aklapper.
Nov 16 2016, 12:57 PM
0 awarded T11816: Calendar: Feedback and Suggestions a Love token.
Nov 16 2016, 4:31 AM · Restricted Project, Calendar
epriestley added a revision to T11044: Support partitioning application databases across multiple database hosts: Unknown Object (Differential Revision).
Nov 16 2016, 1:17 AM · Clusters, Prioritized
epriestley added a comment to T11878: New Herald Action To trigger evaluation of another herald rule.

Why doesn't this work?

Nov 16 2016, 12:31 AM · Feature Request

Nov 15 2016

epriestley added a comment to T11878: New Herald Action To trigger evaluation of another herald rule.

You can already do this with the "Another Herald Rule" condition.

Nov 15 2016, 11:35 PM · Feature Request
epriestley merged task T11877: closing a subtask as a duplicate of another task doesn't update parent task into T3287: Merging duplicate tasks doesn't migrate dependencies.
Nov 15 2016, 10:40 PM · Bug Report
epriestley merged T11877: closing a subtask as a duplicate of another task doesn't update parent task into T3287: Merging duplicate tasks doesn't migrate dependencies.
Nov 15 2016, 10:40 PM · Maniphest, Hard
epriestley created E1212: Running Errands.
Nov 15 2016, 9:47 PM
epriestley closed T11809: Calendar v1 Errata Mark II, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Nov 15 2016, 9:44 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11809: Calendar v1 Errata Mark II as Resolved by committing Restricted Diffusion Commit.
Nov 15 2016, 9:44 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 15 2016, 8:46 PM · Calendar
epriestley added a comment to T11876: ./bin/celerity map, ./scripts/celerity/generate_sprites.php - Attempt to connect to root@localhost failed with error #2002: No such file or directory.

Feature requests require a root problem description (see Contributing Feature Requests and Describing Root Problems). Feel free to file a new feature request completely describing your root problem. If you do, please read all of the documentation carefully first: it lays out exactly what information we need to move forward on a feature request.

Nov 15 2016, 8:23 PM · Feature Request
epriestley closed T11876: ./bin/celerity map, ./scripts/celerity/generate_sprites.php - Attempt to connect to root@localhost failed with error #2002: No such file or directory as Invalid.

It would be great, if this would not be necessary.

Nov 15 2016, 8:20 PM · Feature Request
epriestley added a comment to T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.

T11864 is another flavor of [ ] Show on commit message template., like T7327, although it wants to hide "Subscribers" instead of show "Projects".

Nov 15 2016, 8:16 PM · Restricted Project, Restricted Project, Custom Fields
epriestley merged T11864: Ability to customize arcanist default template into T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Nov 15 2016, 8:15 PM · Restricted Project, Restricted Project, Custom Fields
epriestley merged task T11864: Ability to customize arcanist default template into T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Nov 15 2016, 8:15 PM · Feature Request
epriestley added a comment to T11864: Ability to customize arcanist default template.

adding them as a Reviewer achieves the same purpose

Nov 15 2016, 8:15 PM · Feature Request
epriestley added a comment to T11876: ./bin/celerity map, ./scripts/celerity/generate_sprites.php - Attempt to connect to root@localhost failed with error #2002: No such file or directory.

I'd be thrilled to answer questions about third-party application development or Phabricator's internals, but unfortunately we can't offer that for free -- it's very time consuming and usually only benefits one user. If you're interested in help with modifying Phabricator or developing third-party applications, see Consulting.

Nov 15 2016, 8:11 PM · Feature Request
epriestley added a comment to T11876: ./bin/celerity map, ./scripts/celerity/generate_sprites.php - Attempt to connect to root@localhost failed with error #2002: No such file or directory.

I can't reproduce this. Here's what I did:

Nov 15 2016, 8:04 PM · Feature Request
epriestley added a comment to T11876: ./bin/celerity map, ./scripts/celerity/generate_sprites.php - Attempt to connect to root@localhost failed with error #2002: No such file or directory.

I'm happy to work with you to answer questions about my local environment and try to narrow down what's different, but we charge for this because it's very time consuming and often only helps one user. See Consulting for details.

Nov 15 2016, 7:55 PM · Feature Request
epriestley closed T11850: Pholio Mockups Image Uploads stops uploading as Invalid.

We haven't received additional information that allows us to reproduce this issue, so we can't move forward. Feel free to file a new report in the future if you can provide complete reproduction steps.

Nov 15 2016, 7:52 PM · Bug Report (Needs Information)
epriestley edited projects for T11876: ./bin/celerity map, ./scripts/celerity/generate_sprites.php - Attempt to connect to root@localhost failed with error #2002: No such file or directory, added: Bug Report (Needs Information); removed Bug Report.

I can't reproduce this. Here's what I did:

Nov 15 2016, 7:50 PM · Feature Request
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.
  • D16865 should treat "W. Europe Standard Time" as "Europe/Berlin". We'll figure out some better solution for this if it continues being an issue, I'm just still hopeful that we can get almost-correct coverage with a handful of explicit mappings/rules without needing to do anything more complicated.
  • D16866 should give the datepicker more reasonable behavior on mobile/tablet devices (the panel should now center on screen when activated).
  • D16867 should fix the issue with all-day events sometimes extending too far in the summary text on the day view.
  • D16868 improves behaviors around inviting projects to events on the day/month/detail views.
  • D16870 makes a query for "Invited: epriestley" mean "events which epriestley is invited to, or any project that epriestley is a member of is invited to". You can find just individual invites with "Invited: exact(epriestley)".
Nov 15 2016, 7:46 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 15 2016, 7:28 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 15 2016, 7:09 PM · Restricted Project, Calendar
epriestley merged T11821: Support viewing invitee status by project into T11816: Calendar: Feedback and Suggestions.
Nov 15 2016, 7:03 PM · Restricted Project, Calendar
epriestley merged task T11821: Support viewing invitee status by project into T11816: Calendar: Feedback and Suggestions.
Nov 15 2016, 7:03 PM · Calendar, Feature Request
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 15 2016, 6:19 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 15 2016, 6:11 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 15 2016, 5:55 PM · Restricted Project, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

The implementation effort required to support arbitrary VTIMEZONE entries would be fairly huge, since we'd need to reimplement the PHP builtin classes DateTime and DateTimeZone and basically write a full date handling engine. I believe there is no compelling reason for software to ever specify an event in a timezone which is not part of timezonedb (I believe timezonedb is accurate, exhaustive, and fairly ubiquitous; and RFC5545 mentions it, although it does not require it be used), although mapping VTIMEZONE names to timezonedb names may be difficult.

Nov 15 2016, 5:52 PM · Restricted Project, Calendar
epriestley closed T11867: Passphrase Conduit API does not specify secret for token credential type as Resolved by committing Restricted Diffusion Commit.
Nov 15 2016, 5:12 PM · Conduit, Passphrase, Bug Report
epriestley closed T11868: Phurl URLs send email to themselves (???) as Resolved by committing Restricted Diffusion Commit.
Nov 15 2016, 5:12 PM · Phurl
epriestley added a revision to T11867: Passphrase Conduit API does not specify secret for token credential type: Unknown Object (Differential Revision).
Nov 15 2016, 5:09 PM · Conduit, Passphrase, Bug Report
epriestley added a revision to T11868: Phurl URLs send email to themselves (???): Unknown Object (Differential Revision).
Nov 15 2016, 5:01 PM · Phurl
epriestley added a revision to T9304: Workflow for inviting new users to a Phacility instance is unnecessarily confusing: Unknown Object (Differential Revision).
Nov 15 2016, 4:36 PM · Phacility
epriestley added a revision to T9304: Workflow for inviting new users to a Phacility instance is unnecessarily confusing: Unknown Object (Differential Revision).
Nov 15 2016, 4:35 PM · Phacility
epriestley created T11868: Phurl URLs send email to themselves (???).
Nov 15 2016, 4:30 PM · Phurl
epriestley closed T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument as Resolved by committing Restricted Diffusion Commit.
Nov 15 2016, 3:15 PM · Diffusion, Bug Report
epriestley added a comment to T11865: "Aleo" does not include cyrillic characters.

How could we edit T4213 to make it more clear that it applies to all discussion of themes, skinning, and custom CSS, including fonts?

Nov 15 2016, 2:55 PM · FreeBSD, Feature Request
epriestley renamed T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument from Unhandled exception in Diffusion while trying to audit a commit to PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 2:54 PM · Diffusion, Bug Report
epriestley added a revision to T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument: Unknown Object (Differential Revision).
Nov 15 2016, 2:53 PM · Diffusion, Bug Report
epriestley added a comment to T11865: "Aleo" does not include cyrillic characters.

@vills, see T4213 for discussion of custom themes, skinning, etc.

Nov 15 2016, 2:47 PM · FreeBSD, Feature Request
epriestley assigned T11865: "Aleo" does not include cyrillic characters to chad.

We distribute "Aleo", but this font does not include cyrillic characters or some other extended latin characters (like "ğ" and "Ğ", from Turkish). It does include some extended latin, like the Polish "ł".

Nov 15 2016, 2:46 PM · FreeBSD, Feature Request
epriestley renamed T11865: "Aleo" does not include cyrillic characters from Ability to use custom font in UI to "Aleo" does not include cyrillic characters.
Nov 15 2016, 2:25 PM · FreeBSD, Feature Request
epriestley added a comment to T11864: Ability to customize arcanist default template.

You can remove "Test Plan" by disabling the field in differential.fields in Config.

Nov 15 2016, 1:59 PM · Feature Request
epriestley created T11860: Bot email addresses can't be edited.
Nov 15 2016, 12:18 AM · Setup, People

Nov 14 2016

epriestley edited the content of Phacility Cluster Devices.
Nov 14 2016, 11:05 PM
epriestley added a revision to T11355: Build a flexible revision lookup API in Arcanist: Unknown Object (Differential Revision).
Nov 14 2016, 10:16 PM · Restricted Project, Prioritized, Arcanist
epriestley closed T11849: Commit is no longer reachable as Invalid.

From that trace, it's possible that there's an issue in the vein of T9898, if the repository has an enormous number of branches (tens of thousands?).

Nov 14 2016, 9:58 PM · Bug Report (Needs Information)
epriestley added a comment to T11849: Commit is no longer reachable.

What happened before that?

Nov 14 2016, 9:23 PM · Bug Report (Needs Information)
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

We queried a subset of free instances to gain insight about free instance usage patterns (mostly: are they actually being used?). Specifically, I ran these queries to count repositories and feed stories on a subset of free instances:

Nov 14 2016, 7:03 PM · Phacility
epriestley moved T11760: Phacility Cluster: Ad-Hoc Query Log from Backlog to Near Future on the Phacility board.
Nov 14 2016, 7:02 PM · Phacility
epriestley moved T4701: Linter for <?hh code from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:05 PM · Lint, Arcanist
epriestley moved T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:04 PM · Arcanist
epriestley moved T5568: Support `.arcunit`, similar to `.arclint` from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:04 PM · Unit, Arcanist
epriestley moved T6060: Arcanist should skip linters that have missing dependencies from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:04 PM · Restricted Project, Arcanist
epriestley moved T6061: `arc linters` should do basic environment checking from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:04 PM · Lint, Arcanist
epriestley moved T6234: Add option to make arc lint interactive from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:03 PM · Arcanist
epriestley moved T6653: Script and regex linter could use some examples from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:03 PM · Lint, Documentation, Arcanist
epriestley moved T6912: `arc unit` should automatically cd to the root of the project from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:02 PM · Unit, Arcanist
epriestley moved T7016: ArcanistUnitConsoleRenderer assumes that any unit test result without a timestamp runs in "<1ms" from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:02 PM · Unit, Arcanist
epriestley moved T7293: Add support for ansible-lint from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:02 PM · Arcanist, Lint
epriestley moved T7357: Case insensitive file system leads to extra processes when running 'arc unit' from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:02 PM · Unit, Arcanist
epriestley removed a parent task for T7443: Include full link to Maniphest tasks in commit messages: T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw.
Nov 14 2016, 6:02 PM · Diffusion, Arcanist
epriestley removed a subtask for T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw: T7443: Include full link to Maniphest tasks in commit messages.
Nov 14 2016, 6:02 PM · Diffusion (v3)
epriestley added a comment to T7443: Include full link to Maniphest tasks in commit messages.

Actually I guess this (storage format in commit history) is largely unrelated to that (display format in web UI).

Nov 14 2016, 6:01 PM · Diffusion, Arcanist
epriestley added a subtask for T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw: T7443: Include full link to Maniphest tasks in commit messages.
Nov 14 2016, 6:01 PM · Diffusion (v3)
epriestley added a parent task for T7443: Include full link to Maniphest tasks in commit messages: T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw.
Nov 14 2016, 6:01 PM · Diffusion, Arcanist
epriestley moved T7554: XUnitTestEngine: remove OpenSSL dependency (use uniqid) from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:00 PM · Unit, Arcanist
epriestley moved T7553: XUnitTestEngine does not handle properly whitespaces in runner's path from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 6:00 PM · Unit, Arcanist
epriestley added a comment to T7657: Reviewer changes across `arc diff --update` and web UI are not merged constructively.

T11114 should fix this for free.

Nov 14 2016, 5:59 PM · Restricted Project, Differential, Arcanist
epriestley renamed T7657: Reviewer changes across `arc diff --update` and web UI are not merged constructively from Race condition in `arc diff --update` to Reviewer changes across `arc diff --update` and web UI are not merged constructively.
Nov 14 2016, 5:59 PM · Restricted Project, Differential, Arcanist
epriestley added a parent task for T7657: Reviewer changes across `arc diff --update` and web UI are not merged constructively: T11114: Move Differential to EditEngine.
Nov 14 2016, 5:59 PM · Restricted Project, Differential, Arcanist
epriestley added a subtask for T11114: Move Differential to EditEngine: T7657: Reviewer changes across `arc diff --update` and web UI are not merged constructively.
Nov 14 2016, 5:59 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley moved T8404: Running the cpplint linter through arcanist no longer works from Backlog to Unit/Lint Bindings on the Arcanist board.
Nov 14 2016, 5:58 PM · Lint, Arcanist