Page MenuHomePhabricator

PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument
Closed, ResolvedPublic

Description

Hello! When I try to audit a commit in Diffusion, I have the following error:

DiffusionException.PNG (191×466 px, 8 KB)

My repository is a SVN repository. I tried to audit a commit for a GIT hosted repository, I don't have any issue! It was working fine last week...

Replication steps:

  • Just try to audit a commit of a SVN repository

Expected result:

I should be able to audit the commit

Actual Results:

The error page appears.

Version informations:

phabricator d5a72ca98ed228c1995bdc4f9e5037a4093d28fe (Mon, Nov 14)
arcanist fad85844314b151994769a461825c90f7400c145 (Sat, Oct 22)
phutil 162c55d991df1481a57ba4121de1377b3347406c (Sun, Nov 13)

Note:

Here is a dump of the apache error log:

[Tue Nov 15 09:10:42.831650 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535] [2016-11-15 09:10:42] ERROR 2: Missing argument 1 for PhabricatorRepository::getPathURI(), called in /var/www/phabricator/phabricator/src/applications/repository/storage/PhabricatorRepository.php on line 763 and defined at [/var/www/phabricator/phabricator/src/applications/repository/storage/PhabricatorRepository.php:580]
[Tue Nov 15 09:10:42.832176 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535] arcanist(head=master, ref.master=fad85844314b), phabricator(head=master, ref.master=d5a72ca98ed2), phutil(head=master, ref.master=162c55d991df)
[Tue Nov 15 09:10:42.847678 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #0 PhabricatorRepository::getPathURI() called at [<phabricator>/src/applications/repository/storage/PhabricatorRepository.php:763]
[Tue Nov 15 09:10:42.847698 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #1 PhabricatorRepository::generateURI(array) called at [<phabricator>/src/applications/diffusion/request/DiffusionRequest.php:455]
[Tue Nov 15 09:10:42.847705 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #2 DiffusionRequest::generateURI(array) called at [<phabricator>/src/applications/diffusion/controller/DiffusionController.php:165]
[Tue Nov 15 09:10:42.847711 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #3 DiffusionController::buildCrumbList(array) called at [<phabricator>/src/applications/diffusion/controller/DiffusionController.php:113]
[Tue Nov 15 09:10:42.847716 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #4 DiffusionController::buildCrumbs(array) called at [<phabricator>/src/applications/diffusion/controller/DiffusionCommitController.php:45]
[Tue Nov 15 09:10:42.847721 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #5 DiffusionCommitController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:257]
[Tue Nov 15 09:10:42.847727 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #6 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:169]
[Tue Nov 15 09:10:42.847732 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #7 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:17]
[Tue Nov 15 09:10:42.850742 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535] [2016-11-15 09:10:42] EXCEPTION: (RuntimeException) Undefined variable: path at [<phutil>/src/error/PhutilErrorHandler.php:210]
[Tue Nov 15 09:10:42.851226 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535] arcanist(head=master, ref.master=fad85844314b), phabricator(head=master, ref.master=d5a72ca98ed2), phutil(head=master, ref.master=162c55d991df)
[Tue Nov 15 09:10:42.851255 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/repository/storage/PhabricatorRepository.php:581]
[Tue Nov 15 09:10:42.851270 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #1 <#2> PhabricatorRepository::getPathURI() called at [<phabricator>/src/applications/repository/storage/PhabricatorRepository.php:763]
[Tue Nov 15 09:10:42.851285 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #2 <#2> PhabricatorRepository::generateURI(array) called at [<phabricator>/src/applications/diffusion/request/DiffusionRequest.php:455]
[Tue Nov 15 09:10:42.851291 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #3 <#2> DiffusionRequest::generateURI(array) called at [<phabricator>/src/applications/diffusion/controller/DiffusionController.php:165]
[Tue Nov 15 09:10:42.851312 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #4 <#2> DiffusionController::buildCrumbList(array) called at [<phabricator>/src/applications/diffusion/controller/DiffusionController.php:113]
[Tue Nov 15 09:10:42.851323 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #5 <#2> DiffusionController::buildCrumbs(array) called at [<phabricator>/src/applications/diffusion/controller/DiffusionCommitController.php:45]
[Tue Nov 15 09:10:42.851329 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #6 <#2> DiffusionCommitController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:257]
[Tue Nov 15 09:10:42.851333 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #7 phlog(RuntimeException) called at [<phabricator>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
[Tue Nov 15 09:10:42.851338 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #8 PhabricatorDefaultRequestExceptionHandler::handleRequestException(AphrontRequest, RuntimeException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:671]
[Tue Nov 15 09:10:42.851343 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #9 AphrontApplicationConfiguration::handleException(RuntimeException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:262]
[Tue Nov 15 09:10:42.851347 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #10 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:169]
[Tue Nov 15 09:10:42.851352 2016] [:error] [pid 31808] [client XXX.XXX.XXX.XXX:58535]   #11 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:17]

Event Timeline

djeauh updated the task description. (Show Details)
djeauh updated the task description. (Show Details)

We have the same issue after the last update and we usually update once a week. I can confirm that the issue happens with any commit to a SVN repository that you want to view via Audit. Git commits display fine.
Might this be related to the change "Old", "New" and "Diff" tabs in the web UI from your latest changelog?

epriestley renamed this task from Unhandled exception in Diffusion while trying to audit a commit to PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.Nov 15 2016, 2:54 PM
epriestley claimed this task.
epriestley triaged this task as Normal priority.