Page MenuHomePhabricator

Add option to make arc lint interactive
Closed, WontfixPublic

Description

By default, when I type arc lint or arc diff and get a lint run for me, Phabricator dumps a pile of lints onto my terminal. If I am not a savvy editor user, I now have to manually scroll through these (extremely verbose) lint errors and manually fire up my editor for each one, navigate to the line in question, and edit it.

Yes, if I'm a smart editor user I'll use --output compiler to load it up into my quickfix, but that's besides the point. (Also, doing this is pretty damn annoying without a bit of programming). The point is, the default user experience should be better. (Especially because the interactive tool arc diff spews this output by default.)

I suggest a model like git checkout -p, where we prompt for every lint (rather than just the ones we can fix), and the user can either ignore it, or edit it (firing up the default editor to location so they can go and fix it.)

(P.S. I'm happy to write this patch, if people agree that it'd be a good improvement to the current behavior.)

Event Timeline

ezyang raised the priority of this task from to Needs Triage.
ezyang updated the task description. (Show Details)
ezyang added a project: Arcanist.
ezyang added a subscriber: ezyang.
chad renamed this task from arc lint default workflow is annoying to Add option to make arc lint interactive.Oct 3 2014, 5:15 PM
chad triaged this task as Wishlist priority.
epriestley claimed this task.
epriestley added a subscriber: epriestley.

This has seen little interest so I don't currently plan to pursue it. Ideally, lint messages should simply include patches so that arc fixes the errors itself.