Page MenuHomePhabricator
Create Task
Maniphest T11809

Calendar v1 Errata Mark II
Closed, ResolvedPublic
Actions

Description

The red "away" dot is not well explained right now, and will presumably become more frequent once Calendar unprototypes.

  • On profiles, show the red dot next to "Away until..." so the same visual element is present in both places. Maybe make this element more clear/explicit, too.
  • On hovercards, show the dot too.
  • Move "Calendar" profile widget above "Badges" profile widget.

There's some infrastructure cleanup to do:

  • Remove all obsolete columns from CalendarEvent table.
  • Remove all the old "Holiday" stuff -- we might implement this in some form eventually, but the existing approach doesn't make sense anymore.

The main Calendar guide should get fleshed out:

  • Put words in "Calendar User Guide".

Action dropdown:

  • Maybe put a "Cancel Event" in the action dropdown? (Maybe later? Presumably infrequent, and muddies the "this event" vs "all events" choice.)
  • Maybe put RSVP stuff in the action dropdown? (Maybe later? There are buttons elsewhere on the page, not sure how often decline + comment will be and from Facebook events it's sort of a bad pattern anyway -- leads to lots of "Sorry, can't make this one!" comments, at least for social events.)
  • Make sure the action dropdown behaves reasonably for recurring events.

Mail:

  • Reminder mail is still really rough.
  • Normal event mail includes the description in every message, which is abnormal/nonstandard.

Recurring events:

  • There's a bug with making an event recurring in handling the "Until" control.
  • There's a bug with removing the "Until" value from a recurring event.
  • Needing to switch the "Make Recurring" dialog into "Recurring" mode feels pretty junky.

Revisions and Commits

rP Phabricator
D16872rPc7f2e4a9246e Document calendar summary icons
D16819rP6a7dde03ccfb On `@username` mentions in remarkup, show the "busy" dot color
D16796rPe4c6ae534518 Smooth out various transaction/editing behaviors for Calendar
D16792rPe9b861ff1583 Write a basic Calendar user guide
D16795rP29313372e715 Improve some commenting/editing behaviors for recurring events
D16794rP64cf9204c1d9 In Calendar, only include the event description in the original event mail
D16791rPc9510cc1184e Make it more clear that red dots next to usernames mean Calendar availability
D16790rPbf0004744b3c Move "Calendar" above "Badges" on user profiles
D16789rP3f2f81a1c8ab Remove obsolete Calendar event date storage fields
D16788rP6982bded7124 Remove ancient "Holiday" storage

Related Objects
Search...

Event Timeline

epriestley created this task.Nov 1 2016, 9:30 PM
Herald added a subscriber: eadler. · View Herald TranscriptNov 1 2016, 9:30 PM
epriestley renamed this task from Calendar v1 Errata to Calendar v1 Errata Mark II.Nov 1 2016, 9:31 PM
epriestley added a parent task: T7924: Unprototype Calendar (v1).
epriestley updated the task description. (Show Details)Nov 1 2016, 9:50 PM
epriestley added a revision: D16788: Remove ancient "Holiday" storage.Nov 1 2016, 10:52 PM
epriestley added a commit: rP6982bded7124: Remove ancient "Holiday" storage.Nov 1 2016, 11:03 PM
epriestley added a revision: D16789: Remove obsolete Calendar event date storage fields.Nov 1 2016, 11:28 PM
epriestley added a commit: rP3f2f81a1c8ab: Remove obsolete Calendar event date storage fields.Nov 2 2016, 4:49 PM
epriestley added a revision: D16790: Move "Calendar" above "Badges" on user profiles.Nov 2 2016, 4:53 PM
epriestley updated the task description. (Show Details)Nov 2 2016, 4:57 PM
epriestley added a revision: D16791: Make it more clear that red dots next to usernames mean Calendar availability.Nov 2 2016, 5:16 PM
epriestley updated the task description. (Show Details)Nov 2 2016, 5:33 PM
epriestley updated the task description. (Show Details)Nov 2 2016, 5:36 PM
epriestley updated the task description. (Show Details)Nov 2 2016, 5:43 PM
epriestley added a revision: D16792: Write a basic Calendar user guide.Nov 2 2016, 6:06 PM
epriestley updated the task description. (Show Details)Nov 2 2016, 6:09 PM
epriestley added a revision: D16794: In Calendar, only include the event description in the original event mail.Nov 2 2016, 8:12 PM
epriestley added a commit: rPbf0004744b3c: Move "Calendar" above "Badges" on user profiles.Nov 2 2016, 8:13 PM
epriestley added a revision: D16795: Improve some commenting/editing behaviors for recurring events.Nov 2 2016, 8:44 PM
epriestley added a commit: rPc9510cc1184e: Make it more clear that red dots next to usernames mean Calendar availability.Nov 2 2016, 8:45 PM
epriestley added a commit: rP64cf9204c1d9: In Calendar, only include the event description in the original event mail.
epriestley updated the task description. (Show Details)Nov 2 2016, 9:00 PM
epriestley added a commit: rP29313372e715: Improve some commenting/editing behaviors for recurring events.Nov 2 2016, 9:09 PM
epriestley added a commit: rPe9b861ff1583: Write a basic Calendar user guide.Nov 2 2016, 9:48 PM
epriestley added a revision: D16796: Smooth out various transaction/editing behaviors for Calendar.Nov 2 2016, 10:43 PM
epriestley updated the task description. (Show Details)Nov 2 2016, 11:15 PM
epriestley added a commit: rPe4c6ae534518: Smooth out various transaction/editing behaviors for Calendar.Nov 3 2016, 6:03 PM
deric added a subscriber: deric.Nov 5 2016, 12:05 PM

The rP3f2f81a1c8ab: Remove obsolete Calendar event date storage fields commit broke our phabricator setup.

#1054: Unknown column 'event.dateTo' in 'where clause' at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:325]
PHP message: arcanist(head=master, ref.master=fad85844314b), phabricator(head=master, ref.master=bd3233d3ab0c), phutil(head=master, ref.master=e409df2720c2)
...

for fixing seems to be enough:

use phabricator_calendar;
alter table calendar_event add dateTo int unsigned NOT NULL;
alter table calendar_event add dateFrom int unsigned NOT NULL;
epriestley added a comment.Nov 5 2016, 3:05 PM

@deric, the code event.dateTo no longer appears anywhere in Phabricator (it was removed prior to the column being removed) so I suspect you did not restart properly and were running cached code (or possibly have custom code you need to update). See Restarting Phabricator.

epriestley added a comment.Nov 5 2016, 3:13 PM

(If you believe I'm mistaken, please show the full stack trace for the error so we can identify and remove the remaining reference to this column.)

epriestley added a revision: D16819: On `@username` mentions in remarkup, show the "busy" dot color.Nov 7 2016, 8:26 PM
epriestley added a commit: rP6a7dde03ccfb: On `@username` mentions in remarkup, show the "busy" dot color.Nov 7 2016, 10:57 PM
epriestley added a subtask: T11836: Calendar Imports have the correct policy, but that policy is unclear.Nov 9 2016, 8:24 PM
epriestley closed subtask T11836: Calendar Imports have the correct policy, but that policy is unclear as Resolved.Nov 9 2016, 11:05 PM
epriestley added a revision: D16872: Document calendar summary icons.Nov 15 2016, 8:46 PM
epriestley closed this task as Resolved by committing rPc7f2e4a9246e: Document calendar summary icons.Nov 15 2016, 9:44 PM
epriestley added a commit: rPc7f2e4a9246e: Document calendar summary icons.
• candis36 added a subscriber: • candis36.Nov 18 2016, 7:18 AM
In T11809#199051, @deric wrote:

The rP3f2f81a1c8ab: Remove obsolete Calendar event date storage fields commit broke our phabricator setup.

#1054: Unknown column 'event.dateTo' in 'where clause' at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:325]
PHP message: arcanist(head=master, ref.master=fad85844314b), phabricator(head=master, ref.master=bd3233d3ab0c), phutil(head=master, ref.master=e409df2720c2)
...

for fixing seems to be enough:

use phabricator_calendar;
alter table calendar_event add dateTo int unsigned NOT NULL;
alter table calendar_event add dateFrom int unsigned NOT NULL;
deric added a comment.Nov 18 2016, 7:35 AM

@epriestley Yeah, you're right. There was a php5-fpm instance running, which i forgot to restart.

Phabricator · Built by Phacility