Page MenuHomePhabricator
Feed Advanced Search

Jun 13 2016

epriestley added a comment to T10547: Remote SVN repository imports over SSH do not tidy up temporary directories.

I appear to have found a reproduction case for this in the cluster.

Jun 13 2016, 2:43 PM · Prioritized, Subversion, Bug Report
epriestley claimed T10547: Remote SVN repository imports over SSH do not tidy up temporary directories.
Jun 13 2016, 2:43 PM · Prioritized, Subversion, Bug Report
epriestley added a comment to T11137: Unable to update Git repositories with latest stable.

I'm deploying this to the cluster now.

Jun 13 2016, 2:25 PM · Diffusion, Bug Report
epriestley moved T7441: Support OAuth providers in the cluster from Paused to The Queue on the Prioritized board.
Jun 13 2016, 2:21 PM · Auth, Phacility
epriestley claimed T11137: Unable to update Git repositories with latest stable.
Jun 13 2016, 1:36 PM · Diffusion, Bug Report
epriestley added a revision to T11137: Unable to update Git repositories with latest stable: Unknown Object (Differential Revision).
Jun 13 2016, 1:14 PM · Diffusion, Bug Report
epriestley added a comment to T11137: Unable to update Git repositories with latest stable.

@ivo, if you see this before I post a fix, can you show me the output of this command so I can make sure I'm reproducing exactly the same issue?

Jun 13 2016, 1:02 PM · Diffusion, Bug Report
epriestley added a revision to T11137: Unable to update Git repositories with latest stable: Unknown Object (Differential Revision).
Jun 13 2016, 12:41 PM · Diffusion, Bug Report
epriestley added a comment to T11137: Unable to update Git repositories with latest stable.

This issue describes a narrow issue with typehinting URIs, introduced by T10227.

Jun 13 2016, 12:39 PM · Diffusion, Bug Report
epriestley merged T11004: git URI normalization is not reliable into T11137: Unable to update Git repositories with latest stable.
Jun 13 2016, 12:32 PM · Diffusion, Bug Report
epriestley merged task T11004: git URI normalization is not reliable into T11137: Unable to update Git repositories with latest stable.
Jun 13 2016, 12:32 PM · Diffusion, Bug Report
epriestley added a comment to T11004: git URI normalization is not reliable.

I'm going to merge this into T11137. They don't describe the same issue, but I'm planning to fix them in the same way.

Jun 13 2016, 12:32 PM · Diffusion, Bug Report

Jun 12 2016

epriestley added a comment to T11132: New Phabricator NUX.

(And those UIs might also not actually be useful for future-administrators, particularly since I don't really plan to ever help users with third-party stuff, although who knows.)

Jun 12 2016, 11:09 PM · Design, Phacility, NUX
epriestley added a comment to T11132: New Phabricator NUX.

My intent with a lot of that stuff is to make administration and support (particularly in the future, once third-party applications are more common) easier, so they're targeted primarily at future-administrators who have questions like these, possibly because we've asked them for the information:

Jun 12 2016, 11:08 PM · Design, Phacility, NUX
epriestley added a comment to T11132: New Phabricator NUX.

(And we can continue reducing the number of settings, but not very quickly.)

Jun 12 2016, 10:13 PM · Design, Phacility, NUX
epriestley added a comment to T11132: New Phabricator NUX.

/config/ is already an attempt at chopping it up, vs /config/all/ which is the un-chopped version. If you have a better way of making it less scary there's no need to chop it up in the way it's currently chopped up, though.

Jun 12 2016, 10:11 PM · Design, Phacility, NUX
epriestley added a comment to T11133: Allow non-ASCII usernames.

Yeah -- the highlighting code is more flexible about what it matches than the actual search code is, which makes T6740 worse / more confusing.

Jun 12 2016, 4:10 AM · Feature Request
epriestley added a comment to T11133: Allow non-ASCII usernames.

"username" doesn't match "usernames" until T6740.

Jun 12 2016, 4:07 AM · Feature Request
epriestley merged T11133: Allow non-ASCII usernames into T6003: Support non-Latin scripts in usernames.
Jun 12 2016, 4:02 AM · Wikimedia, People
epriestley merged task T11133: Allow non-ASCII usernames into T6003: Support non-Latin scripts in usernames.
Jun 12 2016, 4:02 AM · Feature Request
epriestley added a comment to T11133: Allow non-ASCII usernames.

We've already declined support for this. See T6003 for discussion.

Jun 12 2016, 4:02 AM · Feature Request
epriestley closed T11134: When mention is removed in comment edit mention record in target should be removed as well as Wontfix.

This isn't a bug; you mentioned the other object and we accurately reflect that.

Jun 12 2016, 4:01 AM · Bug Report

Jun 11 2016

epriestley added a project to T8909: Provide ability to hide all inline or done comments: Prioritized.
Jun 11 2016, 1:33 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
epriestley added a member for Blessed Committers: neonbadger.
Jun 11 2016, 1:32 PM
epriestley published Blog Post: Development Notes (2016 Week 24).
Jun 11 2016, 11:43 AM
epriestley edited the content of Changelog.
Jun 11 2016, 11:32 AM
epriestley created 2016 Week 24 (Mid June).
Jun 11 2016, 11:32 AM

Jun 10 2016

epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Large diffs like wiki pages should render better in email now:

Jun 10 2016, 4:56 PM · Prioritized, Transactions
epriestley updated the task description for T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Jun 10 2016, 3:57 PM · Prioritized, Transactions
epriestley closed T11130: metamta.placeholder-to-recipient doesn't upgrade CCs to To as it says so. as Invalid.

This report does not include reproduction instructions. Bug reports must include complete reproduction instructions. See Providing Reproduction Steps.

Jun 10 2016, 3:53 PM · Bug Report
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Jun 10 2016, 3:30 PM · Prioritized, Transactions
epriestley closed T11128: VirtualAlloc() failed: [0x00000008] Not enough storage is available to process this command. as Resolved.
Jun 10 2016, 3:27 PM · Windows, libphutil, Arcanist, Bug Report
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Jun 10 2016, 3:13 PM · Prioritized, Transactions
epriestley closed T11129: arc test-upload - testing large diff uploads as Invalid.

See Consulting if you'd like our help resolving environment-specific configuration and setup problems.

Jun 10 2016, 3:01 PM · Feature Request
epriestley moved T9789: Make it easier to write custom transaction types from Backlog to The Queue on the Prioritized board.
Jun 10 2016, 1:44 PM · Modernization, Transactions
epriestley added a project to T9789: Make it easier to write custom transaction types: Prioritized.

I spent a couple hours on this last night and a couple hours this morning and I think I have Paste pretty much converted, so things look promising. I'm going to hold this until after the release cut, but expect to put Calendar on top of it and whatever else converts in the future.

Jun 10 2016, 1:44 PM · Modernization, Transactions
epriestley added a comment to T11126: Allow embedding XKCD panes in Remarkup.

Looks like there's a JSON API: https://xkcd.com/json.html

Jun 10 2016, 12:35 AM · Restricted Project, User Delight, Remarkup, Feature Request

Jun 9 2016

epriestley closed T11125: Ability to change LDAP password from within Phabricator as Wontfix.

Phabricator is not an LDAP administration tool and we have no plans to turn it into one.

Jun 9 2016, 10:04 PM · LDAP, Feature Request
epriestley moved T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches from The Queue to Paused on the Prioritized board.

D16094 should improve things, let me know if you identify specific problems after deploying that. It's deployed on this server now, although we have fewer similarly-named projects so it's harder to see the effects.

Jun 9 2016, 8:28 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T11120: HTML mails malformed.

Config → All Settings → phpmailer.smtp-encoding

Jun 9 2016, 8:20 PM · Mail, Bug Report
epriestley added a revision to T11120: HTML mails malformed: Unknown Object (Differential Revision).
Jun 9 2016, 8:19 PM · Mail, Bug Report
epriestley added a comment to T11120: HTML mails malformed.

Let's just make base64 the default and see what that breaks. ¯\_(ツ)_/¯

Jun 9 2016, 8:17 PM · Mail, Bug Report
epriestley added a revision to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Unknown Object (Differential Revision).
Jun 9 2016, 8:16 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

It's expected that the ordering in "Browse" is alphabetical/raw, and I don't plan to change that.

Jun 9 2016, 7:50 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T11120: HTML mails malformed.

Interesting. The same mail was delivered to me intact:

Jun 9 2016, 7:46 PM · Mail, Bug Report
epriestley moved T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier from Backlog to The Queue on the Prioritized board.
Jun 9 2016, 7:29 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley moved T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches from Preflight to The Queue on the Prioritized board.
Jun 9 2016, 7:29 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).
  • We currently use white-space: pre-wrap to handle linebreaks in prose diffs, but at least one client (Airmail) doesn't handle that properly. We could use explicit <br /> to improve behavior.
Jun 9 2016, 7:25 PM · Prioritized, Transactions
epriestley moved T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust) from Preflight to Paused on the Prioritized board.

I think this should work now. I tested it locally with HTTP and SOCKS proxies via Charles and those both seemed to behave properly.

Jun 9 2016, 7:20 PM · Prioritized, Restricted Project, Feature Request
epriestley added a revision to T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust): Unknown Object (Differential Revision).
Jun 9 2016, 6:50 PM · Prioritized, Restricted Project, Feature Request
epriestley added a revision to T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust): Unknown Object (Differential Revision).
Jun 9 2016, 6:47 PM · Prioritized, Restricted Project, Feature Request
epriestley added a revision to T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust): Unknown Object (Differential Revision).
Jun 9 2016, 6:45 PM · Prioritized, Restricted Project, Feature Request
epriestley closed T11123: Implement differential.revision.search as Resolved.

Sounds good. I'll call this done for now, let us know if you run into issues.

Jun 9 2016, 5:39 PM · Conduit, Differential, Feature Request
epriestley added a comment to T11116: Ponder email for newly created question includes content that suggests the question was also edited.

I think we're relying on white-space: pre-wrap; right now. We could explicitly do \n -> <br /> conversion which might fix newlines, at least.

Jun 9 2016, 4:51 PM · Ponder, Bug Report
epriestley added a comment to T11116: Ponder email for newly created question includes content that suggests the question was also edited.

maybe by 2050 email will work most of the time for most people

Jun 9 2016, 4:48 PM · Ponder, Bug Report
epriestley added a comment to T11116: Ponder email for newly created question includes content that suggests the question was also edited.

The actual diff is further down and rendered correctly for me, at least -- that's just how we currently render "added one line to the middle of a 500 line document" right now:

Jun 9 2016, 4:48 PM · Ponder, Bug Report
epriestley added a comment to T11116: Ponder email for newly created question includes content that suggests the question was also edited.

No, that's this stuff from T7643#179240:

Jun 9 2016, 4:47 PM · Ponder, Bug Report
epriestley added a comment to T9789: Make it easier to write custom transaction types.

I'm leaning toward exploring this in the near term. We have four applications which may convert soon:

Jun 9 2016, 4:40 PM · Modernization, Transactions
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Oh, one more thing:

Jun 9 2016, 4:34 PM · Prioritized, Transactions
epriestley added a comment to T11123: Implement differential.revision.search.

I return the other fields, but don't currently return "status" because I'd have to return an internal numeric constant. So we may need to fix that more thoroughly before you can move forward.

Jun 9 2016, 4:25 PM · Conduit, Differential, Feature Request
epriestley added a comment to T11123: Implement differential.revision.search.

Actually, this is slightly more involved because you want to select open revisions.

Jun 9 2016, 4:07 PM · Conduit, Differential, Feature Request
epriestley added a revision to T11123: Implement differential.revision.search: Unknown Object (Differential Revision).
Jun 9 2016, 4:02 PM · Conduit, Differential, Feature Request
epriestley added a comment to T11123: Implement differential.revision.search.

You essentially only need the revision IDs in the response, right?

Jun 9 2016, 3:55 PM · Conduit, Differential, Feature Request
epriestley added a comment to T11124: Repository commits stuck on "importing commits".

That is, if you go to the Diffusion workboard, we give you a generic create form instead of a choice between the various normal create forms, currently.

Jun 9 2016, 3:54 PM · Support Request, Subversion, Diffusion
epriestley added a comment to T11124: Repository commits stuck on "importing commits".

You can file stuff without those tags from workboards, and maybe "Support Request" just got caught in the crossfire of typing every possible tag, so that's a legitimate-albeit-unusual pathway here. But I wouldn't expect the short-lived "New Support Request" form to be accessible any longer.

Jun 9 2016, 3:53 PM · Support Request, Subversion, Diffusion
epriestley renamed T11123: Implement differential.revision.search from Search for revisions by project via conduit to Implement differential.revision.search.
Jun 9 2016, 3:51 PM · Conduit, Differential, Feature Request
epriestley added a comment to T11124: Repository commits stuck on "importing commits".

How did you file this task?

Jun 9 2016, 3:50 PM · Support Request, Subversion, Diffusion
epriestley closed T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge as Resolved by committing Restricted Diffusion Commit.
Jun 9 2016, 3:43 PM · Pholio, Bug Report
epriestley added a comment to T6523: Allow creating/adding images to mocks with a vanilla upload control.

After D16088:

Jun 9 2016, 3:42 PM · Prioritized, Pholio, Wikimedia
epriestley moved T6523: Allow creating/adding images to mocks with a vanilla upload control from Backlog to Paused on the Prioritized board.
Jun 9 2016, 3:41 PM · Prioritized, Pholio, Wikimedia
epriestley added a revision to T6523: Allow creating/adding images to mocks with a vanilla upload control: Unknown Object (Differential Revision).
Jun 9 2016, 3:40 PM · Prioritized, Pholio, Wikimedia
epriestley added a revision to T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge: Unknown Object (Differential Revision).
Jun 9 2016, 3:19 PM · Pholio, Bug Report
epriestley closed T5761: Add an update comment to tasks that are linked to Pholio mocks when they are updated as Wontfix.

We haven't seen other requests for this and it's consistent with the similar behavior in Differential.

Jun 9 2016, 3:12 PM · Pholio
epriestley added a comment to T6523: Allow creating/adding images to mocks with a vanilla upload control.

This should also fix the mobile workflow stragglers from T2644.

Jun 9 2016, 3:11 PM · Prioritized, Pholio, Wikimedia
epriestley merged T2644: Make Pholio work better on mobile into T6523: Allow creating/adding images to mocks with a vanilla upload control.
Jun 9 2016, 3:10 PM · Prioritized, Pholio, Wikimedia
epriestley merged task T2644: Make Pholio work better on mobile into T6523: Allow creating/adding images to mocks with a vanilla upload control.
Jun 9 2016, 3:10 PM · Pholio
epriestley merged T8712: Unpublished pholio inlines count towards the total number of inlines into T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge.
Jun 9 2016, 3:10 PM · Pholio, Bug Report
epriestley merged task T8712: Unpublished pholio inlines count towards the total number of inlines into T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge.
Jun 9 2016, 3:10 PM · Pholio
epriestley moved T8712: Unpublished pholio inlines count towards the total number of inlines from Backlog to v2 on the Pholio board.
Jun 9 2016, 3:10 PM · Pholio
epriestley moved T6523: Allow creating/adding images to mocks with a vanilla upload control from Backlog to v2 on the Pholio board.
Jun 9 2016, 3:09 PM · Prioritized, Pholio, Wikimedia
epriestley moved T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge from Backlog to v2 on the Pholio board.
Jun 9 2016, 3:09 PM · Pholio, Bug Report
epriestley added a project to T7924: Unprototype Calendar (v1): Prioritized.
Jun 9 2016, 2:58 PM · Restricted Project, Prioritized, Calendar
epriestley added a project to T10747: Import and export ICS from Calendar: Prioritized.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley claimed T2334: Implement Google Calendar v3 API into Calendar.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley moved T10747: Import and export ICS from Calendar from Backlog to Unprototype (v1) on the Calendar board.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley moved T2334: Implement Google Calendar v3 API into Calendar from Future Work (v2+) to Unprototype (v1) on the Calendar board.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10969: Incorrect Phriction link in email.

Anchor tags got cleaned up in D16083.

Jun 9 2016, 2:56 PM · Phriction, Bug Report
epriestley renamed T11073: Allow the user to specify a date in a different timezone using date controls from Allow the user to specify a timezone when creating a countdown to Allow the user to specify a date in a different timezone using date controls.
Jun 9 2016, 2:53 PM · KDE, Calendar, Feature Request
epriestley closed T11090: Marking comments as done in Differential isn't always saved correctly as Invalid.

This report doesn't include reproduction instructions and doesn't clearly demonstrate a problem: all of the screenshots are explicable through user error.

Jun 9 2016, 2:52 PM · Restricted Project, Differential, Bug Report
epriestley closed T1982: Link to symbols defined or altered in the Revision as Wontfix.

We haven't seen other requests for this in many years.

Jun 9 2016, 2:47 PM · Differential
epriestley closed T7774: Marking Inline Comment as done creates comment transaction as Resolved.

I can't reproduce this at HEAD, presuming it was resolved some time in the last year.

Jun 9 2016, 2:35 PM · Differential
epriestley added a comment to T11044: Support partitioning application databases across multiple database hosts.

After a little thought, I'm leaning strongly to putting every schema on every database. I think this makes a lot of the administration, maintenance and implementation easier.

Jun 9 2016, 1:35 PM · Clusters, Prioritized
epriestley added a comment to T11120: HTML mails malformed.

Here is a string of 2048 unbroken "M" characters:

Jun 9 2016, 1:12 PM · Mail, Bug Report
epriestley added a comment to T11120: HTML mails malformed.

Oddly, in the prior case where mail was mangled for a user on their install but similar mail was not mangled here, the unmangled mail I received was encoded in "8bit", which tends to suggest that this might be an MTA problem rather than an "8bit" problem, per se. But changing the encoding away from "8bit" might be the only real lever we have to fix the MTA.

Jun 9 2016, 1:11 PM · Mail, Bug Report
epriestley added a comment to T11120: HTML mails malformed.

The trigger for the behavior is likely just "long lines of text", we had an earlier report of something similar occurring inside an inline comment snippet (but it could not be reproduced on this install).

Jun 9 2016, 1:04 PM · Mail, Bug Report
epriestley added a comment to T11120: HTML mails malformed.

It's possible that adjusting phpmailer.smtp-encoding (say, to binary or base64) might fix this.

Jun 9 2016, 1:02 PM · Mail, Bug Report
epriestley moved T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks from Backlog to Preflight on the Prioritized board.
Jun 9 2016, 12:56 PM · Prioritized, Wikimedia, Remarkup
epriestley added a comment to T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.

I implemented this, sort of. However, it doesn't work cleanly because transactions are "adjusted" (have old values populated) after they are "expanded" (which generates the @user mention transactions). So when the code runs, it doesn't have access to the old text and can't easily figure out which mentions are new.

Jun 9 2016, 12:56 PM · Prioritized, Wikimedia, Remarkup
epriestley added a comment to T11120: HTML mails malformed.

Particularly helpful would be to write some comment on this task which reproduces the issue for you, then tell me which client you're using.

Jun 9 2016, 12:51 PM · Mail, Bug Report
epriestley closed T11119: arc diff should be able to work with uncommitted changes as Wontfix.

There are no plans to implement this for Git. Git has had robust history rewriting for a long time.

Jun 9 2016, 12:47 PM · Feature Request