Page MenuHomePhabricator
Feed Advanced Search

Oct 19 2015

epriestley added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

Ohhh! Sorry, we usually use "preview" to mean "remarkup preview" (the comment box thing at the bottom of the page) and I figured you were putting {P123} in a comment and getting slow comment previews.

Oct 19 2015, 3:26 PM · Paste
epriestley added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

From T9566, these are probably 1MB JSON blobs from API calls.

Oct 19 2015, 3:20 PM · Paste
epriestley added a comment to T9599: You have an unresolved setup issue... none left, just 3 ignored.

This message should go away when you've ignored everything.

Oct 19 2015, 2:07 PM · Setup, Installing & Upgrading
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

I'm still just working through this with CircleCI support. No real headway yet, turnaround has been ~24+ hours every time so we're still just discussing the problem.

Oct 19 2015, 1:59 PM · Restricted Project, Harbormaster
• mholden awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Oct 19 2015, 5:40 AM · Conpherence (v4)
epriestley added a comment to T9579: Outbound mail stopped working. Large items 'Queued'. ./bin/mail send-test works..

We're an open source project with a small team, and can't spend time working with individual installs to debug unusual issues that are specific to their environments or support old version of Phabricator. If we accepted these kinds of support requests, we would spend 100% of our development bandwidth debugging bizarre setup and configuration problems which affected single installs.

Oct 19 2015, 12:59 AM · Mail

Oct 18 2015

epriestley closed T9347: Upgrading: Herald blocking/non-blocking reviewer rules swapped as Resolved.

This has been in stable for more than a month without any followup issues cropping up.

Oct 18 2015, 3:25 PM · Differential, Herald, Installing & Upgrading
epriestley closed T9346: Upgrading: `auth.login-message` configuration option has been removed as Resolved.

I don't think that use case is strong enough to justify making this mechanism more complex. Some ideas:

Oct 18 2015, 3:24 PM · Installing & Upgrading
epriestley closed T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay` as Resolved.

There are a couple of minor followups between this original announcement and HEAD which improve some behaviors, but this has been in stable for about a month now.

Oct 18 2015, 3:20 PM · Remarkup, Security, Installing & Upgrading
epriestley closed T9465: Construction of a DateTime() with epoch raised an exception as Invalid.

Closing because we aren't able to reproduce this.

Oct 18 2015, 3:18 PM · Feed
epriestley closed T9488: track accounts who did git clone as Wontfix.

We may have some support for this after T1562, but probably will never have sufficiently granular upstream support to solve this particular problem. I don't anticipate ever disclosing who cloned things in a web-accessible way.

Oct 18 2015, 3:17 PM · Diffusion, Facts
epriestley renamed T9496: Allow Maniphest custom statuses (and priorities) to be disabled from Removing a custom status has unexpected side effects to Allow Maniphest custom statuses (and priorities) to be disabled.
Oct 18 2015, 2:45 PM · Maniphest
epriestley renamed T9524: Show aggregate subdirectory coverage in Diffusion browse views from Calling `diffusion.updatecoverage` cripples portions of the repository browsing UI to Show aggregate subdirectory coverage in Diffusion browse views.
Oct 18 2015, 2:43 PM · Diffusion, Restricted Project
epriestley closed T9531: Exclude some headings from TOC in Phriction as Wontfix.

No.

Oct 18 2015, 2:42 PM · Phriction
epriestley closed T9553: www.googleapis.com refuses GET with Content-Length as Wontfix.

I'm not sure why our workaround for this in rPHUe9fea5c64c0c wouldn't work for you, but it seems to work for other people so I'm going to chalk this up to something else in your environment until we see more reports.

Oct 18 2015, 2:41 PM · libphutil
epriestley added a comment to T9585: not able to delete tasks from phd queue.

Are you certain these tasks aren't being removed automatically? The expectation is that they will naturally fail over time when they are unable to load the corresponding commits.

Oct 18 2015, 2:38 PM · Daemons
epriestley closed T9579: Outbound mail stopped working. Large items 'Queued'. ./bin/mail send-test works. as Invalid.

Closing as unreproducible.

Oct 18 2015, 2:35 PM · Mail
epriestley closed T9590: Subversion directory anchoring rules are unclear and underpowered as Wontfix.

When we generate a synthetic diff between diffs "A" and "B", we just use diff and do not apply any move or rename detection on top of it.

Oct 18 2015, 2:31 PM · Differential, Subversion
epriestley closed T9570: Can a hosted Phacility instance be exported? as Resolved.

Presuming that answers the question, let us know if not. T7148 is the general production task here.

Oct 18 2015, 1:30 PM · Phacility Support
epriestley added a comment to T7045: Allow linters to be skipped.

Just collecting some more related stuff here: D14298 adds a .arclint-configurable version requirement check, which currently executes as a side effect of getCacheVersion().

Oct 18 2015, 1:16 PM · Differential, Lint
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Oct 18 2015, 11:22 AM
epriestley closed T9592: "Create subtask" is not greyed out for logged-out users as Resolved by committing Restricted Diffusion Commit.
Oct 18 2015, 11:22 AM · Maniphest

Oct 17 2015

epriestley updated subscribers of T9456: Evaluate upstream support for third-party build systems.

(+@colmdoyle, you expressed interest in this elsewhere.)

Oct 17 2015, 8:27 PM · Restricted Project, Harbormaster
epriestley added a comment to T9593: Counterexample header is incorrectly colored in email.

I think we always get that gap between the header and body in mail, too (even for non-counterexamples).

Oct 17 2015, 3:37 PM · Remarkup, Mail
epriestley edited the content of Changelog.
Oct 17 2015, 11:07 AM
epriestley created 2015 Week 42 (Mid October).
Oct 17 2015, 11:06 AM
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Oct 17 2015, 10:39 AM
epriestley added a comment to T9592: "Create subtask" is not greyed out for logged-out users.

That fix is close, but probably not quite right, because a user might be able to create a subtask without being able to edit the original task.

Oct 17 2015, 10:35 AM · Maniphest
epriestley added a comment to T9587: Detect old Pygments versions and encourage an upgrade.

From D14273, @gd also got a substantial performance improvement for long input lines applied to the Pygments upstream:

Oct 17 2015, 10:27 AM · Setup
epriestley merged task T9566: Timeouts when highlighting source with very long lines using pygmentize into T9587: Detect old Pygments versions and encourage an upgrade.
Oct 17 2015, 10:24 AM · Paste
epriestley updated subscribers of T9587: Detect old Pygments versions and encourage an upgrade.
Oct 17 2015, 10:24 AM · Setup
epriestley reopened T9566: Timeouts when highlighting source with very long lines using pygmentize as "Open".
Oct 17 2015, 10:24 AM · Paste
epriestley added a comment to T9566: Timeouts when highlighting source with very long lines using pygmentize.

That was just some random demo user clicking buttons. I'll merge 'em.

Oct 17 2015, 10:24 AM · Paste
• austinstoker awarded T182: Commit into repository directly from differential a Love token.
Oct 17 2015, 7:51 AM · Haskell.org, Restricted Project, Differential
epriestley renamed T6878: Tagged commits which are not ancestors of any branch head don't get imported from Tagged commits don't get imported to Tagged commits which are not ancestors of any branch head don't get imported.
Oct 17 2015, 12:31 AM · Wikimedia, Restricted Project, Diffusion
epriestley merged task T9591: after importing an external git repo into diffusion some commit details are missing into T6878: Tagged commits which are not ancestors of any branch head don't get imported.
Oct 17 2015, 12:30 AM · Diffusion
epriestley updated subscribers of T6878: Tagged commits which are not ancestors of any branch head don't get imported.
Oct 17 2015, 12:30 AM · Wikimedia, Restricted Project, Diffusion

Oct 16 2015

epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 16 2015, 9:33 PM · Haskell.org, Restricted Project, Differential
epriestley edited P1870 default fields.
Oct 16 2015, 9:20 PM
epriestley edited P1870 default fields.
Oct 16 2015, 9:19 PM
epriestley added a comment to T9588: Weird behaviour of arc diff --verbatim.

What's the syntax to have a propoer field header?

Oct 16 2015, 9:09 PM · Arcanist
epriestley added a comment to T9588: Weird behaviour of arc diff --verbatim.

We parse fields until we encounter the next field header because clients may linewrap, so the message above has a "Title" field with value change, and a "Differential Revision" field with value https://phabricator.collabora.co.uk/D244 refs T2495. This isn't a valid revision identifier so we can't figure out what to update.

Oct 16 2015, 9:03 PM · Arcanist
epriestley closed T9589: Weird behaviour of arc diff --edit as Invalid.

This is intentional. arc diff --verbatim is the flag you want, or use arc diff --edit to edit from the CLI instead of overwriting your Git commit message.

Oct 16 2015, 7:43 PM · Arcanist
epriestley added a comment to T9588: Weird behaviour of arc diff --verbatim.

I can't reproduce this. Here's what I did:

Oct 16 2015, 7:41 PM · Arcanist
epriestley added a comment to T9587: Detect old Pygments versions and encourage an upgrade.
  • Make these changes in PhabricatorPygmentSetupCheck.
    • Instead of running pygmentize -h to test that Pygments works, run pygmentize -V. This will let us test that the binary works, but also let us check the version.
    • After doing the existing "Does pygmentize work?" check, try to parse the version:
      • If we can't figure out what version it is, assume it's a future version of Pygments that changed the format of the version string and do nothing.
      • If the version is 2.0.0 or newer (you can use version_compare() to check), do nothing.
      • If the version is older than 2.0.0, recommend upgrading to a more recent version of Pygments to get support for more languages and improve performance. Advise the user that they can safely ignore this warning if they don't want to upgrade.
Oct 16 2015, 4:27 PM · Setup
epriestley created T9587: Detect old Pygments versions and encourage an upgrade.
Oct 16 2015, 4:13 PM · Setup
epriestley edited P1869 apache.conf.
Oct 16 2015, 4:08 PM
epriestley added a revision to T9566: Timeouts when highlighting source with very long lines using pygmentize: Unknown Object (Differential Revision).
Oct 16 2015, 2:54 PM · Paste
timor awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Mountain of Wealth token.
Oct 16 2015, 1:38 PM · Workboards (v3), Restricted Project
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

I'm continuing to work with CircleCI support on this, but no headway yet. I imagine they're still handling fallout from the recent service disruption.

Oct 16 2015, 1:12 PM · Restricted Project, Harbormaster
epriestley added a comment to T9564: Search Herald rules by name.

ApplicationEditor (T9132) and Nuance (T8783) are both scheduled for implementation before the end of the year and might offer alternatives here, too. With ApplicationEditor you could create 500 "create task" forms (instead of 500 teams) and have each form prepopulate with appropriate assignees, subscribers, projects, etc. With Nuance, you could create 500 queues (instead of 500 teams) and give each queue custom routing rules (and potentially have them just create tasks directly and not actually use Nuance).

Oct 16 2015, 12:21 PM · Herald
epriestley added a comment to T9564: Search Herald rules by name.

One note is that the transcript cost only includes the cost to evaluate the rules, not the cost to load the rules. The intent of the field was to catch rules which were unusually expensive to evaluate, but in the case of a large number of very simple rules, I would expect that the cost to load and build objects for rules would dominate the cost to evaluate them.

Oct 16 2015, 11:32 AM · Herald
epriestley added a comment to T9564: Search Herald rules by name.

In many cases, we must run Herald rules synchronously in the same process performing a write which triggers the rules. In some cases, this is strictly required: for example, when you push a commit, we clearly must evaluate at least some rules before we accept it, because a rule may say "don't accept this commit". If a rule may cause a "don't accept this commit" effect, we obviously must evaluate it before we accept the commit.

Oct 16 2015, 11:14 AM · Herald
epriestley closed T9578: What about implementing a DNS Almanac service as Wontfix.

It's vaguely possible we'll pursue this eventually, but I doubt it, and any such support is years away.

Oct 16 2015, 12:37 AM · Almanac
epriestley added a comment to T9582: Allow application email to create new tasks using a task template.

Would this work?

Oct 16 2015, 12:01 AM · Herald, Mail, Restricted Project

Oct 15 2015

nateguchi2 awarded T9378: Build Projects v3 a Love token.
Oct 15 2015, 9:55 PM · Projects (v3), Prioritized
nateguchi2 awarded T9515: Build a "quorum" mechanism and associated UI a Like token.
Oct 15 2015, 9:47 PM · Restricted Project, Notifications, Phacility, Auth
epriestley closed T9580: Slow POST/PUTs as Resolved.

Unsatisfying conclusion here, but:

Oct 15 2015, 7:43 PM · Phacility Support
epriestley closed T9581: Expand Phacility cluster repo and db tiers (add nodes: 004) as Resolved.
  • I closed the 003 nodes to new allocations and opened the 004 nodes.
  • I created a new test instance and verified it allocated on the 004 nodes.
  • I vetted backups, login, web, repo import, and daemon behavior on the new 004 nodes.
  • I also pruned some older test instances off of the 003 nodes and cycled them to give us a little more general headroom on repo003. Load should stabilize over time as more test instances suspend over time.
Oct 15 2015, 7:17 PM · Ops, Phacility
epriestley closed T9581: Expand Phacility cluster repo and db tiers (add nodes: 004), a subtask of T9580: Slow POST/PUTs, as Resolved.
Oct 15 2015, 7:17 PM · Phacility Support
epriestley added a comment to T9581: Expand Phacility cluster repo and db tiers (add nodes: 004).

I brought these nodes up normally, they're deploying now. I'll swap them over and vet things once that finishes up.

Oct 15 2015, 6:58 PM · Ops, Phacility
epriestley edited the content of Phacility Cluster Devices.
Oct 15 2015, 6:44 PM
epriestley edited the content of Phacility Cluster Devices.
Oct 15 2015, 6:44 PM
epriestley created T9581: Expand Phacility cluster repo and db tiers (add nodes: 004).
Oct 15 2015, 6:38 PM · Ops, Phacility
epriestley added a comment to T9580: Slow POST/PUTs.

(We caught up in IRC.)

Oct 15 2015, 6:34 PM · Phacility Support
epriestley added a comment to T9579: Outbound mail stopped working. Large items 'Queued'. ./bin/mail send-test works..

We can't reproduce this issue, other installs haven't reported similar problems, and you're about two months behind HEAD. Please refer to this document for instructions on filing an actionable bug report which we can help you with:

Oct 15 2015, 5:44 PM · Mail
epriestley closed T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts as Resolved.

One followup in T9573 but I don't think anything exploded, otherwise.

Oct 15 2015, 5:21 PM · Prioritized, Projects
epriestley closed T9273: Replace PhabricatorMarkupInterface with a better-suited API/abstraction as Resolved by committing Restricted Diffusion Commit.
Oct 15 2015, 5:20 PM · Prioritized, Remarkup
epriestley added a revision to T9273: Replace PhabricatorMarkupInterface with a better-suited API/abstraction: Unknown Object (Differential Revision).
Oct 15 2015, 5:09 PM · Prioritized, Remarkup
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

I also tried using the ref name (refs/tags/phabricator/diff/123) and the tag name (phabricator/diff/123) as branch names without success, so I'm pretty sure this isn't fixable on our side.

Oct 15 2015, 4:43 PM · Restricted Project, Harbormaster
epriestley added a revision to T9456: Evaluate upstream support for third-party build systems: Unknown Object (Differential Revision).
Oct 15 2015, 4:38 PM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

This basically works, but there's a minor problem which I can't fix on our side that stops things from working: CircleCI does not git fetch --tags, and does not fetch the tag explicitly when building a tag. It does resolve the tag, but never actually downloads the corresponding commit. This means that tags and other refs which are not ancestors of a branch head (which is to say: everything in the staging area) are not buildable. I don't think I can work around this because we need the commit to be fetched in order to make it to the checkout: post: step.

Oct 15 2015, 4:34 PM · Restricted Project, Harbormaster
epriestley closed T9577: Why do workboards have story point displays and limits if there's no way to customize the size of a card? as Wontfix.

I think I misunderstood and by "size" you just meant "point value". This will happen eventually as part of other projects work (T9378, T3670) but those need to happen first. I'm not yet sure if we're going to make this a first-class value or let you designate a custom field as a "points field" or something else.

Oct 15 2015, 3:12 PM · Workboards
epriestley added a comment to T9577: Why do workboards have story point displays and limits if there's no way to customize the size of a card?.

Your expectation is that a card worth 10 points is rendered 10 times larger than a card worth 1 point?

Oct 15 2015, 2:59 PM · Workboards
epriestley closed T9573: Documents with " - " space hyphen space are inaccessible as Resolved by committing Restricted Diffusion Commit.
Oct 15 2015, 2:04 PM · Phriction
epriestley added a comment to T9576: "Send an email when projects include X" Herald rule ignores the "Ignore subscriber changes" email notification preference.

This is definitely something which can be improved -- the transcript has been updated recently and is fairly clear ("Forced Mail", "...ignoring notification preferences..."). The /mail/ UI is fairly clear too, but hard to find right now. Other UIs and interactions haven't been updated as recently and aren't as clear.

Oct 15 2015, 2:02 PM · Notifications
epriestley added a comment to T9576: "Send an email when projects include X" Herald rule ignores the "Ignore subscriber changes" email notification preference.

See also this in the transcript:

Oct 15 2015, 1:17 PM · Notifications
epriestley added a comment to T9576: "Send an email when projects include X" Herald rule ignores the "Ignore subscriber changes" email notification preference.

aklapper (Andre Klapper)

  • Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).
  • Forced by Herald: This recipient was added by a "Send me an Email" rule in Herald, which overrides some delivery settings.
Oct 15 2015, 1:16 PM · Notifications
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Branch name issues aside, CircleCI still isn't running builds for me, so I'm going to have to shelve this for now.

Oct 15 2015, 11:03 AM · Restricted Project, Harbormaster
epriestley claimed T9573: Documents with " - " space hyphen space are inaccessible .
Oct 15 2015, 10:32 AM · Phriction
epriestley added a revision to T9573: Documents with " - " space hyphen space are inaccessible : Unknown Object (Differential Revision).
Oct 15 2015, 10:32 AM · Phriction
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Screen Shot 2015-10-15 at 3.25.21 AM.png (590×1 px, 80 KB)

Oct 15 2015, 10:29 AM · Restricted Project, Harbormaster
epriestley merged T9575: Make Passphrase policies clearer into T4721: Improve user-facing documentation for Passphrase.
Oct 15 2015, 10:26 AM · Documentation, Passphrase
epriestley merged task T9575: Make Passphrase policies clearer into T4721: Improve user-facing documentation for Passphrase.
Oct 15 2015, 10:26 AM · Policy, Passphrase
d.maznekov awarded T7924: Unprototype Calendar (v1) a Mountain of Wealth token.
Oct 15 2015, 6:57 AM · Restricted Project, Prioritized, Calendar
• loic.dreux awarded T4548: Support "Mylyn" Eclipse plugin a Love token.
Oct 15 2015, 6:07 AM · Feature Request, Maniphest
epriestley added Q178: Advice on tracking benchmarks/performance per diff or commit (Answer 210).
Oct 15 2015, 4:26 AM
epriestley updated the task description for T9456: Evaluate upstream support for third-party build systems.
Oct 15 2015, 4:12 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

CircleCI still isn't running builds for me so I can't reasonably do step 4 (the webhook part) tonight. Presumably they'll be back up by tomorrow and I can finish this up.

Oct 15 2015, 4:06 AM · Restricted Project, Harbormaster
epriestley added a revision to T9456: Evaluate upstream support for third-party build systems: Unknown Object (Differential Revision).
Oct 15 2015, 4:02 AM · Restricted Project, Harbormaster
epriestley reopened T9572: Thumbs up icon should be clickable as "Open".
Oct 15 2015, 4:00 AM · Ponder
epriestley added a comment to Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default?.
CommandNowRequire --everythingCheck Parent Workflow
arc diffRuns TestsNo TestsNo Tests
arc unitRuns Tests No Tests Runs Tests
arc unit --everythingRuns TestsRuns TestsRuns Tests
Oct 15 2015, 3:44 AM · Arcanist
epriestley added a comment to Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default?.

The test engine can figure out if --everything is present or not but I don't think it can reach up to the workflow object right now. So you can disable arc unit as a sub-step of arc diff, but not without also disabling arc unit when run without --everything.

Oct 15 2015, 3:42 AM · Arcanist
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

We can use a branch name like "zzz_harbormaster" or something so the console doesn't clutter up too much.

Oct 15 2015, 3:28 AM · Restricted Project, Harbormaster
epriestley added a comment to Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default?.

Is running arc unit interactively ever desirable? Can you either disconnect the integration entirely, or have it no-op if the --everything flag is not present (if you rely on --target for build integration)?

Oct 15 2015, 3:27 AM · Arcanist
epriestley added a comment to Q175: Should I Reuse Device Keys? (Answer 207).

Right. If you put it on multiple devices, we can't choose a single identity when you try to do anything with that key. I don't actually remember why we're even allowing that at all and suspect it's some legacy stuff from an early draft that no longer makes any sense.

Oct 15 2015, 3:17 AM
epriestley closed T9571: Ponder questions don't get parsed in remarkup as Resolved.
Oct 15 2015, 2:43 AM · Ponder
epriestley added a comment to Q174: Should / Can I Reuse an Almanac Device (Answer 208).

No, it's more like this:

Oct 15 2015, 2:38 AM
epriestley added a comment to T9571: Ponder questions don't get parsed in remarkup.

I think I just configured remarkup.ignored-object-names wrong when I added S3, should be OK now going forward.

Oct 15 2015, 2:10 AM · Ponder
epriestley added a comment to T9529: Upload coverage to a diff.

Try the diff PHID -- $diff->getPHID()?

Oct 15 2015, 1:59 AM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster